🎨 Set up linting and formatting (#2120)

* ⬆️ Upgrade TS to 4.3.5

* 👕 Add ESLint configs

* 🎨 Add Prettier config

* 📦 Add deps and commands

* ⚡ Adjust global .editorconfig to new ruleset

* 🔥 Remove unneeded local .editorconfig

* 📦 Update deps in editor-ui

* 🔨 Limit Prettier to only TS files

* ⚡ Add recommended VSCode extensions

* 👕 Fix build

* 🔥 Remove Vue setting from global config

* ⚡ Disable prefer-default-export per feedback

* ✏️ Add forgotten divider

* 👕 Disable no-plusplus

* 👕 Disable class-methods-use-this

* ✏️ Alphabetize overrides

* 👕 Add one-var consecutive override

* ⏪ Revert one-var consecutive override

This reverts commit b9252cf935659ba6d76727ad484a1d3c00008fcc.

* 🎨 👕 Lint and format workflow package (#2121)

* 🎨 Format /workflow package

* 👕 Lint /workflow package

* 🎨 Re-format /workflow package

* 👕 Re-lint /workflow package

* ✏️ Fix typo

* ⚡ Consolidate if-checks

* 🔥 Remove prefer-default-export exceptions

* 🔥 Remove no-plusplus exceptions

* 🔥 Remove class-methods-use-this exceptions

* 🎨 👕 Lint and format node-dev package (#2122)

* 🎨 Format /node-dev package

* ⚡ Exclude templates from ESLint config

This keeps the templates consistent with the codebase while preventing lint exceptions from being made part of the templates.

* 👕 Lint /node-dev package

* 🔥 Remove prefer-default-export exceptions

* 🔥 Remove no-plusplus exceptions

* 🎨 👕 Lint and format core package (#2123)

* 🎨 Format /core package

* 👕 Lint /core package

* 🎨 Re-format /core package

* 👕 Re-lint /core package

* 🔥 Remove prefer-default-export exceptions

* 🔥 Remove no-plusplus exceptions

* 🔥 Remove class-methods-use-this exceptions

* 🎨 👕 Lint and format cli package (#2124)

* 🎨 Format /cli package

* 👕 Exclude migrations from linting

* 👕 Lint /cli package

* 🎨 Re-format /cli package

* 👕 Re-lint /cli package

* 👕 Fix build

* 🔥 Remove prefer-default-export exceptions

* ⚡ Update exceptions in ActiveExecutions

* 🔥 Remove no-plusplus exceptions

* 🔥 Remove class-methods-use-this exceptions

* 👕 fix lint issues

* 🔧 use package specific linter, remove tslint command

* 🔨 resolve build issue, sync dependencies

* 🔧 change lint command

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

packages/core/src/ActiveWorkflows.ts

@@ -1,3 +1,6 @@
+/* eslint-disable no-continue */
+/* eslint-disable no-await-in-loop */
+/* eslint-disable no-restricted-syntax */
 import { CronJob } from 'cron';
 
 import {
@@ -13,18 +16,14 @@ import {
 	WorkflowExecuteMode,
 } from 'n8n-workflow';
 
-import {
-	ITriggerTime,
-	IWorkflowData,
-} from './';
-
+// eslint-disable-next-line import/no-cycle
+import { ITriggerTime, IWorkflowData } from '.';
 
 export class ActiveWorkflows {
 	private workflowData: {
 		[key: string]: IWorkflowData;
 	} = {};
 
-
 	/**
 	 * Returns if the workflow is active
 	 *
@@ -33,10 +32,10 @@ export class ActiveWorkflows {
 	 * @memberof ActiveWorkflows
 	 */
 	isActive(id: string): boolean {
+		// eslint-disable-next-line no-prototype-builtins
 		return this.workflowData.hasOwnProperty(id);
 	}
 
-
 	/**
 	 * Returns the ids of the currently active workflows
 	 *
@@ -47,7 +46,6 @@ export class ActiveWorkflows {
 		return Object.keys(this.workflowData);
 	}
 
-
 	/**
 	 * Returns the Workflow data for the workflow with
 	 * the given id if it is currently active
@@ -60,7 +58,6 @@ export class ActiveWorkflows {
 		return this.workflowData[id];
 	}
 
-
 	/**
 	 * Makes a workflow active
 	 *
@@ -70,16 +67,31 @@ export class ActiveWorkflows {
 	 * @returns {Promise<void>}
 	 * @memberof ActiveWorkflows
 	 */
-	async add(id: string, workflow: Workflow, additionalData: IWorkflowExecuteAdditionalData, mode: WorkflowExecuteMode, activation: WorkflowActivateMode, getTriggerFunctions: IGetExecuteTriggerFunctions, getPollFunctions: IGetExecutePollFunctions): Promise<void> {
+	async add(
+		id: string,
+		workflow: Workflow,
+		additionalData: IWorkflowExecuteAdditionalData,
+		mode: WorkflowExecuteMode,
+		activation: WorkflowActivateMode,
+		getTriggerFunctions: IGetExecuteTriggerFunctions,
+		getPollFunctions: IGetExecutePollFunctions,
+	): Promise<void> {
 		this.workflowData[id] = {};
 		const triggerNodes = workflow.getTriggerNodes();
 
 		let triggerResponse: ITriggerResponse | undefined;
 		this.workflowData[id].triggerResponses = [];
 		for (const triggerNode of triggerNodes) {
-			triggerResponse = await workflow.runTrigger(triggerNode, getTriggerFunctions, additionalData, mode, activation);
+			triggerResponse = await workflow.runTrigger(
+				triggerNode,
+				getTriggerFunctions,
+				additionalData,
+				mode,
+				activation,
+			);
 			if (triggerResponse !== undefined) {
 				// If a response was given save it
+				// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
 				this.workflowData[id].triggerResponses!.push(triggerResponse);
 			}
 		}
@@ -88,12 +100,21 @@ export class ActiveWorkflows {
 		if (pollNodes.length) {
 			this.workflowData[id].pollResponses = [];
 			for (const pollNode of pollNodes) {
-				this.workflowData[id].pollResponses!.push(await this.activatePolling(pollNode, workflow, additionalData, getPollFunctions, mode, activation));
+				// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+				this.workflowData[id].pollResponses!.push(
+					await this.activatePolling(
+						pollNode,
+						workflow,
+						additionalData,
+						getPollFunctions,
+						mode,
+						activation,
+					),
+				);
 			}
 		}
 	}
 
-
 	/**
 	 * Activates polling for the given node
 	 *
@@ -104,7 +125,14 @@ export class ActiveWorkflows {
 	 * @returns {Promise<IPollResponse>}
 	 * @memberof ActiveWorkflows
 	 */
-	async activatePolling(node: INode, workflow: Workflow, additionalData: IWorkflowExecuteAdditionalData, getPollFunctions: IGetExecutePollFunctions, mode: WorkflowExecuteMode, activation: WorkflowActivateMode): Promise<IPollResponse> {
+	async activatePolling(
+		node: INode,
+		workflow: Workflow,
+		additionalData: IWorkflowExecuteAdditionalData,
+		getPollFunctions: IGetExecutePollFunctions,
+		mode: WorkflowExecuteMode,
+		activation: WorkflowActivateMode,
+	): Promise<IPollResponse> {
 		const pollFunctions = getPollFunctions(workflow, node, additionalData, mode, activation);
 
 		const pollTimes = pollFunctions.getNodeParameter('pollTimes') as unknown as {
@@ -113,12 +141,12 @@ export class ActiveWorkflows {
 
 		// Define the order the cron-time-parameter appear
 		const parameterOrder = [
-			'second',     // 0 - 59
-			'minute',     // 0 - 59
-			'hour',       // 0 - 23
+			'second', // 0 - 59
+			'minute', // 0 - 59
+			'hour', // 0 - 23
 			'dayOfMonth', // 1 - 31
-			'month',      // 0 - 11(Jan - Dec)
-			'weekday',    // 0 - 6(Sun - Sat)
+			'month', // 0 - 11(Jan - Dec)
+			'weekday', // 0 - 6(Sun - Sat)
 		];
 
 		// Get all the trigger times
@@ -165,10 +193,15 @@ export class ActiveWorkflows {
 
 		// The trigger function to execute when the cron-time got reached
 		const executeTrigger = async () => {
-			Logger.info(`Polling trigger initiated for workflow "${workflow.name}"`, {workflowName: workflow.name, workflowId: workflow.id});
+			// eslint-disable-next-line @typescript-eslint/restrict-template-expressions
+			Logger.info(`Polling trigger initiated for workflow "${workflow.name}"`, {
+				workflowName: workflow.name,
+				workflowId: workflow.id,
+			});
 			const pollResponse = await workflow.runPoll(node, pollFunctions);
 
 			if (pollResponse !== null) {
+				// eslint-disable-next-line no-underscore-dangle
 				pollFunctions.__emit(pollResponse);
 			}
 		};
@@ -180,6 +213,7 @@ export class ActiveWorkflows {
 
 		// Start the cron-jobs
 		const cronJobs: CronJob[] = [];
+		// eslint-disable-next-line @typescript-eslint/no-shadow
 		for (const cronTime of cronTimes) {
 			const cronTimeParts = cronTime.split(' ');
 			if (cronTimeParts.length > 0 && cronTimeParts[0].includes('*')) {
@@ -201,7 +235,6 @@ export class ActiveWorkflows {
 		};
 	}
 
-
 	/**
 	 * Makes a workflow inactive
 	 *
@@ -212,7 +245,9 @@ export class ActiveWorkflows {
 	async remove(id: string): Promise<void> {
 		if (!this.isActive(id)) {
 			// Workflow is currently not registered
-			throw new Error(`The workflow with the id "${id}" is currently not active and can so not be removed`);
+			throw new Error(
+				`The workflow with the id "${id}" is currently not active and can so not be removed`,
+			);
 		}
 
 		const workflowData = this.workflowData[id];
@@ -235,5 +270,4 @@ export class ActiveWorkflows {
 
 		delete this.workflowData[id];
 	}
-
 }