ci: Migrate to artifact upload/download for builds (#19688)

Co-authored-by: Elias Meire <elias@meire.dev>

.github/workflows/release-publish.yml

@@ -8,8 +8,7 @@ on:
       - 'release/*'
 
 env:
-  BUILD_CACHE_KEY: ${{ github.sha }}-release:build
-
+  BUILD_DIST_NAME: build-dist-${{ github.sha }}
 jobs:
   build-amd64:
     runs-on: blacksmith-4vcpu-ubuntu-2204
@@ -24,11 +23,13 @@ jobs:
       - name: Setup Environment
         uses: ./.github/actions/setup-nodejs-blacksmith
 
-      - name: Cache to GH
-        uses: actions/cache/save@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
+      - name: Upload build artifacts
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
         with:
+          name: ${{ env.BUILD_DIST_NAME }}
           path: ./packages/**/dist
-          key: ${{ env.BUILD_CACHE_KEY }}
+          if-no-files-found: error
+          retention-days: 7
 
   build-arm64:
     runs-on: blacksmith-4vcpu-ubuntu-2204-arm
@@ -73,12 +74,11 @@ jobs:
       - name: Set release version in env
         run: echo "RELEASE=$(node -e 'console.log(require("./package.json").version)')" >> "$GITHUB_ENV"
 
-      - name: Restore build artifacts
-        uses: actions/cache/restore@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
+      - name: Download build artifacts
+        uses: actions/download-artifact@65d862660abb3549b588b37db4038d3fd1a05f8a # v4.1.8
         with:
-          fail-on-cache-miss: true
-          path: ./packages/**/dist
-          key: ${{ env.BUILD_CACHE_KEY }}
+          name: ${{ env.BUILD_DIST_NAME }}
+          path: .
 
       - name: Dry-run publishing
         run: |
@@ -94,10 +94,14 @@ jobs:
           sed -i "s/default: 'dev'/default: 'stable'/g" packages/cli/dist/config/schema.js
 
       - name: Publish n8n to NPM with rc tag
-        run: pnpm --filter n8n publish --publish-branch ${{github.event.pull_request.base.ref}} --access public --tag rc --no-git-checks
+        env:
+          PUBLISH_BRANCH: ${{ github.event.pull_request.base.ref }}
+        run: pnpm --filter n8n publish --publish-branch "$PUBLISH_BRANCH" --access public --tag rc --no-git-checks
 
       - name: Publish other packages to NPM with latest tag
-        run: pnpm publish -r --filter '!n8n' --publish-branch ${{github.event.pull_request.base.ref}} --access public --no-git-checks
+        env:
+          PUBLISH_BRANCH: ${{ github.event.pull_request.base.ref }}
+        run: pnpm publish -r --filter '!n8n' --publish-branch "$PUBLISH_BRANCH" --access public --no-git-checks
 
       - name: Cleanup rc tag
         run: npm dist-tag rm n8n rc
@@ -148,11 +152,11 @@ jobs:
 
     steps:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
-      - name: Restore cached build artifacts
-        uses: actions/cache/restore@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
+      - name: Download build artifacts
+        uses: actions/download-artifact@65d862660abb3549b588b37db4038d3fd1a05f8a # v4.1.8
         with:
-          path: ./packages/**/dist
-          key: ${{ env.BUILD_CACHE_KEY }}
+          name: ${{ env.BUILD_DIST_NAME }}
+          path: .
 
       - name: Create a frontend release
         uses: getsentry/action-release@e769183448303de84c5a06aaaddf9da7be26d6c7 # v1.7.0