From 57aab63c1049cf3d0c4730fe6bf01d252e8746d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Mon, 24 Apr 2023 12:18:24 +0200 Subject: [PATCH] refactor: Integrate `consistent-type-imports` in FE packages (no-changelog) (#6060) * :shirt: Move `consistent-type-imports` to top level * :shirt: Apply lintfixes * :shirt: Apply more lintfixes * :shirt: More lintfixes * :shirt: More lintfixes --- packages/@n8n_io/eslint-config/base.js | 5 ++++ packages/cli/.eslintrc.js | 2 -- packages/core/.eslintrc.js | 2 -- .../N8nActionDropdown/ActionDropdown.vue | 3 ++- .../N8nActionToggle/ActionToggle.vue | 3 ++- .../src/components/N8nDatatable/Datatable.vue | 5 ++-- .../components/N8nDatatable/__tests__/data.ts | 5 ++-- .../src/components/N8nFormInput/FormInput.vue | 2 +- .../src/components/N8nFormInput/validators.ts | 2 +- .../components/N8nFormInputs/FormInputs.vue | 6 +++-- .../N8nInfoAccordion/InfoAccordion.vue | 3 ++- .../src/components/N8nMarkdown/Markdown.vue | 6 +++-- .../src/components/N8nMenu/Menu.vue | 3 ++- .../src/components/N8nMenuItem/MenuItem.vue | 3 ++- .../NodeCreatorNode.stories.ts | 2 +- .../components/N8nPagination/Pagination.vue | 3 ++- .../N8nRadioButtons/RadioButtons.vue | 3 ++- .../RecycleScroller.stories.ts | 2 +- .../N8nRecycleScroller/RecycleScroller.vue | 13 ++-------- .../N8nResizeWrapper/ResizeWrapper.vue | 3 ++- .../src/components/N8nTabs/Tabs.vue | 3 ++- .../src/components/N8nTags/Tags.vue | 3 ++- .../src/components/N8nTooltip/Tooltip.vue | 3 ++- .../src/components/N8nTree/Tree.vue | 3 ++- .../components/N8nUserSelect/UserSelect.vue | 5 ++-- .../N8nUsersList/UsersList.stories.ts | 2 +- .../src/components/N8nUsersList/UsersList.vue | 3 ++- .../src/styleguide/ColorCircles.vue | 3 ++- .../design-system/src/styleguide/Sizes.vue | 3 ++- .../src/styleguide/VariableTable.vue | 3 ++- packages/design-system/src/types/datatable.ts | 2 +- packages/editor-ui/src/Interface.ts | 14 +++++------ .../src/__tests__/permissions.spec.ts | 2 +- .../__tests__/server/endpoints/credential.ts | 5 ++-- .../server/endpoints/credentialType.ts | 5 ++-- .../src/__tests__/server/endpoints/index.ts | 2 +- .../__tests__/server/endpoints/settings.ts | 7 +++--- .../src/__tests__/server/endpoints/user.ts | 5 ++-- .../__tests__/server/endpoints/variable.ts | 7 +++--- .../src/__tests__/server/models/credential.ts | 2 +- .../src/__tests__/server/models/user.ts | 2 +- .../src/__tests__/server/models/variable.ts | 2 +- .../editor-ui/src/__tests__/server/types.ts | 8 +++---- packages/editor-ui/src/__tests__/utils.ts | 3 ++- packages/editor-ui/src/api/api-keys.ts | 2 +- packages/editor-ui/src/api/communityNodes.ts | 4 ++-- packages/editor-ui/src/api/credentials.ee.ts | 4 ++-- packages/editor-ui/src/api/credentials.ts | 8 +++++-- packages/editor-ui/src/api/curlHelper.ts | 2 +- packages/editor-ui/src/api/environments.ee.ts | 4 ++-- packages/editor-ui/src/api/eventbus.ee.ts | 4 ++-- packages/editor-ui/src/api/ldap.ts | 4 ++-- packages/editor-ui/src/api/settings.ts | 4 ++-- packages/editor-ui/src/api/sso.ts | 2 +- packages/editor-ui/src/api/tags.ts | 2 +- packages/editor-ui/src/api/templates.ts | 4 ++-- packages/editor-ui/src/api/usage.ts | 2 +- packages/editor-ui/src/api/users.ts | 4 ++-- packages/editor-ui/src/api/versions.ts | 2 +- .../editor-ui/src/api/workflow-webhooks.ts | 3 ++- packages/editor-ui/src/api/workflows.ee.ts | 4 ++-- packages/editor-ui/src/api/workflows.ts | 11 +++------ .../src/components/BinaryDataDisplayEmbed.vue | 3 ++- .../src/components/ChangePasswordModal.vue | 2 +- .../editor-ui/src/components/CodeEdit.vue | 7 +++--- .../CodeNodeEditor/CodeNodeEditor.vue | 3 ++- .../src/components/CodeNodeEditor/linter.ts | 3 ++- .../src/components/CodeNodeEditor/utils.ts | 2 +- .../src/components/CollectionParameter.vue | 7 +++--- .../src/components/CollectionsCarousel.vue | 4 ++-- .../src/components/CommunityPackageCard.vue | 2 +- .../src/components/ContactPromptModal.vue | 2 +- .../src/components/CredentialCard.vue | 7 +++--- .../CredentialEdit/AuthTypeSelector.vue | 4 ++-- .../CredentialEdit/CredentialConfig.vue | 6 ++--- .../CredentialEdit/CredentialEdit.vue | 12 ++++++---- .../CredentialEdit/CredentialInfo.vue | 2 +- .../CredentialEdit/CredentialInputs.vue | 4 ++-- .../CredentialEdit/CredentialSharing.ee.vue | 3 ++- .../src/components/CredentialIcon.vue | 2 +- .../src/components/CredentialsSelect.vue | 4 ++-- .../src/components/DeleteUserModal.vue | 2 +- .../editor-ui/src/components/Draggable.vue | 2 +- .../components/DuplicateWorkflowDialog.vue | 5 ++-- .../src/components/EnterpriseEdition.ee.vue | 2 +- .../src/components/Error/NodeErrorView.vue | 2 +- .../src/components/ExecutionsList.vue | 2 +- .../ExecutionsView/ExecutionCard.vue | 5 ++-- .../ExecutionsView/ExecutionPreview.vue | 3 ++- .../ExecutionsInfoAccordion.vue | 3 ++- .../ExecutionsView/ExecutionsList.vue | 8 +++---- .../ExecutionsView/ExecutionsSidebar.vue | 6 ++--- .../src/components/ExpressionEdit.vue | 2 +- .../src/components/FeatureComingSoon.vue | 2 +- .../components/FixedCollectionParameter.vue | 2 +- .../src/components/HoverableNodeIcon.vue | 4 ++-- .../src/components/HtmlEditor/HtmlEditor.vue | 5 ++-- .../src/components/ImportCurlModal.vue | 2 +- .../editor-ui/src/components/InputPanel.vue | 4 ++-- .../src/components/InviteUsersModal.vue | 2 +- .../src/components/MainHeader/MainHeader.vue | 4 ++-- .../components/MainHeader/WorkflowDetails.vue | 5 ++-- .../editor-ui/src/components/MainSidebar.vue | 2 +- .../src/components/MultipleParameter.vue | 3 ++- .../src/components/NDVDraggablePanels.vue | 5 ++-- packages/editor-ui/src/components/Node.vue | 11 ++++----- .../Node/NodeCreator/ActionItem.vue | 4 ++-- .../Node/NodeCreator/CategorizedItems.vue | 6 ++--- .../Node/NodeCreator/CategoryItem.vue | 2 +- .../Node/NodeCreator/ItemIterator.vue | 2 +- .../components/Node/NodeCreator/MainPanel.vue | 11 ++++----- .../components/Node/NodeCreator/NodeItem.vue | 2 +- .../components/Node/NodeCreator/SearchBar.vue | 2 +- .../Node/NodeCreator/SubcategoryItem.vue | 2 +- .../components/Node/NodeCreator/ViewItem.vue | 2 +- .../src/components/NodeCredentials.vue | 6 ++--- .../src/components/NodeDetailsView.vue | 6 ++--- .../src/components/NodeExecuteButton.vue | 4 ++-- .../editor-ui/src/components/NodeIcon.vue | 4 ++-- .../editor-ui/src/components/NodeList.vue | 2 +- .../editor-ui/src/components/NodeSettings.vue | 15 ++++++------ .../src/components/NodeSettingsTabs.vue | 4 ++-- .../editor-ui/src/components/NodeWebhooks.vue | 2 +- .../editor-ui/src/components/OutputPanel.vue | 6 ++--- .../src/components/ParameterInput.vue | 9 ++++--- .../src/components/ParameterInputExpanded.vue | 4 ++-- .../src/components/ParameterInputFull.vue | 14 +++++++---- .../src/components/ParameterInputList.vue | 7 +++--- .../src/components/ParameterInputWrapper.vue | 10 ++++---- .../src/components/PersonalizationModal.vue | 4 ++-- .../ResourceLocator/ResourceLocator.vue | 10 ++++---- .../ResourceLocatorDropdown.vue | 2 +- packages/editor-ui/src/components/RunData.vue | 6 ++--- .../editor-ui/src/components/RunDataJson.vue | 6 ++--- .../src/components/RunDataJsonActions.vue | 6 ++--- .../src/components/RunDataSchema.vue | 4 ++-- .../src/components/RunDataSchemaItem.vue | 2 +- .../editor-ui/src/components/RunDataTable.vue | 7 +++--- .../EventDestinationCard.ee.vue | 14 +++++------ .../EventDestinationSettingsModal.ee.vue | 20 +++++++++------- .../EventSelection.ee.vue | 2 +- .../SettingsLogStreaming/Helpers.ee.ts | 8 +++++-- .../SettingsLogStreaming/descriptions.ee.ts | 2 +- .../src/components/SettingsSidebar.vue | 6 ++--- packages/editor-ui/src/components/Sticky.vue | 5 ++-- .../src/components/TagsContainer.vue | 2 +- .../editor-ui/src/components/TagsDropdown.vue | 8 +++---- .../components/TagsManager/TagsManager.vue | 2 +- .../TagsManager/TagsView/TagsTable.vue | 6 ++--- .../editor-ui/src/components/Telemetry.vue | 2 +- .../src/components/TemplateDetails.vue | 2 +- .../src/components/TemplateFilters.vue | 2 +- packages/editor-ui/src/components/TimeAgo.vue | 3 ++- .../editor-ui/src/components/TriggerPanel.vue | 8 +++---- .../editor-ui/src/components/UpdatesPanel.vue | 2 +- .../editor-ui/src/components/ValueSurvey.vue | 2 +- .../src/components/VariableSelector.vue | 12 ++++------ .../src/components/VariableSelectorItem.vue | 2 +- .../editor-ui/src/components/VariablesRow.vue | 6 +++-- .../editor-ui/src/components/VersionCard.vue | 2 +- .../editor-ui/src/components/WorkflowCard.vue | 7 +++--- .../src/components/WorkflowPreview.vue | 2 +- .../src/components/WorkflowSettings.vue | 7 +++--- .../src/components/WorkflowShareModal.ee.vue | 10 ++++---- .../__tests__/ExecutionFilter.test.ts | 3 ++- .../components/__tests__/VariablesRow.spec.ts | 2 +- .../forms/ResourceOwnershipSelect.ee.vue | 2 +- .../layouts/ResourcesListLayout.vue | 7 +++--- .../__tests__/useHistoryHelper.test.ts | 2 +- .../src/composables/useCanvasMouseSelect.ts | 2 +- .../src/composables/useHistoryHelper.ts | 5 ++-- .../editor-ui/src/composables/useTelemetry.ts | 3 ++- .../src/composables/useTitleChange.ts | 2 +- .../src/composables/useUpgradeLink.ts | 2 +- packages/editor-ui/src/constants.ts | 2 +- .../editor-ui/src/mixins/completionManager.ts | 2 +- .../editor-ui/src/mixins/executionsHelpers.ts | 2 +- packages/editor-ui/src/mixins/nodeBase.ts | 10 ++++---- packages/editor-ui/src/mixins/nodeHelpers.ts | 6 ++--- packages/editor-ui/src/mixins/pinData.ts | 4 ++-- .../editor-ui/src/mixins/pushConnection.ts | 6 ++--- packages/editor-ui/src/mixins/restApi.ts | 9 ++++--- packages/editor-ui/src/mixins/showMessage.ts | 4 ++-- .../editor-ui/src/mixins/workflowHelpers.ts | 16 ++++++------- packages/editor-ui/src/mixins/workflowRun.ts | 11 +++------ packages/editor-ui/src/models/history.ts | 6 ++--- packages/editor-ui/src/permissions.ts | 9 ++----- .../completions/__tests__/completions.test.ts | 3 ++- .../codemirror/completions/__tests__/mock.ts | 6 ++--- .../completions/datatype.completions.ts | 5 ++-- .../luxon.instance.docs.ts | 2 +- .../luxon.static.docs.ts | 2 +- .../codemirror/completions/typeGuards.ts | 2 +- .../plugins/codemirror/completions/types.ts | 2 +- .../inputHandlers/code.inputHandler.ts | 3 ++- .../inputHandlers/expression.inputHandler.ts | 3 ++- .../codemirror/resolvableHighlighter.ts | 3 ++- .../plugins/connectors/N8nCustomConnector.ts | 11 ++++----- .../plugins/endpoints/N8nPlusEndpointType.ts | 5 ++-- packages/editor-ui/src/plugins/i18n/index.ts | 5 ++-- .../editor-ui/src/plugins/telemetry/index.ts | 6 ++--- packages/editor-ui/src/router.ts | 7 +++--- .../src/stores/__tests__/environments.spec.ts | 2 +- .../src/stores/__tests__/posthog.test.ts | 2 +- .../src/stores/__tests__/sso.test.ts | 2 +- packages/editor-ui/src/stores/canvas.ts | 7 +++--- .../editor-ui/src/stores/communityNodes.ts | 4 ++-- packages/editor-ui/src/stores/credentials.ts | 6 ++--- .../editor-ui/src/stores/environments.ee.ts | 2 +- packages/editor-ui/src/stores/history.ts | 5 ++-- .../editor-ui/src/stores/logStreamingStore.ts | 3 ++- packages/editor-ui/src/stores/n8nRootStore.ts | 4 ++-- packages/editor-ui/src/stores/ndv.ts | 10 ++++++-- packages/editor-ui/src/stores/nodeCreator.ts | 8 +++---- packages/editor-ui/src/stores/nodeTypes.ts | 4 ++-- packages/editor-ui/src/stores/posthog.ts | 5 ++-- packages/editor-ui/src/stores/segment.ts | 4 ++-- packages/editor-ui/src/stores/settings.ts | 14 ++++------- packages/editor-ui/src/stores/sso.ts | 2 +- packages/editor-ui/src/stores/tags.ts | 2 +- packages/editor-ui/src/stores/telemetry.ts | 5 ++-- packages/editor-ui/src/stores/templates.ts | 2 +- packages/editor-ui/src/stores/ui.ts | 5 ++-- packages/editor-ui/src/stores/usage.ts | 2 +- packages/editor-ui/src/stores/versions.ts | 2 +- packages/editor-ui/src/stores/webhooks.ts | 6 ++--- packages/editor-ui/src/stores/workflows.ee.ts | 2 +- packages/editor-ui/src/stores/workflows.ts | 10 ++++---- .../src/utils/__tests__/mappingUtils.test.ts | 2 +- .../src/utils/__tests__/typesUtils.test.ts | 2 +- .../src/utils/__tests__/userUtils.test.ts | 4 ++-- packages/editor-ui/src/utils/apiUtils.ts | 5 ++-- packages/editor-ui/src/utils/canvasUtils.ts | 8 +++---- .../editor-ui/src/utils/executionUtils.ts | 4 ++-- packages/editor-ui/src/utils/forceParse.ts | 2 +- packages/editor-ui/src/utils/mappingUtils.ts | 3 ++- .../editor-ui/src/utils/nodeTypesUtils.ts | 6 ++--- packages/editor-ui/src/utils/nodeViewUtils.ts | 9 +++---- .../editor-ui/src/utils/pairedItemUtils.ts | 4 ++-- packages/editor-ui/src/utils/typeGuards.ts | 6 ++--- packages/editor-ui/src/utils/typesUtils.ts | 5 ++-- packages/editor-ui/src/utils/userUtils.ts | 4 ++-- .../editor-ui/src/views/CanvasAddButton.vue | 2 +- .../src/views/ChangePasswordView.vue | 2 +- .../editor-ui/src/views/CredentialsView.vue | 7 +++--- .../src/views/ForgotMyPasswordView.vue | 2 +- packages/editor-ui/src/views/NodeView.vue | 24 +++++++++---------- .../editor-ui/src/views/SamlOnboarding.vue | 2 +- .../editor-ui/src/views/SettingsApiView.vue | 2 +- .../src/views/SettingsCommunityNodesView.vue | 2 +- .../src/views/SettingsFakeDoorView.vue | 2 +- .../editor-ui/src/views/SettingsLdapView.vue | 4 ++-- .../src/views/SettingsLogStreamingView.vue | 7 ++---- .../src/views/SettingsPersonalView.vue | 2 +- .../src/views/SettingsUsageAndPlan.vue | 3 ++- .../editor-ui/src/views/SettingsUsersView.vue | 2 +- packages/editor-ui/src/views/SettingsView.vue | 2 +- packages/editor-ui/src/views/SetupView.vue | 2 +- packages/editor-ui/src/views/SigninView.vue | 2 +- packages/editor-ui/src/views/SignupView.vue | 2 +- .../src/views/TemplatesCollectionView.vue | 2 +- .../src/views/TemplatesSearchView.vue | 4 ++-- .../src/views/TemplatesWorkflowView.vue | 2 +- .../editor-ui/src/views/VariablesView.vue | 6 ++++- .../editor-ui/src/views/WorkflowsView.vue | 4 ++-- .../src/views/__tests__/SettingsSso.test.ts | 2 +- packages/node-dev/.eslintrc.js | 1 - packages/nodes-base/.eslintrc.js | 2 -- packages/workflow/.eslintrc.js | 1 - 269 files changed, 624 insertions(+), 569 deletions(-) diff --git a/packages/@n8n_io/eslint-config/base.js b/packages/@n8n_io/eslint-config/base.js index 4242429369..ffb4f73540 100644 --- a/packages/@n8n_io/eslint-config/base.js +++ b/packages/@n8n_io/eslint-config/base.js @@ -194,6 +194,11 @@ const config = (module.exports = { */ '@typescript-eslint/consistent-type-assertions': 'error', + /** + * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/consistent-type-imports.md + */ + '@typescript-eslint/consistent-type-imports': 'error', + /** * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/member-delimiter-style.md */ diff --git a/packages/cli/.eslintrc.js b/packages/cli/.eslintrc.js index 3da2d993a3..2a24787f80 100644 --- a/packages/cli/.eslintrc.js +++ b/packages/cli/.eslintrc.js @@ -16,8 +16,6 @@ module.exports = { ], rules: { - '@typescript-eslint/consistent-type-imports': 'error', - // TODO: Remove this 'import/no-cycle': 'warn', 'import/order': 'off', diff --git a/packages/core/.eslintrc.js b/packages/core/.eslintrc.js index a1a1b8155d..4d68086144 100644 --- a/packages/core/.eslintrc.js +++ b/packages/core/.eslintrc.js @@ -11,8 +11,6 @@ module.exports = { ignorePatterns: ['bin/*.js'], rules: { - '@typescript-eslint/consistent-type-imports': 'error', - // TODO: Remove this 'import/order': 'off', '@typescript-eslint/ban-ts-comment': ['error', { 'ts-ignore': true }], diff --git a/packages/design-system/src/components/N8nActionDropdown/ActionDropdown.vue b/packages/design-system/src/components/N8nActionDropdown/ActionDropdown.vue index 08f0147a20..75a785a590 100644 --- a/packages/design-system/src/components/N8nActionDropdown/ActionDropdown.vue +++ b/packages/design-system/src/components/N8nActionDropdown/ActionDropdown.vue @@ -34,7 +34,8 @@