diff --git a/packages/frontend/editor-ui/src/components/WorkflowSelectorParameterInput/WorkflowSelectorParameterInput.vue b/packages/frontend/editor-ui/src/components/WorkflowSelectorParameterInput/WorkflowSelectorParameterInput.vue index a77744c190..7ba478d993 100644 --- a/packages/frontend/editor-ui/src/components/WorkflowSelectorParameterInput/WorkflowSelectorParameterInput.vue +++ b/packages/frontend/editor-ui/src/components/WorkflowSelectorParameterInput/WorkflowSelectorParameterInput.vue @@ -92,7 +92,7 @@ const { searchFilter, onSearchFilter, getWorkflowName, - renameDefaultNodeName, + applyDefaultExecuteWorkflowNodeName, populateNextWorkflowsPage, setWorkflowsResources, reloadWorkflows, @@ -178,7 +178,7 @@ function onListItemSelected(value: NodeParameterValue) { // we rename defaults here to allow selecting the same workflow to // update the name, as we don't eagerly update a changed workflow name // but rather only react on changed id elsewhere - renameDefaultNodeName(value); + applyDefaultExecuteWorkflowNodeName(value); } function onInputFocus(): void { @@ -252,7 +252,7 @@ watch( // changed name means the workflow becomes unsaved and changed just by // opening the ExecuteWorkflow node referencing the renamed workflow if (old.value !== val.value) { - renameDefaultNodeName(val.value); + applyDefaultExecuteWorkflowNodeName(val.value); } }, ); diff --git a/packages/frontend/editor-ui/src/components/WorkflowSelectorParameterInput/useWorkflowResourcesLocator.test.ts b/packages/frontend/editor-ui/src/components/WorkflowSelectorParameterInput/useWorkflowResourcesLocator.test.ts index f18971f1d8..e856c777cf 100644 --- a/packages/frontend/editor-ui/src/components/WorkflowSelectorParameterInput/useWorkflowResourcesLocator.test.ts +++ b/packages/frontend/editor-ui/src/components/WorkflowSelectorParameterInput/useWorkflowResourcesLocator.test.ts @@ -30,7 +30,7 @@ describe('useWorkflowResourcesLocator', () => { useCanvasOperations.mockReturnValue({ renameNode: renameNodeMock }); }); - describe('renameDefaultNodeName', () => { + describe('applyDefaultExecuteWorkflowNodeName', () => { it.each([ { activeNodeName: 'Execute Workflow', @@ -56,14 +56,14 @@ describe('useWorkflowResourcesLocator', () => { ])( 'should rename the node correctly for activeNodeName: $activeNodeName', ({ activeNodeName, workflowId, mockedWorkflow, expectedRename, expectedCalledWith }) => { - const { renameDefaultNodeName } = useWorkflowResourcesLocator(routerMock); + const { applyDefaultExecuteWorkflowNodeName } = useWorkflowResourcesLocator(routerMock); ndvStoreMock.activeNodeName = activeNodeName; workflowsStoreMock.getWorkflowById.mockReturnValue( mockedWorkflow as unknown as IWorkflowDb, ); - renameDefaultNodeName(workflowId); + applyDefaultExecuteWorkflowNodeName(workflowId); expect(workflowsStoreMock.getWorkflowById).toHaveBeenCalledWith(workflowId); expect(renameNodeMock).toHaveBeenCalledWith(expectedCalledWith, expectedRename); @@ -71,30 +71,30 @@ describe('useWorkflowResourcesLocator', () => { ); it('should not rename the node for invalid workflowId', () => { - const { renameDefaultNodeName } = useWorkflowResourcesLocator(routerMock); + const { applyDefaultExecuteWorkflowNodeName } = useWorkflowResourcesLocator(routerMock); const workflowId = 123; - renameDefaultNodeName(workflowId); + applyDefaultExecuteWorkflowNodeName(workflowId); expect(renameNodeMock).not.toHaveBeenCalled(); }); it('should not rename the node for workflowId: workflow-id with null mockedWorkflow', () => { - const { renameDefaultNodeName } = useWorkflowResourcesLocator(routerMock); + const { applyDefaultExecuteWorkflowNodeName } = useWorkflowResourcesLocator(routerMock); const workflowId = 'workflow-id'; const activeNodeName = 'Execute Workflow'; ndvStoreMock.activeNodeName = activeNodeName; workflowsStoreMock.getWorkflowById.mockReturnValue(null as unknown as IWorkflowDb); - renameDefaultNodeName(workflowId); + applyDefaultExecuteWorkflowNodeName(workflowId); expect(workflowsStoreMock.getWorkflowById).toHaveBeenCalledWith(workflowId); expect(renameNodeMock).not.toHaveBeenCalled(); }); it('should not rename the node for workflowId: workflow-id with activeNodeName: Some Other Node', () => { - const { renameDefaultNodeName } = useWorkflowResourcesLocator(routerMock); + const { applyDefaultExecuteWorkflowNodeName } = useWorkflowResourcesLocator(routerMock); const workflowId = 'workflow-id'; const activeNodeName = 'Some Other Node'; const mockedWorkflow = { name: 'Test Workflow' }; @@ -102,7 +102,7 @@ describe('useWorkflowResourcesLocator', () => { ndvStoreMock.activeNodeName = activeNodeName; workflowsStoreMock.getWorkflowById.mockReturnValue(mockedWorkflow as unknown as IWorkflowDb); - renameDefaultNodeName(workflowId); + applyDefaultExecuteWorkflowNodeName(workflowId); expect(workflowsStoreMock.getWorkflowById).not.toHaveBeenCalled(); expect(renameNodeMock).not.toHaveBeenCalled(); diff --git a/packages/frontend/editor-ui/src/components/WorkflowSelectorParameterInput/useWorkflowResourcesLocator.ts b/packages/frontend/editor-ui/src/components/WorkflowSelectorParameterInput/useWorkflowResourcesLocator.ts index 6335161315..340dfeb8f2 100644 --- a/packages/frontend/editor-ui/src/components/WorkflowSelectorParameterInput/useWorkflowResourcesLocator.ts +++ b/packages/frontend/editor-ui/src/components/WorkflowSelectorParameterInput/useWorkflowResourcesLocator.ts @@ -95,7 +95,7 @@ export function useWorkflowResourcesLocator(router: Router) { searchFilter.value = filter; } - function renameDefaultNodeName(workflowId: NodeParameterValue) { + function applyDefaultExecuteWorkflowNodeName(workflowId: NodeParameterValue) { if (typeof workflowId !== 'string') return; const nodeName = ndvStore.activeNodeName; @@ -121,7 +121,7 @@ export function useWorkflowResourcesLocator(router: Router) { getWorkflowUrl, onSearchFilter, getWorkflowName, - renameDefaultNodeName, + applyDefaultExecuteWorkflowNodeName, populateNextWorkflowsPage, setWorkflowsResources, };