refactor: Apply more eslint-plugin-n8n-nodes-base rules (#3624)

* ⬆️ Upgrade `eslint-plugin-n8n-nodes-base`

* 📦 Update `package-lock.json`

* 🔧 Adjust renamed filesystem rules

* ✏️ Alphabetize ruleset

* ⚡ Categorize overrides

* ⚡ Set renamings in lint exceptions

* ⚡ Run baseline `lintfix`

* ⚡ Update linting scripts

* 👕 Apply `node-param-description-missing-from-dynamic-multi-options`

* 👕 Apply `cred-class-field-name-missing-oauth2` (#3627)

* Rule working as intended

* Removed comments

* Move cred rule to different rule set

* 👕 Apply `node-param-array-type-assertion`

* 👕 Apply `node-dirname-against-convention`

* Apply `cred-class-field-display-name-oauth2` (#3628)

* Apply `node-execute-block-wrong-error-thrown`

* Apply `node-class-description-display-name-unsuffixed-trigger-node`

* Apply `node-class-description-name-unsuffixed-trigger-node`

* Apply `cred-class-name-missing-oauth2-suffix` (#3636)

* Rule working as intended, add exception to existing nodes

* 👕 Apply `cred-class-field-name-uppercase-first-char` (#3638)

* ⬆️ Upgrade to plugin version 1.2.28

* 📦 Update `package-lock.json`

* 👕 Update lintings with 1.2.8 change

* 👕 Apply `cred-class-field-name-unsuffixed`

* 👕 Apply `cred-class-name-unsuffixed`

* 👕 Apply `node-class-description-credentials-name-unsuffixed`

* ✏️ Alphabetize rules

* ➖ Remove `nodelinter` package

* 📦 Update `package-lock.json`

* ⚡ Consolidate `lint` and `lintfix` scripts

Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: agobrech <ael.gobrecht@gmail.com>

packages/nodes-base/nodes/Notion/BlockDescription.ts

@@ -6,7 +6,7 @@ import {
 	blocks,
 } from './Blocks';
 
-export const blockOperations = [
+export const blockOperations: INodeProperties[] = [
 	{
 		displayName: 'Operation',
 		name: 'operation',
@@ -34,7 +34,7 @@ export const blockOperations = [
 		],
 		default: 'append',
 	},
-] as INodeProperties[];
+];
 
 export const blockFields = [
 

packages/nodes-base/nodes/Notion/DatabaseDescription.ts

@@ -2,7 +2,7 @@ import {
 	INodeProperties,
 } from 'n8n-workflow';
 
-export const databaseOperations = [
+export const databaseOperations: INodeProperties[] = [
 	{
 		displayName: 'Operation',
 		name: 'operation',
@@ -66,9 +66,9 @@ export const databaseOperations = [
 		],
 		default: 'get',
 	},
-] as INodeProperties[];
+];
 
-export const databaseFields = [
+export const databaseFields: INodeProperties[] = [
 
 	/* -------------------------------------------------------------------------- */
 	/*                                database:get                                */
@@ -301,4 +301,4 @@ export const databaseFields = [
 			},
 		],
 	},
-] as INodeProperties[];
+];

packages/nodes-base/nodes/Notion/DatabasePageDescription.ts

@@ -16,7 +16,7 @@ import {
 	filters,
 } from './Filters';
 
-export const databasePageOperations = [
+export const databasePageOperations: INodeProperties[] = [
 	{
 		displayName: 'Operation',
 		name: 'operation',
@@ -90,7 +90,7 @@ export const databasePageOperations = [
 		],
 		default: 'create',
 	},
-] as INodeProperties[];
+];
 
 export const databasePageFields = [
 
@@ -682,6 +682,7 @@ export const databasePageFields = [
 						displayName: 'Option Names or IDs',
 						name: 'multiSelectValue',
 						type: 'multiOptions',
+						description: 'Choose from the list, or specify IDs using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>',
 						typeOptions: {
 							loadOptionsMethod: 'getDatabaseOptionsFromPage',
 						},

packages/nodes-base/nodes/Notion/NotionTrigger.node.ts

@@ -20,6 +20,7 @@ import moment from 'moment';
 
 export class NotionTrigger implements INodeType {
 	description: INodeTypeDescription = {
+		// eslint-disable-next-line n8n-nodes-base/node-class-description-display-name-unsuffixed-trigger-node
 		displayName: 'Notion Trigger (Beta)',
 		name: 'notionTrigger',
 		icon: 'file:notion.svg',

packages/nodes-base/nodes/Notion/PageDescription.ts

@@ -6,7 +6,7 @@ import {
 	blocks,
 } from './Blocks';
 
-export const pageOperations = [
+export const pageOperations: INodeProperties[] = [
 	{
 		displayName: 'Operation',
 		name: 'operation',
@@ -75,7 +75,7 @@ export const pageOperations = [
 		],
 		default: 'create',
 	},
-] as INodeProperties[];
+];
 
 export const pageFields = [
 

packages/nodes-base/nodes/Notion/UserDescription.ts

@@ -2,7 +2,7 @@ import {
 	INodeProperties,
 } from 'n8n-workflow';
 
-export const userOperations = [
+export const userOperations: INodeProperties[] = [
 	{
 		displayName: 'Operation',
 		name: 'operation',
@@ -29,9 +29,9 @@ export const userOperations = [
 		],
 		default: 'get',
 	},
-] as INodeProperties[];
+];
 
-export const userFields = [
+export const userFields: INodeProperties[] = [
 
 	/* -------------------------------------------------------------------------- */
 	/*                                user:get                                    */
@@ -97,4 +97,4 @@ export const userFields = [
 		default: 50,
 		description: 'Max number of results to return',
 	},
-] as INodeProperties[];
+];

packages/nodes-base/nodes/Notion/v1/VersionDescription.ts

@@ -1,4 +1,4 @@
-/* eslint-disable n8n-nodes-base/filesystem-wrong-node-filename */
+/* eslint-disable n8n-nodes-base/node-filename-against-convention */
 import {
 	databaseFields,
 	databaseOperations,

packages/nodes-base/nodes/Notion/v2/VersionDescription.ts

@@ -1,4 +1,4 @@
-/* eslint-disable n8n-nodes-base/filesystem-wrong-node-filename */
+/* eslint-disable n8n-nodes-base/node-filename-against-convention */
 import {
 	databaseFields,
 	databaseOperations,