From 5a608cbf5b6d71024da79e4ba215158fc8aa3d6d Mon Sep 17 00:00:00 2001 From: Jan Oberhauser Date: Sat, 29 Feb 2020 17:40:04 +0100 Subject: [PATCH] :zap: Small improvements on Drift-Node --- .../nodes/Drift/ContactDescription.ts | 12 ++++++------ packages/nodes-base/nodes/Drift/Drift.node.ts | 6 +++--- .../nodes-base/nodes/Drift/GenericFunctions.ts | 2 +- packages/nodes-base/nodes/Drift/drift.png | Bin 3189 -> 882 bytes packages/nodes-base/package.json | 6 +++--- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/packages/nodes-base/nodes/Drift/ContactDescription.ts b/packages/nodes-base/nodes/Drift/ContactDescription.ts index ad5bc14d5a..146adefa7d 100644 --- a/packages/nodes-base/nodes/Drift/ContactDescription.ts +++ b/packages/nodes-base/nodes/Drift/ContactDescription.ts @@ -65,7 +65,7 @@ export const contactFields = [ ], }, }, - description: 'The email of the Contact', + description: 'The email of the contact.', }, { displayName: 'Additional Fields', @@ -89,14 +89,14 @@ export const contactFields = [ name: 'name', type: 'string', default: '', - description: 'The name of the Contact', + description: 'The name of the contact.', }, { displayName: 'Phone', name: 'phone', type: 'string', default: '', - description: 'The phone number associated with the Contact', + description: 'The phone number associated with the contact.', }, ], }, @@ -143,21 +143,21 @@ export const contactFields = [ name: 'email', type: 'string', default: '', - description: 'The email of the Contact', + description: 'The email of the contact.', }, { displayName: 'Name', name: 'name', type: 'string', default: '', - description: 'The name of the Contact', + description: 'The name of the contact.', }, { displayName: 'Phone', name: 'phone', type: 'string', default: '', - description: 'The phone number associated with the Contact', + description: 'The phone number associated with the contact.', }, ] }, diff --git a/packages/nodes-base/nodes/Drift/Drift.node.ts b/packages/nodes-base/nodes/Drift/Drift.node.ts index 95566dfb60..53a9a2695e 100644 --- a/packages/nodes-base/nodes/Drift/Drift.node.ts +++ b/packages/nodes-base/nodes/Drift/Drift.node.ts @@ -82,7 +82,7 @@ export class Drift implements INodeType { body.phone = additionalFields.phone as string; } responseData = await driftApiRequest.call(this, 'POST', '/contacts', { attributes: body }); - responseData = responseData.data + responseData = responseData.data; } //https://devdocs.drift.com/docs/updating-a-contact if (operation === 'update') { @@ -99,13 +99,13 @@ export class Drift implements INodeType { body.email = updateFields.email as string; } responseData = await driftApiRequest.call(this, 'PATCH', `/contacts/${contactId}`, { attributes: body }); - responseData = responseData.data + responseData = responseData.data; } //https://devdocs.drift.com/docs/retrieving-contact if (operation === 'get') { const contactId = this.getNodeParameter('contactId', i) as string; responseData = await driftApiRequest.call(this, 'GET', `/contacts/${contactId}`); - responseData = responseData.data + responseData = responseData.data; } //https://devdocs.drift.com/docs/listing-custom-attributes if (operation === 'getCustomAttributes') { diff --git a/packages/nodes-base/nodes/Drift/GenericFunctions.ts b/packages/nodes-base/nodes/Drift/GenericFunctions.ts index 3f798398c4..47b38a86e3 100644 --- a/packages/nodes-base/nodes/Drift/GenericFunctions.ts +++ b/packages/nodes-base/nodes/Drift/GenericFunctions.ts @@ -42,7 +42,7 @@ export async function driftApiRequest(this: IExecuteFunctions | IWebhookFunction return await this.helpers.request!(options); } catch (error) { if (error.response) { - const errorMessage = error.message || (error.response.body && error.response.body.message ) + const errorMessage = error.message || (error.response.body && error.response.body.message ); throw new Error(`Drift error response [${error.statusCode}]: ${errorMessage}`); } throw error; diff --git a/packages/nodes-base/nodes/Drift/drift.png b/packages/nodes-base/nodes/Drift/drift.png index 82050d2ca84ac63fe0cbed72b2d68617e6b6c92b..98d008983c0e31b5872efac85f26ac79f34c5e7a 100644 GIT binary patch literal 882 zcmeAS@N?(olHy`uVBq!ia0vp^HXzKw3=&b&bO2IY0(?STfwa85yc!rNDJcPIb#-+h zsj8|9WIzB!7RZJOLbz~21qB756p*W|tPEkmrGN~e79apJR8&;pYzPA=0x=WF1zHW! z3lxNC2bu*T+wNW8}3tC*%LM@BOcv*B?H& zow?w-eY#<3kgxam*OtG%KNoQ6ij>^-lzwIGZ546scj)&z-YEjtR=vBev2=3Xd%q2n zmM~_`TA>hf+dklA@q&W$5lWW~Up?l1mc8|M-63hV>>Il`T=3c!{M1N%z0P@_2NzEV z_kZZxx?;k2bI~n4dKPj|wzPTlJjpBg>v=_NX8WJb6UzcWluS6)uOYEbV@Il5n6y>d ztdKgrydKfN)s9!>yYn|%yswSCQCxTN(pS+ZGNzNyAF8$+>lDm{r5e&Q|HqhrZc>oXU0Zf*u5qBLm-GF^6*-)`iT(+%Gwczixcqp^&eezPD z$BTc9yxml+ckMD`(pDRnBv;NaU02ySy{isz%zxszvC3i5`nrxSpWd;koR9GQruDoj zC0UxeNB@)imZwugCl?xc7YSeNU=OSDToXPmTxjOke-k=4<)kV+TstqPp=WWdcV6=p z*|)D&`&g%XP?-j2kNV* z-Q?D~nYKWoBjjBHpBK~OTW<@)kDgmo5YPN$-c0r2ucB9)e!dg`dZl64hOZv(hy0>q s*7|;UxZL-!gzuc2g75D946kE8zyA625TUL&z(mO4>FVdQ&MBb@013or!2kdN literal 3189 zcmY*c2{;s58#Wj+S#sU%YK*NPV;Z}`AS$k`Mao#RCdM#EhD=DZR465+$P!}gMqSFj z#te~t5QE4vgoXzH=-&VS|9_t6ob#RUyx;qt?>y&u&N=bcmgo6E;vhCQHa;^`6I)iV zcUX^bv04Ok6wB%WLAK}5u$7V}7g+qCAa5G?!94TFGxL2$nM5C;ouurUVf z3D!_iS2+zqg1}&~9@fJPVQX^k?{L;gA95Xs3qZhNAt50uA!;fZtTzm0&qSUfAAsiH8)H!P9Fj}6#A$9wN9Lm*MF7# zgZ@s7l_2bJ1_oC-4f}_i6{>gWMOa~dJXy+z{7AUoFXaFE{?^fh9g6?YV*bkXmzR|) z5~K(FXWNjV3(X2w*w{cdW+q0Lt^+@(QNLvci*-0{Ux>Mb;DRg20P}xSaO3{us#{oi zDmTuJ)27cTx!5wHG0KEnYP0&Q!1dJQY6CgtHB&~*c_?D^@%9I(E^#-3CtevtKezTK z%d&>oS_o59=S7_89}I>Uc2P-L1wZ$1*E&@r-h);42VRAZKO%26y`28j)w^8(tsXv< zO&4vpqi*0GRQm)|CIBLgu4v=_K)+H1^Othb zr6@O)um5SVm)kU81Wnv;xKr?FMMQyT%wW{{dnXWIw|5$~;EInp-szR$0_%tEsLzl} z*8tTAyr#_bbI!qD>mxH9E_TlxTAy^rWWE#$3tSJgW5`5xl`Cd;*d+{J9-k4K3Z9F% z;J59y82w|#JYg$}o&=QjQVo7i;wdY(dVnaR8LHU!+Kk$+d_*Xb$X^=S-#TbVY{M>@ z_k>A5P8lCV$y`mu1^D!=37kqu_oocSD3aQxxkH5CJ(BSt4@|OK@s-8(asZm@1AV6t znr}*a{n*Pn6CH+-RRgy?uBY zN-E`St33W~$7L&RFsEx&4Gk6CN=bMSW<=buloRx~zl@V%R(x8xxS^X*X&o9)y7|4j z6>=HZAZ}VC@0pTXCTyU{f43t!-9-}+J-d(uK;~z~8hxk|ns~fj@Pc}uzL}WSTSHY9rq-kzFY+k)2iqIG7p~wXO}?_)eO?z&FT# zWxV=XfztiRGSST85Ne5Q&yt#v{<9zX5f)&@)R(jZE>BCh4jy-Yjm(A(;&5C^a zPEiV6@PvT%8 zNYEVFH-*39ZU}a3@OScX5pb3=752(XouPjEaks#=$SMoHYOl~w;fy$XgWtWlH!Xyx z#%Kt!DA_CIO@5F#K1963G%43gb{6-#Kd@;=DjktqG>~+Sa0h>8f7(BDaZK!97dl9M z$?<3n`W1CiN1`Ts>Bu|&+fw_+Z5&FM?qlO1OPuxpB22#D-3wwQan%$e4VDw%v?Q!Y zHCfKu`-f!i6Jy2-15+4EK)Es;pPxqcL50P~MWq6a`QyCJKTn4M$5IR}HoO-bG?L}L zdo71&k|a=J1kt^Ik`BVlf?Fexdc?Z$;^3}Sp z7tp>Gp<4gUX2cA;P1X5|y+3SsmdiAi2R<4$$q1?PUw0fhFpi|gN1{68Cz8{PKlp5! zKO79}f6l?B*Fvn^sLe&iO?z`}hNA0blAZhES(YEQtNf;y8a7thC;P4S<^87I0lN{P zNuf&+t@h3uSfWOK47y4oGHo$+DQ0#j@D^2S&X+wQ%z{px{t4)UKR*_8Mq{VQ<6DZy z=g>D2Iq#Jj*hZT%5lPTZ;1oYNDDaN&hl>vv2gdxfe?E+iuB2oIg#)S)+&zUkta&E_pAHPeMxZPEQQMl3~ z_FxYcbZ`7_{SGn_dw!)GBA=eoC$|_O-FLFe&(%|Y5!83!7D+U*`CPVPNGfN-B~YRu zPuRHhPaFCeoA@8e6*tXq%c&BY%}cJo0MC)y!SWSbMwXT@D@noOmH8B0dlf0#vac$D zJoywb=#09!7-Th-Zn{6#)Q@;wLfVy2U3eiW+?CFxoGxDAIMSrosu*zXnCQM8fClQU ztyR>5wJt!q*zuikJhqv%)gf9DXXb|$9Tyavl=an3`W~xW(QH8!)ac z>TC9WJ`y8xQ)dPGqnhO6O1`jBK~YZTT&Xua7-O56ct^m1$^_&$_l)uz@;DSXRB zD%ZJGhn&pNe7*XbGX5#M2R-VoE-RtPm}kJP9T~|m+LGISf$N3SaD(8U4E~v(_XHQb z|GE9w*XD09{bD;cVkS1DaK(ATfo=@?q+0h4jJbSgus56ZvBT`Oz*>xnixc`0)SN-T zS4%>3s&`h+5nV$2314eO&CHWKRpN<-61zVqM3YhhpC>pY(AY3_UqV*gP8_h%DD zfJ*rr;X`K>WI~y;Z`BNur0!J^nVKJ!H(|e{N<{jt8!0zr71wWBtqvMO2M5hx<`=8( zIy7Dg%WtW56@H{Iy3D6YO(qKgW>J#F6>AqKzjYfQ45GDpXoPUPCtbV{SV{6JyQS)0 z%7~(CyVn^|*9l}_SFi6&Y+)hU`)ThHBs-Cl$B^qp%ZEih!nd%mt@w^<@U3#y9!-el z;7#AE0M{GqJ2J`dmGH8SBw<(Es;g*v6fE4$nAeSOG$mK}?nM68lu9Uc&E!biPY(8S zi}nOBdup>hO?Jd34~<@5>E7Cr)~Z$2am=eRQMa57K>a4b$(e4ajwm6|I*mUYfmDVP zKD%{&HXjs+WF#@i=MoAX)g8V39HF*-2wYbi`a-jt{q~)dknA*Xd5LLF{v!l?lb#@+~)Iv_+?@Y+WW0$nG-t zd!~&v-*Tx%)X8NYMpo#r7a_e&lFWM7?M(XxAhg9YL1f_5&g11usjm;%gDLXo*z0G` Q9R3B&&RUw3o^ieNZ#uR4zW@LL diff --git a/packages/nodes-base/package.json b/packages/nodes-base/package.json index a99c9db2e3..6372676139 100644 --- a/packages/nodes-base/package.json +++ b/packages/nodes-base/package.json @@ -41,8 +41,8 @@ "dist/credentials/CodaApi.credentials.js", "dist/credentials/CopperApi.credentials.js", "dist/credentials/DisqusApi.credentials.js", - "dist/credentials/DropboxApi.credentials.js", "dist/credentials/DriftApi.credentials.js", + "dist/credentials/DropboxApi.credentials.js", "dist/credentials/EventbriteApi.credentials.js", "dist/credentials/FreshdeskApi.credentials.js", "dist/credentials/FileMaker.credentials.js", @@ -126,11 +126,11 @@ "dist/nodes/Copper/CopperTrigger.node.js", "dist/nodes/Cron.node.js", "dist/nodes/Crypto.node.js", + "dist/nodes/DateTime.node.js", "dist/nodes/Discord/Discord.node.js", "dist/nodes/Disqus/Disqus.node.js", - "dist/nodes/Dropbox/Dropbox.node.js", - "dist/nodes/DateTime.node.js", "dist/nodes/Drift/Drift.node.js", + "dist/nodes/Dropbox/Dropbox.node.js", "dist/nodes/EditImage.node.js", "dist/nodes/EmailReadImap.node.js", "dist/nodes/EmailSend.node.js",