refactor: rename NodeVersionedType to VersionedNodeType and move it to the workflow package (#4443)

This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™
2022-10-25 21:33:12 +02:00
committed by GitHub
parent adef6d7083
commit 5c9b40117a
19 changed files with 59 additions and 78 deletions

View File

@@ -9,7 +9,6 @@
import { Credentials, NodeExecuteFunctions } from 'n8n-core';
// eslint-disable-next-line import/no-extraneous-dependencies
import { get } from 'lodash';
import { NodeVersionedType } from 'n8n-nodes-base';
import {
ICredentialDataDecryptedObject,
@@ -28,7 +27,8 @@ import {
INodeType,
INodeTypeData,
INodeTypes,
INodeVersionedType,
IVersionedNodeType,
VersionedNodeType,
IRequestOptionsSimplified,
IRunExecutionData,
IWorkflowDataProxyAdditionalKeys,
@@ -60,7 +60,7 @@ const mockNodeTypes: INodeTypes = {
nodeTypes: {} as INodeTypeData,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
init: async (nodeTypes?: INodeTypeData): Promise<void> => {},
getAll(): Array<INodeType | INodeVersionedType> {
getAll(): Array<INodeType | IVersionedNodeType> {
// @ts-ignore
return Object.values(this.nodeTypes).map((data) => data.type);
},
@@ -484,9 +484,9 @@ export class CredentialsHelper extends ICredentialsHelper {
// Always set to an array even if node is not versioned to not having
// to duplicate the logic
const allNodeTypes: INodeType[] = [];
if (node instanceof NodeVersionedType) {
if (node instanceof VersionedNodeType) {
// Node is versioned
allNodeTypes.push(...Object.values((node as INodeVersionedType).nodeVersions));
allNodeTypes.push(...Object.values((node as IVersionedNodeType).nodeVersions));
} else {
// Node is not versioned
allNodeTypes.push(node as INodeType);
@@ -501,11 +501,11 @@ export class CredentialsHelper extends ICredentialsHelper {
if (Object.prototype.hasOwnProperty.call(node, 'nodeVersions')) {
// The node is versioned. So check all versions for test function
// starting with the latest
const versions = Object.keys((node as INodeVersionedType).nodeVersions)
const versions = Object.keys((node as IVersionedNodeType).nodeVersions)
.sort()
.reverse();
for (const version of versions) {
const versionedNode = (node as INodeVersionedType).nodeVersions[
const versionedNode = (node as IVersionedNodeType).nodeVersions[
parseInt(version, 10)
];
if (