admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Google Sheets Node): Check for null before destructuring (#7729)

Browse Source 
https://n8nio.sentry.io/issues/4613453684
This commit is contained in:
Iván Ovejero
2023-11-16 16:50:06 +01:00
committed by GitHub
parent d39bb2540f
commit 5d4a52d3b7
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/nodes-base/nodes/Google/Sheet/v2/methods/loadOptions.ts
View File

@@ -5,7 +5,12 @@ import { getSpreadsheetId } from '../helpers/GoogleSheets.utils';
import type { ResourceLocator } from '../helpers/GoogleSheets.types'; import type { ResourceLocator } from '../helpers/GoogleSheets.types';
export async function getSheets(this: ILoadOptionsFunctions): Promise<INodePropertyOptions[]> { export async function getSheets(this: ILoadOptionsFunctions): Promise<INodePropertyOptions[]> {
const { mode, value } = this.getNodeParameter('documentId', 0) as IDataObject; const documentId = this.getNodeParameter('documentId', 0) as IDataObject | null;
if (!documentId) return [];
const { mode, value } = documentId;
const spreadsheetId = getSpreadsheetId(this.getNode(), mode as ResourceLocator, value as string); const spreadsheetId = getSpreadsheetId(this.getNode(), mode as ResourceLocator, value as string);
const sheet = new GoogleSheet(spreadsheetId, this); const sheet = new GoogleSheet(spreadsheetId, this);
@@ -33,7 +38,12 @@ export async function getSheets(this: ILoadOptionsFunctions): Promise<INodePrope
export async function getSheetHeaderRow( export async function getSheetHeaderRow(
this: ILoadOptionsFunctions, this: ILoadOptionsFunctions,
): Promise<INodePropertyOptions[]> { ): Promise<INodePropertyOptions[]> {
const { mode, value } = this.getNodeParameter('documentId', 0) as IDataObject; const documentId = this.getNodeParameter('documentId', 0) as IDataObject | null;
if (!documentId) return [];
const { mode, value } = documentId;
const spreadsheetId = getSpreadsheetId(this.getNode(), mode as ResourceLocator, value as string); const spreadsheetId = getSpreadsheetId(this.getNode(), mode as ResourceLocator, value as string);
const sheet = new GoogleSheet(spreadsheetId, this); const sheet = new GoogleSheet(spreadsheetId, this);