admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-19 02:51:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Extract more code out in WorkflowExecute and add unit tests (#13327)

Browse Source
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™
2025-02-19 13:42:37 +01:00
committed by GitHub
parent 14b6f8b972
commit 60ff82f648
2 changed files with 161 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

106
packages/core/src/execution-engine/workflow-execute.ts
View File

@@ -37,7 +37,6 @@ import type {
CloseFunction,
StartNodeData,
NodeExecutionHint,
NodeInputConnections,
IRunNodeResponse,
IWorkflowIssues,
INodeIssues,
@@ -1375,59 +1374,10 @@ export class WorkflowExecute {
continue;
}
// Check if all the data which is needed to run the node is available
if (workflow.connectionsByDestinationNode.hasOwnProperty(executionNode.name)) {
// Check if the node has incoming connections
if (workflow.connectionsByDestinationNode[executionNode.name].hasOwnProperty('main')) {
let inputConnections: NodeInputConnections;
let connectionIndex: number;
// eslint-disable-next-line prefer-const
inputConnections = workflow.connectionsByDestinationNode[executionNode.name].main;
for (
connectionIndex = 0;
connectionIndex < inputConnections.length;
connectionIndex++
) {
if (
workflow.getHighestNode(
executionNode.name,
NodeConnectionType.Main,
connectionIndex,
).length === 0
) {
// If there is no valid incoming node (if all are disabled)
// then ignore that it has inputs and simply execute it as it is without
// any data
continue;
}
if (!executionData.data.hasOwnProperty('main')) {
// ExecutionData does not even have the connection set up so can
// not have that data, so add it again to be executed later
this.runExecutionData.executionData!.nodeExecutionStack.push(executionData);
lastExecutionTry = currentExecutionTry;
continue executionLoop;
}
if (forceInputNodeExecution) {
// Check if it has the data for all the inputs
// The most nodes just have one but merge node for example has two and data
// of both inputs has to be available to be able to process the node.
if (
executionData.data.main.length < connectionIndex ||
executionData.data.main[connectionIndex] === null
) {
// Does not have the data of the connections so add back to stack
this.runExecutionData.executionData!.nodeExecutionStack.push(executionData);
lastExecutionTry = currentExecutionTry;
continue executionLoop;
}
}
}
}
const hasInputData = this.ensureInputData(workflow, executionNode, executionData);
if (!hasInputData) {
lastExecutionTry = currentExecutionTry;
continue executionLoop;
}
startTime = new Date().getTime();
@@ -2039,6 +1989,54 @@ export class WorkflowExecute {
});
}
/**
* This method determines if a specific node has incoming connections and verifies if execution data is available for all required inputs.
* If any required input data is missing, the node execution is deferred by pushing it back onto the execution stack.
*
* @param workflow - The workflow containing the node and connections.
* @param executionNode - The node being checked.
* @param executionData - The data available for executing the node.
* @returns `true` if the node has the required input data and can execute immediately, otherwise `false`.
*/
ensureInputData(workflow: Workflow, executionNode: INode, executionData: IExecuteData): boolean {
const inputConnections = workflow.connectionsByDestinationNode[executionNode.name]?.main ?? [];
for (let connectionIndex = 0; connectionIndex < inputConnections.length; connectionIndex++) {
const highestNodes = workflow.getHighestNode(
executionNode.name,
NodeConnectionType.Main,
connectionIndex,
);
if (highestNodes.length === 0) {
// If there is no valid incoming node (if all are disabled)
// then ignore that it has inputs and simply execute it as it is without
// any data
return true;
}
if (!executionData.data.hasOwnProperty('main')) {
// ExecutionData does not even have the connection set up so can
// not have that data, so add it again to be executed later
this.runExecutionData.executionData!.nodeExecutionStack.push(executionData);
return false;
}
if (this.forceInputNodeExecution(workflow)) {
// Check if it has the data for all the inputs
// The most nodes just have one but merge node for example has two and data
// of both inputs has to be available to be able to process the node.
if (
executionData.data.main.length < connectionIndex ||
executionData.data.main[connectionIndex] === null
) {
// Does not have the data of the connections so add back to stack
this.runExecutionData.executionData!.nodeExecutionStack.push(executionData);
return false;
}
}
}
return true;
}
/**
* Processes the final state of a workflow execution and prepares the execution result.
* This method handles different completion scenarios: success, waiting, error, and canceled states.