admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): Normalize trailing slash when setting CORS headers for test webhooks (#15906)

Browse Source
This commit is contained in:
Iván Ovejero
2025-06-02 14:13:18 +02:00
committed by GitHub
parent 7ae67f016d
commit 61d0c6a6e7
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
packages/cli/src/webhooks/__tests__/test-webhooks.test.ts
View File

@@ -56,7 +56,7 @@ describe('TestWebhooks', () => {
}); });
beforeEach(() => { beforeEach(() => {
jest.clearAllMocks(); jest.resetAllMocks();
}); });
describe('needsWebhook()', () => { describe('needsWebhook()', () => {
@@ -192,4 +192,19 @@ describe('TestWebhooks', () => {
expect(mockedAdditionalData.getBase).toHaveBeenCalledWith(userId); expect(mockedAdditionalData.getBase).toHaveBeenCalledWith(userId);
}); });
}); });
describe('getWebhookMethods()', () => {
test('should normalize trailing slash', async () => {
const METHOD = 'POST';
const PATH_WITH_SLASH = 'register/';
const PATH_WITHOUT_SLASH = 'register';
registrations.getAllKeys.mockResolvedValue([`${METHOD}|${PATH_WITHOUT_SLASH}`]);
const resultWithSlash = await testWebhooks.getWebhookMethods(PATH_WITH_SLASH);
const resultWithoutSlash = await testWebhooks.getWebhookMethods(PATH_WITHOUT_SLASH);
expect(resultWithSlash).toEqual([METHOD]);
expect(resultWithoutSlash).toEqual([METHOD]);
});
});
}); });

3
packages/cli/src/webhooks/test-webhooks.ts
View File

@@ -174,7 +174,8 @@ export class TestWebhooks implements IWebhookManager {
if (timeout) clearTimeout(timeout); if (timeout) clearTimeout(timeout);
} }
async getWebhookMethods(path: string) { async getWebhookMethods(rawPath: string) {
const path = removeTrailingSlash(rawPath);
const allKeys = await this.registrations.getAllKeys(); const allKeys = await this.registrations.getAllKeys();
const webhookMethods = allKeys const webhookMethods = allKeys