refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/credentials/MetabaseApi.credentials.ts

@@ -9,8 +9,11 @@ import {
 
 export class MetabaseApi implements ICredentialType {
 	name = 'metabaseApi';
+
 	displayName = 'Metabase API';
+
 	documentationUrl = 'metabase';
+
 	properties: INodeProperties[] = [
 		{
 			displayName: 'Session Token',
@@ -59,6 +62,7 @@ export class MetabaseApi implements ICredentialType {
 		})) as { id: string };
 		return { sessionToken: id };
 	}
+
 	authenticate: IAuthenticateGeneric = {
 		type: 'generic',
 		properties: {
@@ -67,6 +71,7 @@ export class MetabaseApi implements ICredentialType {
 			},
 		},
 	};
+
 	test: ICredentialTestRequest = {
 		request: {
 			baseURL: '={{$credentials?.url}}',