refactor(core): Remove linting exceptions in nodes-base (#4794)

*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions

View File

@@ -344,7 +344,7 @@ export class ActiveCampaign implements INodeType {
requestMethod = 'POST';
const updateIfExists = this.getNodeParameter('updateIfExists', i) as boolean;
if (updateIfExists === true) {
if (updateIfExists) {
endpoint = '/api/3/contact/sync';
} else {
endpoint = '/api/3/contacts';
@@ -387,7 +387,7 @@ export class ActiveCampaign implements INodeType {
const simple = this.getNodeParameter('simple', i, true) as boolean;
const additionalFields = this.getNodeParameter('additionalFields', i);
if (returnAll === false) {
if (!returnAll) {
qs.limit = this.getNodeParameter('limit', i);
}
@@ -398,7 +398,7 @@ export class ActiveCampaign implements INodeType {
delete qs.orderBy;
}
if (simple === true) {
if (simple) {
dataKey = 'contacts';
}
@@ -471,11 +471,11 @@ export class ActiveCampaign implements INodeType {
const simple = this.getNodeParameter('simple', i, true) as boolean;
returnAll = this.getNodeParameter('returnAll', i);
if (returnAll === false) {
if (!returnAll) {
qs.limit = this.getNodeParameter('limit', i);
}
if (simple === true) {
if (simple) {
dataKey = 'accounts';
}
@@ -640,11 +640,11 @@ export class ActiveCampaign implements INodeType {
returnAll = this.getNodeParameter('returnAll', i);
const simple = this.getNodeParameter('simple', i, true) as boolean;
if (returnAll === false) {
if (!returnAll) {
qs.limit = this.getNodeParameter('limit', i);
}
if (simple === true) {
if (simple) {
dataKey = 'lists';
}
@@ -696,11 +696,11 @@ export class ActiveCampaign implements INodeType {
const simple = this.getNodeParameter('simple', i, true) as boolean;
returnAll = this.getNodeParameter('returnAll', i);
if (returnAll === false) {
if (!returnAll) {
qs.limit = this.getNodeParameter('limit', i);
}
if (simple === true) {
if (simple) {
dataKey = 'tags';
}
@@ -803,11 +803,11 @@ export class ActiveCampaign implements INodeType {
const simple = this.getNodeParameter('simple', i, true) as boolean;
returnAll = this.getNodeParameter('returnAll', i);
if (returnAll === false) {
if (!returnAll) {
qs.limit = this.getNodeParameter('limit', i);
}
if (simple === true) {
if (simple) {
dataKey = 'deals';
}
@@ -902,11 +902,11 @@ export class ActiveCampaign implements INodeType {
const simple = this.getNodeParameter('simple', i, true) as boolean;
returnAll = this.getNodeParameter('returnAll', i);
if (returnAll === false) {
if (!returnAll) {
qs.limit = this.getNodeParameter('limit', i);
}
if (simple === true) {
if (simple) {
dataKey = 'connections';
}
@@ -932,7 +932,7 @@ export class ActiveCampaign implements INodeType {
source: this.getNodeParameter('source', i) as string,
email: this.getNodeParameter('email', i) as string,
totalPrice: this.getNodeParameter('totalPrice', i) as number,
currency: this.getNodeParameter('currency', i)!.toString().toUpperCase() as string,
currency: this.getNodeParameter('currency', i)!.toString().toUpperCase(),
externalCreatedDate: this.getNodeParameter('externalCreatedDate', i) as string,
connectionid: this.getNodeParameter('connectionid', i) as number,
customerid: this.getNodeParameter('customerid', i) as number,
@@ -1002,11 +1002,11 @@ export class ActiveCampaign implements INodeType {
const simple = this.getNodeParameter('simple', i, true) as boolean;
returnAll = this.getNodeParameter('returnAll', i);
if (returnAll === false) {
if (!returnAll) {
qs.limit = this.getNodeParameter('limit', i);
}
if (simple === true) {
if (simple) {
dataKey = 'ecomOrders';
}
@@ -1091,11 +1091,11 @@ export class ActiveCampaign implements INodeType {
const simple = this.getNodeParameter('simple', i, true) as boolean;
returnAll = this.getNodeParameter('returnAll', i);
if (returnAll === false) {
if (!returnAll) {
qs.limit = this.getNodeParameter('limit', i);
}
if (simple === true) {
if (simple) {
dataKey = 'ecomCustomers';
}
@@ -1137,11 +1137,11 @@ export class ActiveCampaign implements INodeType {
const simple = this.getNodeParameter('simple', i, true) as boolean;
returnAll = this.getNodeParameter('returnAll', i);
if (returnAll === false) {
if (!returnAll) {
qs.limit = this.getNodeParameter('limit', i);
}
if (simple === true) {
if (simple) {
dataKey = 'ecomOrderProducts';
}
@@ -1160,7 +1160,7 @@ export class ActiveCampaign implements INodeType {
}
let responseData;
if (returnAll === true) {
if (returnAll) {
responseData = await activeCampaignApiRequestAllItems.call(
this,
requestMethod,