refactor(core): Remove linting exceptions in nodes-base (#4794)

*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions

View File

@@ -229,7 +229,7 @@ export class AwsSns implements INodeType {
const topicName = arnParsed[5];
const awsRegion = arnParsed[3];
if (filter && topicName.includes(filter) === false) {
if (filter && !topicName.includes(filter)) {
continue;
}
@@ -287,7 +287,7 @@ export class AwsSns implements INodeType {
const topic = this.getNodeParameter('topic', i, undefined, {
extractValue: true,
}) as string;
const params = [('TopicArn=' + topic) as string];
const params = ['TopicArn=' + topic];
await awsApiRequestSOAP.call(
this,
@@ -304,9 +304,9 @@ export class AwsSns implements INodeType {
}) as string;
const params = [
('TopicArn=' + topic) as string,
('Subject=' + this.getNodeParameter('subject', i)) as string,
('Message=' + this.getNodeParameter('message', i)) as string,
'TopicArn=' + topic,
'Subject=' + this.getNodeParameter('subject', i),
'Message=' + this.getNodeParameter('message', i),
];
const responseData = await awsApiRequestSOAP.call(