refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/Aws/Transcribe/AwsTranscribe.node.ts

@@ -366,7 +366,7 @@ export class AwsTranscribe implements INodeType {
 						const mediaFileUri = this.getNodeParameter('mediaFileUri', i) as string;
 						const detectLang = this.getNodeParameter('detectLanguage', i) as boolean;
 
-						const options = this.getNodeParameter('options', i, {}) as IDataObject;
+						const options = this.getNodeParameter('options', i, {});
 
 						const body: IDataObject = {
 							TranscriptionJobName: transcriptionJobName,
@@ -472,14 +472,14 @@ export class AwsTranscribe implements INodeType {
 						);
 						responseData = responseData.TranscriptionJob;
 
-						if (resolve === true && responseData.TranscriptionJobStatus === 'COMPLETED') {
+						if (resolve && responseData.TranscriptionJobStatus === 'COMPLETED') {
 							responseData = await this.helpers.request({
 								method: 'GET',
 								uri: responseData.Transcript.TranscriptFileUri,
 								json: true,
 							});
 							const simple = this.getNodeParameter('simple', 0) as boolean;
-							if (simple === true) {
+							if (simple) {
 								responseData = {
 									transcript: responseData.results.transcripts
 										.map((data: IDataObject) => data.transcript)
@@ -496,14 +496,14 @@ export class AwsTranscribe implements INodeType {
 						const body: IDataObject = {};
 
 						if (filters.status) {
-							body['Status'] = filters.status;
+							body.Status = filters.status;
 						}
 
 						if (filters.jobNameContains) {
-							body['JobNameContains'] = filters.jobNameContains;
+							body.JobNameContains = filters.jobNameContains;
 						}
 
-						if (returnAll === true) {
+						if (returnAll) {
 							responseData = await awsApiRequestRESTAllItems.call(
 								this,
 								'TranscriptionJobSummaries',
@@ -515,7 +515,7 @@ export class AwsTranscribe implements INodeType {
 							);
 						} else {
 							const limit = this.getNodeParameter('limit', i);
-							body['MaxResults'] = limit;
+							body.MaxResults = limit;
 							responseData = await awsApiRequestREST.call(
 								this,
 								'transcribe',