refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/Discord/Discord.node.ts

@@ -127,11 +127,11 @@ export class Discord implements INodeType {
 		if (!webhookUri) throw new NodeOperationError(this.getNode(), 'Webhook uri is required.');
 
 		const items = this.getInputData();
-		const length = items.length as number;
+		const length = items.length;
 		for (let i = 0; i < length; i++) {
 			const body: DiscordWebhook = {};
 
-			const webhookUri = this.getNodeParameter('webhookUri', i) as string;
+			const iterationWebhookUri = this.getNodeParameter('webhookUri', i) as string;
 			body.content = this.getNodeParameter('text', i) as string;
 			const options = this.getNodeParameter('options', i);
 
@@ -215,7 +215,7 @@ export class Discord implements INodeType {
 					resolveWithFullResponse: true,
 					method: 'POST',
 					body,
-					uri: webhookUri,
+					uri: iterationWebhookUri,
 					headers: {
 						'content-type': 'application/json; charset=utf-8',
 					},
@@ -226,7 +226,7 @@ export class Discord implements INodeType {
 					resolveWithFullResponse: true,
 					method: 'POST',
 					body,
-					uri: webhookUri,
+					uri: iterationWebhookUri,
 					headers: {
 						'content-type': 'multipart/form-data; charset=utf-8',
 					},