refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/Emelia/Emelia.node.ts

@@ -110,8 +110,8 @@ export class Emelia implements INodeType {
 
 						if (additionalFields.customFieldsUi) {
 							const customFields =
-								(((additionalFields.customFieldsUi as IDataObject) || {})
-									.customFieldsValues as IDataObject[]) || [];
+								((additionalFields.customFieldsUi as IDataObject)
+									?.customFieldsValues as IDataObject[]) || [];
 							const data = customFields.reduce(
 								(obj, value) => Object.assign(obj, { [`${value.fieldName}`]: value.value }),
 								{},
@@ -366,8 +366,8 @@ export class Emelia implements INodeType {
 
 						if (additionalFields.customFieldsUi) {
 							const customFields =
-								(((additionalFields.customFieldsUi as IDataObject) || {})
-									.customFieldsValues as IDataObject[]) || [];
+								((additionalFields.customFieldsUi as IDataObject)
+									?.customFieldsValues as IDataObject[]) || [];
 							const data = customFields.reduce(
 								(obj, value) => Object.assign(obj, { [`${value.fieldName}`]: value.value }),
 								{},

packages/nodes-base/nodes/Emelia/GenericFunctions.ts

@@ -50,7 +50,7 @@ export async function emeliaApiRequest(
 	};
 
 	try {
-		return await this.helpers.request!.call(this, options);
+		return this.helpers.request!.call(this, options);
 	} catch (error) {
 		throw new NodeApiError(this.getNode(), error as JsonObject);
 	}