admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Remove linting exceptions in nodes-base (#4794)

Browse Source 
* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
packages/nodes-base/nodes/Freshdesk/Freshdesk.node.ts
View File

@@ -1213,17 +1213,17 @@ export class Freshdesk implements INodeType {
itemIndex: i,
});
}
body.requester_id = parseInt(value as string, 10);
body.requester_id = parseInt(value, 10);
} else if (updateFields.requester === 'email') {
body.email = value as string;
body.email = value;
} else if (updateFields.requester === 'facebookId') {
body.facebook_id = value as string;
body.facebook_id = value;
} else if (updateFields.requester === 'phone') {
body.phone = value as string;
body.phone = value;
} else if (updateFields.requester === 'twitterId') {
body.twitter_id = value as string;
body.twitter_id = value;
} else if (updateFields.requester === 'uniqueExternalId') {
body.unique_external_id = value as string;
body.unique_external_id = value;
}
}
if (updateFields.status) {
@@ -1310,7 +1310,7 @@ export class Freshdesk implements INodeType {
qs.include = (options.include as string[]).join(',');
}
}
if (returnAll === true) {
if (returnAll) {
responseData = await freshdeskApiRequestAllItems.call(
this,
'GET',
@@ -1333,11 +1333,7 @@ export class Freshdesk implements INodeType {
if (operation === 'create') {
const name = this.getNodeParameter('name', i) as string;
const email = this.getNodeParameter('email', i) as string;
const additionalFields = this.getNodeParameter(
'additionalFields',
i,
{},
) as IDataObject;
const additionalFields = this.getNodeParameter('additionalFields', i, {});
if (additionalFields.customFields) {
const metadata = (additionalFields.customFields as IDataObject)
@@ -1375,16 +1371,12 @@ export class Freshdesk implements INodeType {
);
//https://developers.freshdesk.com/api/#list_all_contacts
} else if (operation === 'getAll') {
const qs = this.getNodeParameter('filters', i, {}) as IDataObject;
responseData = await freshdeskApiRequest.call(this, 'GET', '/contacts', {}, qs);
const filters = this.getNodeParameter('filters', i, {});
responseData = await freshdeskApiRequest.call(this, 'GET', '/contacts', {}, filters);
//https://developers.freshdesk.com/api/#update_contact
} else if (operation === 'update') {
const contactId = this.getNodeParameter('contactId', i) as string;
const additionalFields = this.getNodeParameter(
'additionalFields',
i,
{},
) as IDataObject;
const additionalFields = this.getNodeParameter('additionalFields', i, {});
if (additionalFields.customFields) {
const metadata = (additionalFields.customFields as IDataObject)

7
packages/nodes-base/nodes/Freshdesk/GenericFunctions.ts
View File

@@ -63,13 +63,10 @@ export async function freshdeskApiRequestAllItems(
resolveWithFullResponse: true,
});
if (responseData.headers.link) {
uri = responseData.headers['link'].split(';')[0].replace('<', '').replace('>', '');
uri = responseData.headers.link.split(';')[0].replace('<', '').replace('>', '');
}
returnData.push.apply(returnData, responseData.body);
} while (
responseData.headers['link'] !== undefined &&
responseData.headers['link'].includes('rel="next"')
);
} while (responseData.headers.link?.includes('rel="next"'));
return returnData;
}