refactor(core): Remove linting exceptions in nodes-base (#4794)

*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions

View File

@@ -43,7 +43,7 @@ export async function githubApiRequest(
const credentials = await this.getCredentials('githubApi');
credentialType = 'githubApi';
const baseUrl = credentials!.server || 'https://api.github.com';
const baseUrl = credentials.server || 'https://api.github.com';
options.uri = `${baseUrl}${endpoint}`;
} else {
const credentials = await this.getCredentials('githubOAuth2Api');
@@ -105,6 +105,6 @@ export async function githubApiRequestAllItems(
});
query.page++;
returnData.push.apply(returnData, responseData.body);
} while (responseData.headers.link && responseData.headers.link.includes('next'));
} while (responseData.headers.link?.includes('next'));
return returnData;
}