refactor(core): Remove linting exceptions in nodes-base (#4794)

*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions

View File

@@ -58,16 +58,14 @@ export async function googleApiRequestAllItems(
do {
responseData = await googleApiRequest.call(this, method, endpoint, body, query, uri);
if (body.reportRequests && Array.isArray(body.reportRequests)) {
body.reportRequests[0]['pageToken'] = responseData[propertyName][0].nextPageToken;
body.reportRequests[0].pageToken = responseData[propertyName][0].nextPageToken;
} else {
body.pageToken = responseData['nextPageToken'];
body.pageToken = responseData.nextPageToken;
}
returnData.push.apply(returnData, responseData[propertyName]);
} while (
(responseData['nextPageToken'] !== undefined && responseData['nextPageToken'] !== '') ||
(responseData[propertyName] &&
responseData[propertyName][0].nextPageToken &&
responseData[propertyName][0].nextPageToken !== undefined)
(responseData.nextPageToken !== undefined && responseData.nextPageToken !== '') ||
responseData[propertyName]?.[0].nextPageToken !== undefined
);
return returnData;
@@ -88,10 +86,10 @@ export function simplify(responseData: any | [any]) {
if (dimensions) {
for (let i = 0; i < dimensions.length; i++) {
data[dimensions[i]] = row.dimensions[i];
data['total'] = row.metrics[0].values.join(',');
data.total = row.metrics[0].values.join(',');
}
} else {
data['total'] = row.metrics[0].values.join(',');
data.total = row.metrics[0].values.join(',');
}
response.push(data);
}