refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/Google/BigQuery/GenericFunctions.ts

@@ -82,14 +82,14 @@ export async function googleApiRequestAllItems(
 
 	do {
 		responseData = await googleApiRequest.call(this, method, endpoint, body, query);
-		query.pageToken = responseData['pageToken'];
+		query.pageToken = responseData.pageToken;
 		returnData.push.apply(returnData, responseData[propertyName]);
-	} while (responseData['pageToken'] !== undefined && responseData['pageToken'] !== '');
+	} while (responseData.pageToken !== undefined && responseData.pageToken !== '');
 
 	return returnData;
 }
 
-function getAccessToken(
+async function getAccessToken(
 	this: IExecuteFunctions | IExecuteSingleFunctions | ILoadOptionsFunctions,
 	credentials: IDataObject,
 ): Promise<IDataObject> {

packages/nodes-base/nodes/Google/BigQuery/GoogleBigQuery.node.ts

@@ -220,7 +220,7 @@ export class GoogleBigQuery implements INodeType {
 				const simple = this.getNodeParameter('simple', 0) as boolean;
 				let fields;
 
-				if (simple === true) {
+				if (simple) {
 					const { schema } = await googleApiRequest.call(
 						this,
 						'GET',