refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/Google/CloudStorage/BucketDescription.ts

@@ -1,5 +1,10 @@
-import { IDataObject, IExecuteSingleFunctions, IHttpRequestOptions } from 'n8n-workflow';
-import { INodeExecutionData, INodeProperties } from 'n8n-workflow';
+import {
+	IDataObject,
+	IExecuteSingleFunctions,
+	IHttpRequestOptions,
+	INodeExecutionData,
+	INodeProperties,
+} from 'n8n-workflow';
 
 // Projection field controls the page limit maximum
 // When not returning all, return the max number for the current projection parameter
@@ -185,6 +190,13 @@ export const bucketOperations: INodeProperties[] = [
 							let nextPageToken: string | undefined = undefined;
 							const returnAll = this.getNodeParameter('returnAll') as boolean;
 
+							const extractBucketsList = (page: INodeExecutionData) => {
+								const buckets = page.json.items as IDataObject[];
+								if (buckets) {
+									executions = executions.concat(buckets.map((bucket) => ({ json: bucket })));
+								}
+							};
+
 							do {
 								requestOptions.options.qs.pageToken = nextPageToken;
 								responseData = await this.makeRoutingRequest(requestOptions);
@@ -194,12 +206,7 @@ export const bucketOperations: INodeProperties[] = [
 								nextPageToken = lastItem.nextPageToken as string | undefined;
 
 								// Extract just the list of buckets from the page data
-								responseData.forEach((page) => {
-									const buckets = page.json.items as IDataObject[];
-									if (buckets) {
-										executions = executions.concat(buckets.map((bucket) => ({ json: bucket })));
-									}
-								});
+								responseData.forEach(extractBucketsList);
 								// If we don't return all, just return the first page
 							} while (returnAll && nextPageToken);