refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/HelpScout/HelpScout.node.ts

@@ -195,12 +195,12 @@ export class HelpScout implements INodeType {
 							);
 						}
 						if (threads) {
-							for (let i = 0; i < threads.length; i++) {
-								if (threads[i].type === '' || threads[i].text === '') {
+							for (let index = 0; index < threads.length; index++) {
+								if (threads[index].type === '' || threads[index].text === '') {
 									throw new NodeOperationError(this.getNode(), 'Chat Threads cannot be empty');
 								}
-								if (threads[i].type !== 'note') {
-									threads[i].customer = body.customer;
+								if (threads[index].type !== 'note') {
+									threads[index].customer = body.customer;
 								}
 							}
 							body.threads = threads;
@@ -518,9 +518,7 @@ export class HelpScout implements INodeType {
 								};
 								body.attachments?.push.apply(
 									body.attachments,
-									(attachments.attachmentsBinary as IDataObject[]).map(
-										mapFunction,
-									) as IAttachment[],
+									(attachments.attachmentsBinary as IDataObject[]).map(mapFunction),
 								);
 							}
 						}