admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 10:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Remove linting exceptions in nodes-base (#4794)

Browse Source 
* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts
View File

@@ -1023,7 +1023,7 @@ export class HttpRequestV3 implements INodeType {
requestOptions.resolveWithFullResponse = true;
}
if (redirect?.redirect?.followRedirects !== false) {
if (redirect?.redirect?.followRedirects) {
requestOptions.followRedirect = true;
requestOptions.followAllRedirects = true;
}
@@ -1032,7 +1032,7 @@ export class HttpRequestV3 implements INodeType {
requestOptions.maxRedirects = redirect?.redirect?.maxRedirects;
}
if (response?.response?.neverError === true) {
if (response?.response?.neverError) {
requestOptions.simple = false;
}
@@ -1222,7 +1222,7 @@ export class HttpRequestV3 implements INodeType {
if (!requestOptions.qs) {
requestOptions.qs = {};
}
requestOptions.qs![httpQueryAuth.name as string] = httpQueryAuth.value;
requestOptions.qs[httpQueryAuth.name as string] = httpQueryAuth.value;
}
if (httpDigestAuth !== undefined) {
requestOptions.auth = {
@@ -1232,14 +1232,14 @@ export class HttpRequestV3 implements INodeType {
};
}
if (requestOptions.headers!['accept'] === undefined) {
if (requestOptions.headers!.accept === undefined) {
if (responseFormat === 'json') {
requestOptions.headers!['accept'] = 'application/json,text/*;q=0.99';
requestOptions.headers!.accept = 'application/json,text/*;q=0.99';
} else if (responseFormat === 'text') {
requestOptions.headers!['accept'] =
requestOptions.headers!.accept =
'application/json,text/html,application/xhtml+xml,application/xml,text/*;q=0.9, */*;q=0.1';
} else {
requestOptions.headers!['accept'] =
requestOptions.headers!.accept =
'application/json,text/html,application/xhtml+xml,application/xml,text/*;q=0.9, image/*;q=0.8, */*;q=0.7';
}
}
@@ -1298,7 +1298,7 @@ export class HttpRequestV3 implements INodeType {
response = promisesResponses.shift();
if (response!.status !== 'fulfilled') {
if (this.continueOnFail() !== true) {
if (!this.continueOnFail()) {
if (autoDetectResponseFormat && response.reason.error instanceof Buffer) {
response.reason.error = Buffer.from(response.reason.error).toString();
}
@@ -1327,7 +1327,7 @@ export class HttpRequestV3 implements INodeType {
'autodetect',
) as string;
const fullResponse = this.getNodeParameter(
fullResponse = this.getNodeParameter(
'options.response.response.fullResponse',
0,
false,
@@ -1380,7 +1380,7 @@ export class HttpRequestV3 implements INodeType {
const fileName = url.split('/').pop();
if (fullResponse === true) {
if (fullResponse) {
const returnItem: IDataObject = {};
for (const property of fullReponseProperties) {
if (property === 'body') {
@@ -1411,7 +1411,7 @@ export class HttpRequestV3 implements INodeType {
0,
'data',
) as string;
if (fullResponse === true) {
if (fullResponse) {
const returnItem: IDataObject = {};
for (const property of fullReponseProperties) {
if (property === 'body') {
@@ -1477,6 +1477,7 @@ export class HttpRequestV3 implements INodeType {
}
if (Array.isArray(response)) {
// eslint-disable-next-line @typescript-eslint/no-loop-func
response.forEach((item) =>
returnItems.push({
json: item,