admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Remove linting exceptions in nodes-base (#4794)

Browse Source 
* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/nodes-base/nodes/Hubspot/GenericFunctions.ts
View File

@@ -45,7 +45,7 @@ export async function hubspotApiRequest(
try {
if (authenticationMethod === 'apiKey' || authenticationMethod === 'appToken') {
const credentialType = authenticationMethod === 'apiKey' ? 'hubspotApi' : 'hubspotAppToken';
return this.helpers.requestWithAuthentication.call(this, credentialType, options);
return await this.helpers.requestWithAuthentication.call(this, credentialType, options);
} else if (authenticationMethod === 'developerApi') {
if (endpoint.includes('webhooks')) {
const credentials = await this.getCredentials('hubspotDeveloperApi');
@@ -94,15 +94,15 @@ export async function hubspotApiRequestAllItems(
query.offset = responseData.offset;
query.vidOffset = responseData['vid-offset'];
//Used by Search endpoints
if (responseData['paging']) {
body.after = responseData['paging']['next']['after'];
if (responseData.paging) {
body.after = responseData.paging.next.after;
}
returnData.push.apply(returnData, responseData[propertyName]);
//ticket:getAll endpoint does not support setting a limit, so return once the limit is reached
if (query.limit && query.limit <= returnData.length && endpoint.includes('/tickets/paged')) {
return returnData;
}
} while (responseData['hasMore'] || responseData['has-more'] || responseData['paging']);
} while (responseData.hasMore || responseData['has-more'] || responseData.paging);
return returnData;
}
@@ -2007,5 +2007,5 @@ export async function validateCredentials(
options.headers = { Authorization: `Bearer ${appToken}` };
}
return await this.helpers.request(options);
return this.helpers.request(options);
}