admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Remove linting exceptions in nodes-base (#4794)

Browse Source 
* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/nodes-base/nodes/Iterable/GenericFunctions.ts
View File

@@ -57,9 +57,9 @@ export async function iterableApiRequestAllItems(
do {
responseData = await iterableApiRequest.call(this, method, endpoint, body, query);
query.pageToken = responseData['nextPageToken'];
query.pageToken = responseData.nextPageToken;
returnData.push.apply(returnData, responseData[propertyName]);
} while (responseData['nextPageToken'] !== undefined && responseData['nextPageToken'] !== '');
} while (responseData.nextPageToken !== undefined && responseData.nextPageToken !== '');
return returnData;
}

6
packages/nodes-base/nodes/Iterable/Iterable.node.ts
View File

@@ -180,7 +180,7 @@ export class Iterable implements INodeType {
responseData = await iterableApiRequest.call(this, 'POST', '/users/update', body);
if (this.continueOnFail() === false) {
if (!this.continueOnFail()) {
if (responseData.code !== 'Success') {
throw new NodeOperationError(
this.getNode(),
@@ -212,7 +212,7 @@ export class Iterable implements INodeType {
responseData = await iterableApiRequest.call(this, 'DELETE', endpoint);
if (this.continueOnFail() === false) {
if (!this.continueOnFail()) {
if (responseData.code !== 'Success') {
throw new NodeApiError(this.getNode(), responseData);
}
@@ -241,7 +241,7 @@ export class Iterable implements INodeType {
responseData = await iterableApiRequest.call(this, 'GET', endpoint, {}, qs);
if (this.continueOnFail() === false) {
if (!this.continueOnFail()) {
if (Object.keys(responseData).length === 0) {
throw new NodeApiError(this.getNode(), responseData, {
message: `User not found`,