refactor(core): Remove linting exceptions in nodes-base (#4794)

*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions

View File

@@ -171,9 +171,7 @@ export class KafkaTrigger implements INodeType {
const credentials = await this.getCredentials('kafka');
const brokers = ((credentials.brokers as string) || '')
.split(',')
.map((item) => item.trim()) as string[];
const brokers = ((credentials.brokers as string) || '').split(',').map((item) => item.trim());
const clientId = credentials.clientId as string;
@@ -231,7 +229,7 @@ export class KafkaTrigger implements INodeType {
await consumer.run({
autoCommitInterval: (options.autoCommitInterval as number) || null,
autoCommitThreshold: (options.autoCommitThreshold as number) || null,
eachMessage: async ({ topic, message }) => {
eachMessage: async ({ topic: messageTopic, message }) => {
let data: IDataObject = {};
let value = message.value?.toString() as string;
@@ -259,7 +257,7 @@ export class KafkaTrigger implements INodeType {
}
data.message = value;
data.topic = topic;
data.topic = messageTopic;
if (options.onlyMessage) {
//@ts-ignore
@@ -271,7 +269,7 @@ export class KafkaTrigger implements INodeType {
});
};
startConsumer();
await startConsumer();
// The "closeFunction" function gets called by n8n whenever
// the workflow gets deactivated and can so clean up.
@@ -286,7 +284,7 @@ export class KafkaTrigger implements INodeType {
// would trigger by itself so that the user knows what data
// to expect.
async function manualTriggerFunction() {
startConsumer();
await startConsumer();
}
return {