admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-19 11:01:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Remove linting exceptions in nodes-base (#4794)

Browse Source 
* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/nodes-base/nodes/KoBoToolbox/GenericFunctions.ts
View File

@@ -191,8 +191,9 @@ export async function downloadAttachments(
const credentials = await this.getCredentials('koBoToolboxApi');
// Look for attachment links - there can be more than one
const attachmentList = (submission['_attachments'] || submission['attachments']) as any[];
if (attachmentList && attachmentList.length) {
const attachmentList = (submission._attachments || submission.attachments) as any[]; // tslint:disable-line:no-any
if (attachmentList?.length) {
for (const [index, attachment] of attachmentList.entries()) {
// look for the question name linked to this attachment
const fileName = attachment.filename;
@@ -237,7 +238,7 @@ export async function downloadAttachments(
while (!final && redir < 5) {
response = await this.helpers.httpRequest(axiosOptions);
if (response && response.headers.location) {
if (response?.headers.location) {
// Follow redirect
axiosOptions.url = response.headers.location;
redir++;
@@ -246,7 +247,7 @@ export async function downloadAttachments(
}
}
if (response && response.body) {
if (response?.body) {
// Use the provided prefix if any, otherwise try to use the original question name
let binaryName;
if ('question' === options.binaryNamingScheme && relatedQuestion) {