refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/MQTT/Mqtt.node.ts

@@ -12,8 +12,6 @@ import {
 
 import mqtt from 'mqtt';
 
-import { IClientOptions } from 'mqtt';
-
 export class Mqtt implements INodeType {
 	description: INodeTypeDescription = {
 		displayName: 'MQTT',
@@ -128,8 +126,8 @@ export class Mqtt implements INodeType {
 
 					let client: mqtt.MqttClient;
 
-					if (ssl === false) {
-						const clientOptions: IClientOptions = {
+					if (!ssl) {
+						const clientOptions: mqtt.IClientOptions = {
 							port,
 							clean,
 							clientId,
@@ -141,7 +139,7 @@ export class Mqtt implements INodeType {
 						}
 						client = mqtt.connect(brokerUrl, clientOptions);
 					} else {
-						const clientOptions: IClientOptions = {
+						const clientOptions: mqtt.IClientOptions = {
 							port,
 							clean,
 							clientId,
@@ -202,8 +200,8 @@ export class Mqtt implements INodeType {
 
 		let client: mqtt.MqttClient;
 
-		if (ssl === false) {
-			const clientOptions: IClientOptions = {
+		if (!ssl) {
+			const clientOptions: mqtt.IClientOptions = {
 				port,
 				clean,
 				clientId,
@@ -216,7 +214,7 @@ export class Mqtt implements INodeType {
 
 			client = mqtt.connect(brokerUrl, clientOptions);
 		} else {
-			const clientOptions: IClientOptions = {
+			const clientOptions: mqtt.IClientOptions = {
 				port,
 				clean,
 				clientId,
@@ -243,7 +241,7 @@ export class Mqtt implements INodeType {
 					const options = this.getNodeParameter('options', i);
 
 					try {
-						if (sendInputData === true) {
+						if (sendInputData) {
 							message = JSON.stringify(items[i].json);
 						} else {
 							message = this.getNodeParameter('message', i) as string;