refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/MQTT/MqttTrigger.node.ts

@@ -10,8 +10,6 @@ import {
 
 import mqtt from 'mqtt';
 
-import { IClientOptions, ISubscriptionMap } from 'mqtt';
-
 export class MqttTrigger implements INodeType {
 	description: INodeTypeDescription = {
 		displayName: 'MQTT Trigger',
@@ -99,8 +97,8 @@ export class MqttTrigger implements INodeType {
 
 		let client: mqtt.MqttClient;
 
-		if (ssl === false) {
-			const clientOptions: IClientOptions = {
+		if (!ssl) {
+			const clientOptions: mqtt.IClientOptions = {
 				port,
 				clean,
 				clientId,
@@ -113,7 +111,7 @@ export class MqttTrigger implements INodeType {
 
 			client = mqtt.connect(brokerUrl, clientOptions);
 		} else {
-			const clientOptions: IClientOptions = {
+			const clientOptions: mqtt.IClientOptions = {
 				port,
 				clean,
 				clientId,
@@ -135,19 +133,19 @@ export class MqttTrigger implements INodeType {
 		async function manualTriggerFunction() {
 			await new Promise((resolve, reject) => {
 				client.on('connect', () => {
-					client.subscribe(topicsQoS as ISubscriptionMap, (err, _granted) => {
+					client.subscribe(topicsQoS as mqtt.ISubscriptionMap, (err, _granted) => {
 						if (err) {
 							reject(err);
 						}
 						client.on('message', (topic: string, message: Buffer | string) => {
 							let result: IDataObject = {};
 
-							message = message.toString() as string;
+							message = message.toString();
 
 							if (options.jsonParseBody) {
 								try {
 									message = JSON.parse(message.toString());
-								} catch (err) {}
+								} catch (error) {}
 							}
 
 							result.message = message;
@@ -170,7 +168,7 @@ export class MqttTrigger implements INodeType {
 		}
 
 		if (this.getMode() === 'trigger') {
-			manualTriggerFunction();
+			await manualTriggerFunction();
 		}
 
 		async function closeFunction() {