admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Remove linting exceptions in nodes-base (#4794)

Browse Source 
* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/nodes-base/nodes/Magento/GenericFunctions.ts
View File

@@ -60,7 +60,7 @@ export async function magentoApiRequestAllItems(
do {
responseData = await magentoApiRequest.call(this, method, resource, body, query);
returnData.push.apply(returnData, responseData[propertyName]);
query['current_page'] = query.current_page ? (query.current_page as number)++ : 1;
query.current_page = query.current_page ? (query.current_page as number)++ : 1;
} while (returnData.length < responseData.total_count);
return returnData;
@@ -1012,8 +1012,8 @@ export async function getProductAttributes(
const returnData: INodePropertyOptions[] = [];
for (const attribute of attributes) {
returnData.push({
name: attribute.default_frontend_label as string,
value: attribute.attribute_code as string,
name: attribute.default_frontend_label,
value: attribute.attribute_code,
});
}
if (extraValue) {

34
packages/nodes-base/nodes/Magento/Magento2.node.ts
View File

@@ -279,7 +279,7 @@ export class Magento2 implements INodeType {
async getFilterableCustomerAttributes(
this: ILoadOptionsFunctions,
): Promise<INodePropertyOptions[]> {
return getProductAttributes.call(this, (attribute) => attribute.is_filterable === true);
return getProductAttributes.call(this, (attribute) => attribute.is_filterable);
},
async getProductAttributes(this: ILoadOptionsFunctions): Promise<INodePropertyOptions[]> {
return getProductAttributes.call(this);
@@ -295,7 +295,7 @@ export class Magento2 implements INodeType {
async getSortableProductAttributes(
this: ILoadOptionsFunctions,
): Promise<INodePropertyOptions[]> {
return getProductAttributes.call(this, (attribute) => attribute.used_for_sort_by === true);
return getProductAttributes.call(this, (attribute) => attribute.used_for_sort_by);
},
async getOrderAttributes(this: ILoadOptionsFunctions): Promise<INodePropertyOptions[]> {
return getOrderFields()
@@ -402,7 +402,7 @@ export class Magento2 implements INodeType {
if (operation === 'getAll') {
//https://magento.redoc.ly/2.3.7-admin/tag/customerssearch
const filterType = this.getNodeParameter('filterType', i) as string;
const sort = this.getNodeParameter('options.sort', i, {}) as {
const sortOption = this.getNodeParameter('options.sort', i, {}) as {
sort: [{ direction: string; field: string }];
};
const returnAll = this.getNodeParameter('returnAll', 0);
@@ -411,7 +411,7 @@ export class Magento2 implements INodeType {
if (filterType === 'manual') {
const filters = this.getNodeParameter('filters', i) as { conditions: Filter[] };
const matchType = this.getNodeParameter('matchType', i) as string;
qs = getFilterQuery(Object.assign(filters, { matchType }, sort));
qs = getFilterQuery(Object.assign(filters, { matchType }, sortOption));
} else if (filterType === 'json') {
const filterJson = this.getNodeParameter('filterJson', i) as string;
if (validateJSON(filterJson) !== undefined) {
@@ -426,14 +426,14 @@ export class Magento2 implements INodeType {
search_criteria: {},
};
if (Object.keys(sort).length !== 0) {
if (Object.keys(sortOption).length !== 0) {
qs.search_criteria = {
sort_orders: sort.sort,
sort_orders: sortOption.sort,
};
}
}
if (returnAll === true) {
if (returnAll) {
qs.search_criteria!.page_size = 100;
responseData = await magentoApiRequestAllItems.call(
this,
@@ -581,7 +581,7 @@ export class Magento2 implements INodeType {
if (operation === 'getAll') {
//https://magento.redoc.ly/2.3.7-admin/tag/orders#operation/salesOrderRepositoryV1GetListGet
const filterType = this.getNodeParameter('filterType', i) as string;
const sort = this.getNodeParameter('options.sort', i, {}) as {
const sortOption = this.getNodeParameter('options.sort', i, {}) as {
sort: [{ direction: string; field: string }];
};
const returnAll = this.getNodeParameter('returnAll', 0);
@@ -590,7 +590,7 @@ export class Magento2 implements INodeType {
if (filterType === 'manual') {
const filters = this.getNodeParameter('filters', i) as { conditions: Filter[] };
const matchType = this.getNodeParameter('matchType', i) as string;
qs = getFilterQuery(Object.assign(filters, { matchType }, sort));
qs = getFilterQuery(Object.assign(filters, { matchType }, sortOption));
} else if (filterType === 'json') {
const filterJson = this.getNodeParameter('filterJson', i) as string;
if (validateJSON(filterJson) !== undefined) {
@@ -604,14 +604,14 @@ export class Magento2 implements INodeType {
qs = {
search_criteria: {},
};
if (Object.keys(sort).length !== 0) {
if (Object.keys(sortOption).length !== 0) {
qs.search_criteria = {
sort_orders: sort.sort,
sort_orders: sortOption.sort,
};
}
}
if (returnAll === true) {
if (returnAll) {
qs.search_criteria!.page_size = 100;
responseData = await magentoApiRequestAllItems.call(
this,
@@ -703,7 +703,7 @@ export class Magento2 implements INodeType {
if (operation === 'getAll') {
//https://magento.redoc.ly/2.3.7-admin/tag/customerssearch
const filterType = this.getNodeParameter('filterType', i) as string;
const sort = this.getNodeParameter('options.sort', i, {}) as {
const sortOption = this.getNodeParameter('options.sort', i, {}) as {
sort: [{ direction: string; field: string }];
};
const returnAll = this.getNodeParameter('returnAll', 0);
@@ -712,7 +712,7 @@ export class Magento2 implements INodeType {
if (filterType === 'manual') {
const filters = this.getNodeParameter('filters', i) as { conditions: Filter[] };
const matchType = this.getNodeParameter('matchType', i) as string;
qs = getFilterQuery(Object.assign(filters, { matchType }, sort));
qs = getFilterQuery(Object.assign(filters, { matchType }, sortOption));
} else if (filterType === 'json') {
const filterJson = this.getNodeParameter('filterJson', i) as string;
if (validateJSON(filterJson) !== undefined) {
@@ -726,14 +726,14 @@ export class Magento2 implements INodeType {
qs = {
search_criteria: {},
};
if (Object.keys(sort).length !== 0) {
if (Object.keys(sortOption).length !== 0) {
qs.search_criteria = {
sort_orders: sort.sort,
sort_orders: sortOption.sort,
};
}
}
if (returnAll === true) {
if (returnAll) {
qs.search_criteria!.page_size = 100;
responseData = await magentoApiRequestAllItems.call(
this,

6
packages/nodes-base/nodes/Magento/Types.d.ts vendored
View File

@@ -1,3 +1,5 @@
import { IDataObject } from 'n8n-workflow';
export interface NewCustomer {
customer?: Customer;
password?: string;
@@ -117,11 +119,9 @@ export interface CustomerAttributeMetadata {
export interface CustomerAttributeMetadataOption {
label?: string;
value?: string;
options?: OptionOption[];
options?: IDataObject[];
}
export interface OptionOption {}
export interface ValidationRule {
name?: string;
value?: string;