refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/Mattermost/v1/MattermostV1.node.ts

@@ -19,6 +19,6 @@ export class MattermostV1 implements INodeType {
 	methods = { loadOptions };
 
 	async execute(this: IExecuteFunctions) {
-		return await router.call(this);
+		return router.call(this);
 	}
 }

packages/nodes-base/nodes/Mattermost/v1/actions/channel/members/execute.ts

@@ -9,8 +9,8 @@ export async function members(
 	index: number,
 ): Promise<INodeExecutionData[]> {
 	const channelId = this.getNodeParameter('channelId', index) as string;
-	const returnAll = this.getNodeParameter('returnAll', index) as boolean;
-	const resolveData = this.getNodeParameter('resolveData', index) as boolean;
+	const returnAll = this.getNodeParameter('returnAll', index);
+	const resolveData = this.getNodeParameter('resolveData', index);
 	const limit = this.getNodeParameter('limit', index, 0);
 
 	const body = {} as IDataObject;
@@ -18,7 +18,7 @@ export async function members(
 	const requestMethod = 'GET';
 	const endpoint = `channels/${channelId}/members`;
 
-	if (returnAll === false) {
+	if (!returnAll) {
 		qs.per_page = this.getNodeParameter('limit', index);
 	}
 

packages/nodes-base/nodes/Mattermost/v1/actions/user/getAll/execute.ts

@@ -10,7 +10,7 @@ export async function getAll(
 	this: IExecuteFunctions,
 	index: number,
 ): Promise<INodeExecutionData[]> {
-	const returnAll = this.getNodeParameter('returnAll', index) as boolean;
+	const returnAll = this.getNodeParameter('returnAll', index);
 	const additionalFields = this.getNodeParameter('additionalFields', index);
 
 	const qs = {} as IDataObject;
@@ -97,7 +97,7 @@ export async function getAll(
 		qs.sort = '';
 	}
 
-	if (returnAll === false) {
+	if (!returnAll) {
 		qs.per_page = this.getNodeParameter('limit', index);
 	}
 

packages/nodes-base/nodes/Mattermost/v1/actions/user/getById/execute.ts

@@ -11,7 +11,7 @@ export async function getById(
 	const qs = {} as IDataObject;
 	const requestMethod = 'POST';
 	const endpoint = 'users/ids';
-	const userIds = (this.getNodeParameter('userIds', index) as string).split(',') as string[];
+	const userIds = (this.getNodeParameter('userIds', index) as string).split(',');
 	const additionalFields = this.getNodeParameter('additionalFields', index);
 	const body = userIds;