refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/MySql/GenericFunctions.ts

@@ -31,7 +31,7 @@ export function copyInputItems(items: INodeExecutionData[], properties: string[]
 	});
 }
 
-export function createConnection(
+export async function createConnection(
 	credentials: ICredentialDataDecryptedObject,
 ): Promise<mysql2.Connection> {
 	const { ssl, caCertificate, clientCertificate, clientPrivateKey, ...baseCredentials } =
@@ -70,6 +70,6 @@ export async function searchTables(
 		name: r.TABLE_NAME as string,
 		value: r.TABLE_NAME as string,
 	}));
-	connection.end();
+	await connection.end();
 	return { results };
 }