admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-20 19:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Remove linting exceptions in nodes-base (#4794)

Browse Source 
* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
packages/nodes-base/nodes/Nasa/Nasa.node.ts
View File

@@ -916,7 +916,7 @@ export class Nasa implements INodeType {
if (operation === 'getAll') {
returnAll = this.getNodeParameter('returnAll', 0);
if (returnAll === false) {
if (!returnAll) {
qs.size = this.getNodeParameter('limit', 0);
}
@@ -1071,7 +1071,7 @@ export class Nasa implements INodeType {
if (resource === 'astronomyPictureOfTheDay') {
download = this.getNodeParameter('download', 0);
if (download === true) {
if (download) {
const binaryProperty = this.getNodeParameter('binaryPropertyName', i) as string;
const data = await nasaApiRequest.call(
@@ -1115,11 +1115,7 @@ export class Nasa implements INodeType {
if (this.continueOnFail()) {
if (resource === 'earthImagery' && operation === 'get') {
items[i].json = { error: error.message };
} else if (
resource === 'astronomyPictureOfTheDay' &&
operation === 'get' &&
download === true
) {
} else if (resource === 'astronomyPictureOfTheDay' && operation === 'get' && download) {
items[i].json = { error: error.message };
} else {
const executionErrorData = this.helpers.constructExecutionMetaData(
@@ -1136,11 +1132,7 @@ export class Nasa implements INodeType {
if (resource === 'earthImagery' && operation === 'get') {
return this.prepareOutputData(items);
} else if (
resource === 'astronomyPictureOfTheDay' &&
operation === 'get' &&
download === true
) {
} else if (resource === 'astronomyPictureOfTheDay' && operation === 'get' && download) {
return this.prepareOutputData(items);
} else {
return this.prepareOutputData(returnData);