refactor(core): Remove linting exceptions in nodes-base (#4794)

*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions

View File

@@ -75,7 +75,7 @@ export async function apiRequestAllItems(
body: IDataObject,
query?: IDataObject,
): Promise<any> {
const version = this.getNode().typeVersion as number;
const version = this.getNode().typeVersion;
if (query === undefined) {
query = {};
@@ -108,8 +108,8 @@ export async function downloadRecordAttachments(
element.json = record as unknown as IDataObject;
for (const fieldName of fieldNames) {
if (record[fieldName]) {
for (const [index, attachment] of (
jsonParse(record[fieldName] as string) as IAttachment[]
for (const [index, attachment] of jsonParse<IAttachment[]>(
record[fieldName] as string,
).entries()) {
const file = await apiRequest.call(this, 'GET', '', {}, {}, attachment.url, {
json: false,