refactor(core): Remove linting exceptions in nodes-base (#4794)

*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions

View File

@@ -153,7 +153,7 @@ export class Phantombuster implements INodeType {
qs,
);
if (resolveData === true) {
if (resolveData) {
const { resultObject } = await phantombusterApiRequest.call(
this,
'GET',
@@ -175,7 +175,7 @@ export class Phantombuster implements INodeType {
responseData = await phantombusterApiRequest.call(this, 'GET', '/agents/fetch-all');
if (returnAll === false) {
if (!returnAll) {
const limit = this.getNodeParameter('limit', 0);
responseData = responseData.splice(0, limit);
}
@@ -214,8 +214,8 @@ export class Phantombuster implements INodeType {
}
} else {
const argumentParameters =
(((additionalFields.argumentsUi as IDataObject) || {})
.argumentValues as IDataObject[]) || [];
((additionalFields.argumentsUi as IDataObject)?.argumentValues as IDataObject[]) ||
[];
body.arguments = argumentParameters.reduce((object, currentValue) => {
object[currentValue.key as string] = currentValue.value;
return object;
@@ -223,8 +223,8 @@ export class Phantombuster implements INodeType {
delete additionalFields.argumentsUi;
const bonusParameters =
(((additionalFields.bonusArgumentUi as IDataObject) || {})
.bonusArgumentValue as IDataObject[]) || [];
((additionalFields.bonusArgumentUi as IDataObject)
?.bonusArgumentValue as IDataObject[]) || [];
body.bonusArgument = bonusParameters.reduce((object, currentValue) => {
object[currentValue.key as string] = currentValue.value;
return object;
@@ -236,7 +236,7 @@ export class Phantombuster implements INodeType {
responseData = await phantombusterApiRequest.call(this, 'POST', '/agents/launch', body);
if (resolveData === true) {
if (resolveData) {
responseData = await phantombusterApiRequest.call(
this,
'GET',