refactor(core): Remove linting exceptions in nodes-base (#4794)

*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions

View File

@@ -69,7 +69,7 @@ export async function quickBooksApiRequest(
}
if (isDownload) {
options.headers!['Accept'] = 'application/pdf';
options.headers!.Accept = 'application/pdf';
}
if (resource === 'invoice' && operation === 'send') {
@@ -84,7 +84,7 @@ export async function quickBooksApiRequest(
}
try {
return await this.helpers.requestOAuth2!.call(this, 'quickBooksOAuth2Api', options);
return this.helpers.requestOAuth2!.call(this, 'quickBooksOAuth2Api', options);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}
@@ -168,7 +168,7 @@ export async function handleListing(
}
if (returnAll) {
return await quickBooksApiRequestAllItems.call(this, 'GET', endpoint, qs, {}, resource);
return quickBooksApiRequestAllItems.call(this, 'GET', endpoint, qs, {}, resource);
} else {
const limit = this.getNodeParameter('limit', i);
qs.query += ` MAXRESULTS ${limit}`;
@@ -268,6 +268,7 @@ export async function loadResource(this: ILoadOptionsFunctions, resource: string
if (resource === 'preferences') {
const {
// eslint-disable-next-line @typescript-eslint/no-shadow
SalesFormsPrefs: { CustomField },
} = resourceItems[0];
const customFields = CustomField[1].CustomField;
@@ -398,7 +399,7 @@ export function populateFields(
const length = (body.CustomField as CustomField[]).length;
for (let i = 0; i < length; i++) {
//@ts-ignore
body.CustomField[i]['Type'] = 'StringType';
body.CustomField[i].Type = 'StringType';
}
} else if (key === 'CustomerMemo') {
body.CustomerMemo = {