refactor(core): Remove linting exceptions in nodes-base (#4794)

*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions

View File

@@ -335,7 +335,7 @@ export class RabbitMQ implements INodeType {
if (mode === 'queue') {
const queue = this.getNodeParameter('queue', 0) as string;
options = this.getNodeParameter('options', 0, {}) as IDataObject;
options = this.getNodeParameter('options', 0, {});
channel = await rabbitmqConnectQueue.call(this, queue, options);
@@ -345,7 +345,7 @@ export class RabbitMQ implements INodeType {
const queuePromises = [];
for (let i = 0; i < items.length; i++) {
if (sendInputData === true) {
if (sendInputData) {
message = JSON.stringify(items[i].json);
} else {
message = this.getNodeParameter('message', i) as string;
@@ -356,7 +356,7 @@ export class RabbitMQ implements INodeType {
options.headers &&
((options.headers as IDataObject).header! as IDataObject[]).length
) {
const itemOptions = this.getNodeParameter('options', i, {}) as IDataObject;
const itemOptions = this.getNodeParameter('options', i, {});
const additionalHeaders: IDataObject = {};
((itemOptions.headers as IDataObject).header as IDataObject[]).forEach(
(header: IDataObject) => {
@@ -374,8 +374,8 @@ export class RabbitMQ implements INodeType {
// @ts-ignore
promisesResponses.forEach((response: JsonObject) => {
if (response!.status !== 'fulfilled') {
if (this.continueOnFail() !== true) {
if (response.status !== 'fulfilled') {
if (!this.continueOnFail()) {
throw new NodeApiError(this.getNode(), response);
} else {
// Return the actual reason as error
@@ -402,7 +402,7 @@ export class RabbitMQ implements INodeType {
const type = this.getNodeParameter('exchangeType', 0) as string;
const routingKey = this.getNodeParameter('routingKey', 0) as string;
options = this.getNodeParameter('options', 0, {}) as IDataObject;
options = this.getNodeParameter('options', 0, {});
channel = await rabbitmqConnectExchange.call(this, exchange, type, options);
@@ -412,7 +412,7 @@ export class RabbitMQ implements INodeType {
const exchangePromises = [];
for (let i = 0; i < items.length; i++) {
if (sendInputData === true) {
if (sendInputData) {
message = JSON.stringify(items[i].json);
} else {
message = this.getNodeParameter('message', i) as string;
@@ -423,7 +423,7 @@ export class RabbitMQ implements INodeType {
options.headers &&
((options.headers as IDataObject).header! as IDataObject[]).length
) {
const itemOptions = this.getNodeParameter('options', i, {}) as IDataObject;
const itemOptions = this.getNodeParameter('options', i, {});
const additionalHeaders: IDataObject = {};
((itemOptions.headers as IDataObject).header as IDataObject[]).forEach(
(header: IDataObject) => {
@@ -443,8 +443,8 @@ export class RabbitMQ implements INodeType {
// @ts-ignore
promisesResponses.forEach((response: JsonObject) => {
if (response!.status !== 'fulfilled') {
if (this.continueOnFail() !== true) {
if (response.status !== 'fulfilled') {
if (!this.continueOnFail()) {
throw new NodeApiError(this.getNode(), response);
} else {
// Return the actual reason as error
@@ -470,7 +470,7 @@ export class RabbitMQ implements INodeType {
throw new NodeOperationError(this.getNode(), `The operation "${mode}" is not known!`);
}
return this.prepareOutputData(returnItems);
return await this.prepareOutputData(returnItems);
} catch (error) {
if (channel) {
await channel.close();