refactor(core): Remove linting exceptions in nodes-base (#4794)

*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions

View File

@@ -183,7 +183,7 @@ export class RabbitMQTrigger implements INodeType {
const startConsumer = async () => {
if (parallelMessages !== -1) {
channel.prefetch(parallelMessages);
await channel.prefetch(parallelMessages);
}
channel.on('close', () => {
@@ -199,7 +199,7 @@ export class RabbitMQTrigger implements INodeType {
messageTracker.received(message);
}
let content: IDataObject | string = message!.content!.toString();
let content: IDataObject | string = message.content.toString();
const item: INodeExecutionData = {
json: {},
@@ -214,7 +214,7 @@ export class RabbitMQTrigger implements INodeType {
message.content = undefined as unknown as Buffer;
} else {
if (options.jsonParseBody === true) {
content = JSON.parse(content as string);
content = JSON.parse(content);
}
if (options.onlyContent === true) {
item.json = content as IDataObject;
@@ -270,14 +270,14 @@ export class RabbitMQTrigger implements INodeType {
consumerTag = consumerInfo.consumerTag;
};
startConsumer();
await startConsumer();
// The "closeFunction" function gets called by n8n whenever
// the workflow gets deactivated and can so clean up.
async function closeFunction() {
closeGotCalled = true;
try {
return messageTracker.closeChannel(channel, consumerTag);
return await messageTracker.closeChannel(channel, consumerTag);
} catch (error) {
const workflow = self.getWorkflow();
const node = self.getNode();