refactor(core): Remove linting exceptions in nodes-base (#4794)

*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions

View File

@@ -1,7 +1,6 @@
import { IExecuteFunctions } from 'n8n-core';
import {
IBinaryData,
IDataObject,
ILoadOptionsFunctions,
INodeExecutionData,
@@ -136,9 +135,7 @@ export class Raindrop implements INodeType {
}
if (additionalFields.tags) {
body.tags = (additionalFields.tags as string)
.split(',')
.map((tag) => tag.trim()) as string[];
body.tags = (additionalFields.tags as string).split(',').map((tag) => tag.trim());
}
const endpoint = `/raindrop`;
@@ -172,7 +169,7 @@ export class Raindrop implements INodeType {
responseData = await raindropApiRequest.call(this, 'GET', endpoint, {}, {});
responseData = responseData.items;
if (returnAll === false) {
if (!returnAll) {
const limit = this.getNodeParameter('limit', 0);
responseData = responseData.slice(0, limit);
}
@@ -208,9 +205,7 @@ export class Raindrop implements INodeType {
delete updateFields.pleaseParse;
}
if (updateFields.tags) {
body.tags = (updateFields.tags as string)
.split(',')
.map((tag) => tag.trim()) as string[];
body.tags = (updateFields.tags as string).split(',').map((tag) => tag.trim());
}
const endpoint = `/raindrop/${bookmarkId}`;
@@ -244,7 +239,7 @@ export class Raindrop implements INodeType {
}
if (additionalFields.parentId) {
body['parent.$id'] = parseInt(additionalFields.parentId as string, 10) as number;
body['parent.$id'] = parseInt(additionalFields.parentId as string, 10);
delete additionalFields.parentId;
}
@@ -282,7 +277,7 @@ export class Raindrop implements INodeType {
responseData = await raindropApiRequest.call(this, 'GET', endpoint, {}, {});
responseData = responseData.items;
if (returnAll === false) {
if (!returnAll) {
const limit = this.getNodeParameter('limit', 0);
responseData = responseData.slice(0, limit);
}
@@ -306,7 +301,7 @@ export class Raindrop implements INodeType {
}
if (updateFields.parentId) {
body['parent.$id'] = parseInt(updateFields.parentId as string, 10) as number;
body['parent.$id'] = parseInt(updateFields.parentId as string, 10);
delete updateFields.parentId;
}
@@ -335,7 +330,7 @@ export class Raindrop implements INodeType {
const binaryPropertyName = updateFields.cover as string;
const binaryData = items[i].binary![binaryPropertyName] as IBinaryData;
const binaryData = items[i].binary![binaryPropertyName];
const dataBuffer = await this.helpers.getBinaryDataBuffer(i, binaryPropertyName);
const formData = {
@@ -348,11 +343,11 @@ export class Raindrop implements INodeType {
},
};
const endpoint = `/collection/${collectionId}/cover`;
const requestEndpoint = `/collection/${collectionId}/cover`;
responseData = await raindropApiRequest.call(
this,
'PUT',
endpoint,
requestEndpoint,
{},
{},
{ 'Content-Type': 'multipart/form-data', formData },
@@ -398,7 +393,7 @@ export class Raindrop implements INodeType {
let endpoint = `/tags`;
const body: IDataObject = {
tags: (this.getNodeParameter('tags', i) as string).split(',') as string[],
tags: (this.getNodeParameter('tags', i) as string).split(','),
};
const additionalFields = this.getNodeParameter('additionalFields', i);
@@ -426,7 +421,7 @@ export class Raindrop implements INodeType {
responseData = await raindropApiRequest.call(this, 'GET', endpoint, {}, {});
responseData = responseData.items;
if (returnAll === false) {
if (!returnAll) {
const limit = this.getNodeParameter('limit', 0);
responseData = responseData.slice(0, limit);
}