refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/Reddit/Reddit.node.ts

@@ -372,7 +372,7 @@ export class Reddit implements INodeType {
 							const endpoint = 'api/trending_subreddits.json';
 							responseData = await redditApiRequest.call(this, 'GET', endpoint, {});
 							responseData = responseData.subreddit_names.map((name: string) => ({ name }));
-							if (returnAll === false) {
+							if (!returnAll) {
 								const limit = this.getNodeParameter('limit', 0);
 								responseData = responseData.splice(0, limit);
 							}
@@ -385,7 +385,7 @@ export class Reddit implements INodeType {
 
 							const returnAll = this.getNodeParameter('returnAll', 0);
 
-							if (returnAll === false) {
+							if (!returnAll) {
 								const limit = this.getNodeParameter('limit', 0);
 								responseData = responseData.subreddits.splice(0, limit);
 							}