refactor(core): Remove linting exceptions in nodes-base (#4794)

*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions

View File

@@ -305,7 +305,7 @@ export class Salesmate implements INodeType {
itemIndex: i,
});
}
body.fields = (options.fields as string).split(',') as string[];
body.fields = (options.fields as string).split(',');
} else {
body.fields = [
'name',
@@ -325,9 +325,8 @@ export class Salesmate implements INodeType {
}
if (!jsonActive) {
const filters: IDataObject[] = [];
const filtersUi = (this.getNodeParameter('filters', i) as IDataObject)
.filtersUi as IDataObject;
if (filtersUi && filtersUi.conditions) {
const filtersUi = this.getNodeParameter('filters', i).filtersUi as IDataObject;
if (filtersUi?.conditions) {
const conditions = filtersUi.conditions as IDataObject;
if (conditions.conditionsUi) {
for (const condition of conditions.conditionsUi as IDataObject[]) {
@@ -342,7 +341,7 @@ export class Salesmate implements INodeType {
}
}
}
if (filtersUi && filtersUi.operator) {
if (filtersUi?.operator) {
//@ts-ignore
body.query.group = {
operator: filtersUi.operator,
@@ -498,7 +497,7 @@ export class Salesmate implements INodeType {
itemIndex: i,
});
}
body.fields = (options.fields as string).split(',') as string[];
body.fields = (options.fields as string).split(',');
} else {
body.fields = [
'title',
@@ -519,9 +518,8 @@ export class Salesmate implements INodeType {
}
if (!jsonActive) {
const filters: IDataObject[] = [];
const filtersUi = (this.getNodeParameter('filters', i) as IDataObject)
.filtersUi as IDataObject;
if (filtersUi && filtersUi.conditions) {
const filtersUi = this.getNodeParameter('filters', i).filtersUi as IDataObject;
if (filtersUi?.conditions) {
const conditions = filtersUi.conditions as IDataObject;
if (conditions.conditionsUi) {
for (const condition of conditions.conditionsUi as IDataObject[]) {
@@ -536,7 +534,7 @@ export class Salesmate implements INodeType {
}
}
}
if (filtersUi && filtersUi.operator) {
if (filtersUi?.operator) {
//@ts-ignore
body.query.group = {
operator: filtersUi.operator,
@@ -709,7 +707,7 @@ export class Salesmate implements INodeType {
itemIndex: i,
});
}
body.fields = (options.fields as string).split(',') as string[];
body.fields = (options.fields as string).split(',');
} else {
body.fields = [
'title',
@@ -728,9 +726,8 @@ export class Salesmate implements INodeType {
}
if (!jsonActive) {
const filters: IDataObject[] = [];
const filtersUi = (this.getNodeParameter('filters', i) as IDataObject)
.filtersUi as IDataObject;
if (filtersUi && filtersUi.conditions) {
const filtersUi = this.getNodeParameter('filters', i).filtersUi as IDataObject;
if (filtersUi?.conditions) {
const conditions = filtersUi.conditions as IDataObject;
if (conditions.conditionsUi) {
for (const condition of conditions.conditionsUi as IDataObject[]) {
@@ -745,7 +742,7 @@ export class Salesmate implements INodeType {
}
}
}
if (filtersUi && filtersUi.operator) {
if (filtersUi?.operator) {
//@ts-ignore
body.query.group = {
operator: filtersUi.operator,