refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/ServiceNow/ServiceNow.node.ts

@@ -621,7 +621,7 @@ export class ServiceNow implements INodeType {
 							'Content-Type': binaryData.mimeType,
 						};
 
-						const qs: IDataObject = {
+						const query: IDataObject = {
 							table_name: tableName,
 							table_sys_id: recordId,
 							file_name: binaryData.fileName
@@ -630,14 +630,14 @@ export class ServiceNow implements INodeType {
 							...options,
 						};
 
-						const body = (await this.helpers.getBinaryDataBuffer(i, inputDataFieldName)) as Buffer;
+						const body = await this.helpers.getBinaryDataBuffer(i, inputDataFieldName);
 
 						const response = await serviceNowApiRequest.call(
 							this,
 							'POST',
 							'/now/attachment/file',
 							body,
-							qs,
+							query,
 							'',
 							{ headers },
 						);
@@ -1171,7 +1171,7 @@ export class ServiceNow implements INodeType {
 
 		if (resource === 'attachment') {
 			if (operation === 'get' || operation === 'getAll') {
-				return this.prepareOutputData(returnData as INodeExecutionData[]);
+				return this.prepareOutputData(returnData);
 			}
 		}
 		return this.prepareOutputData(returnData);