refactor(core): Remove linting exceptions in nodes-base (#4794)

*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions

View File

@@ -306,7 +306,7 @@ export class Shopify implements INodeType {
qs.fulfillment_status = options.fulfillmentStatus as string;
}
if (returnAll === true) {
if (returnAll) {
responseData = await shopifyApiRequestAllItems.call(
this,
'orders',
@@ -359,11 +359,7 @@ export class Shopify implements INodeType {
if (operation === 'create') {
const title = this.getNodeParameter('title', i) as string;
const additionalFields = this.getNodeParameter(
'additionalFields',
i,
{},
) as IDataObject;
const additionalFields = this.getNodeParameter('additionalFields', i, {});
if (additionalFields.productOptions) {
const metadata = (additionalFields.productOptions as IDataObject)
@@ -396,11 +392,7 @@ export class Shopify implements INodeType {
}
if (operation === 'get') {
//https://shopify.dev/docs/admin-api/rest/reference/products/product#show-2020-04
const additionalFields = this.getNodeParameter(
'additionalFields',
i,
{},
) as IDataObject;
const additionalFields = this.getNodeParameter('additionalFields', i, {});
Object.assign(qs, additionalFields);
responseData = await shopifyApiRequest.call(
this,
@@ -413,17 +405,13 @@ export class Shopify implements INodeType {
}
if (operation === 'getAll') {
//https://shopify.dev/docs/admin-api/rest/reference/products/product#index-2020-04
const additionalFields = this.getNodeParameter(
'additionalFields',
i,
{},
) as IDataObject;
const additionalFields = this.getNodeParameter('additionalFields', i, {});
const returnAll = this.getNodeParameter('returnAll', i);
Object.assign(qs, additionalFields);
if (returnAll === true) {
if (returnAll) {
responseData = await shopifyApiRequestAllItems.call(
this,
'products',
@@ -440,7 +428,7 @@ export class Shopify implements INodeType {
}
if (operation === 'update') {
//https://shopify.dev/docs/admin-api/rest/reference/products/product?api[version]=2020-07#update-2020-07
const updateFields = this.getNodeParameter('updateFields', i, {}) as IDataObject;
const updateFields = this.getNodeParameter('updateFields', i, {});
if (updateFields.productOptions) {
const metadata = (updateFields.productOptions as IDataObject).option as IDataObject[];