admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Remove linting exceptions in nodes-base (#4794)

Browse Source 
* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/nodes-base/nodes/Strava/GenericFunctions.ts
View File

@@ -50,7 +50,7 @@ export async function stravaApiRequest(
body.client_secret = credentials.clientSecret;
}
//@ts-ignore
return this.helpers?.request(options);
return await this.helpers?.request(options);
} else {
//@ts-ignore
return await this.helpers.requestOAuth2.call(this, 'stravaOAuth2Api', options, {

2
packages/nodes-base/nodes/Strava/Strava.node.ts
View File

@@ -113,7 +113,7 @@ export class Strava implements INodeType {
`/activities/${activityId}/${path[operation]}`,
);
if (returnAll === false) {
if (!returnAll) {
const limit = this.getNodeParameter('limit', i);
responseData = responseData.splice(0, limit);
}

10
packages/nodes-base/nodes/Strava/StravaTrigger.node.ts
View File

@@ -143,7 +143,7 @@ export class StravaTrigger implements INodeType {
const body = {
callback_url: webhookUrl,
verify_token: randomBytes(20).toString('hex') as string,
verify_token: randomBytes(20).toString('hex'),
};
let responseData;
@@ -174,16 +174,16 @@ export class StravaTrigger implements INodeType {
`/push_subscriptions/${webhooks[0].id}`,
);
// now there is room create a subscription with the n8n data
const body = {
const requestBody = {
callback_url: webhookUrl,
verify_token: randomBytes(20).toString('hex') as string,
verify_token: randomBytes(20).toString('hex'),
};
responseData = await stravaApiRequest.call(
this,
'POST',
`/push_subscriptions`,
body,
requestBody,
);
} else {
error.message = `A subscription already exists [${webhooks[0].callback_url}]. If you want to delete this subcription and create a new one with the current parameters please go to options and set delete if exist to true`;
@@ -227,7 +227,7 @@ export class StravaTrigger implements INodeType {
};
async webhook(this: IWebhookFunctions): Promise<IWebhookResponseData> {
const body = this.getBodyData() as IDataObject;
const body = this.getBodyData();
const query = this.getQueryData() as IDataObject;
const object = this.getNodeParameter('object');
const event = this.getNodeParameter('event');