refactor(core): Remove linting exceptions in nodes-base (#4794)

*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Michael Kret
2022-12-02 22:54:28 +02:00
committed by GitHub
parent 8101c05d6f
commit 61e26804ba
796 changed files with 3735 additions and 2847 deletions

View File

@@ -283,7 +283,7 @@ export class Trello implements INodeType {
const id = this.getNodeParameter('id', i) as string;
returnAll = this.getNodeParameter('returnAll', i);
if (returnAll === false) {
if (!returnAll) {
qs.limit = this.getNodeParameter('limit', i);
}
@@ -499,7 +499,7 @@ export class Trello implements INodeType {
returnAll = this.getNodeParameter('returnAll', i);
if (returnAll === false) {
if (!returnAll) {
qs.limit = this.getNodeParameter('limit', i);
}
@@ -518,7 +518,7 @@ export class Trello implements INodeType {
returnAll = this.getNodeParameter('returnAll', i);
if (returnAll === false) {
if (!returnAll) {
qs.limit = this.getNodeParameter('limit', i);
}
@@ -890,11 +890,11 @@ export class Trello implements INodeType {
// paginate them 'manually'
const skipPagination = ['list:getAll'];
if (returnAll === true && !skipPagination.includes(`${resource}:${operation}`)) {
if (returnAll && !skipPagination.includes(`${resource}:${operation}`)) {
responseData = await apiRequestAllItems.call(this, requestMethod, endpoint, body, qs);
} else {
responseData = await apiRequest.call(this, requestMethod, endpoint, body, qs);
if (returnAll === false && qs.limit) {
if (!returnAll && qs.limit) {
responseData = responseData.splice(0, qs.limit);
}
}