refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/UProc/ToolDescription.ts

@@ -60,7 +60,7 @@ let parameters = [];
 //all tools
 for (const tool of (tools as IDataObject).processors as IDataObject[]) {
 	//all parameters in tool
-	for (const param of (tool as IDataObject).p as IDataObject[]) {
+	for (const param of tool.p as IDataObject[]) {
 		const displayName = param.n as string;
 		const capitalizedDisplayName = capitalize(displayName.replace(/_/g, ' '));
 		const description = `The "${capitalizedDisplayName}" value to use as a parameter for this Operation`;

packages/nodes-base/nodes/UProc/UProc.node.ts

@@ -88,10 +88,7 @@ export class UProc implements INodeType {
 		const fields = toolParameters
 			.filter((field) => {
 				return (
-					field &&
-					field.displayOptions &&
-					field.displayOptions.show &&
-					field.displayOptions.show.group &&
+					field?.displayOptions?.show?.group &&
 					field.displayOptions.show.tool &&
 					field.displayOptions.show.group.indexOf(group) !== -1 &&
 					field.displayOptions.show.tool.indexOf(tool) !== -1
@@ -111,17 +108,17 @@ export class UProc implements INodeType {
 				};
 
 				fields.forEach((field) => {
-					if (field && field.length) {
+					if (field?.length) {
 						const data = this.getNodeParameter(field, i) as string;
 						body.params[field] = data + '';
 					}
 				});
 
-				if (dataWebhook && dataWebhook.length) {
+				if (dataWebhook?.length) {
 					body.callback = {};
 				}
 
-				if (dataWebhook && dataWebhook.length) {
+				if (dataWebhook?.length) {
 					body.callback.data = dataWebhook;
 				}