refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/Venafi/ProtectCloud/GenericFunctions.ts

@@ -40,8 +40,8 @@ export async function venafiApiRequest(
 	if (operation === 'download') {
 		// We need content-type for keystore
 		if (!resource.endsWith('keystore')) {
-			delete options!.headers!['Accept'];
-			delete options!.headers!['content-type'];
+			delete options.headers!.Accept;
+			delete options.headers!['content-type'];
 		}
 	}
 
@@ -49,11 +49,7 @@ export async function venafiApiRequest(
 		if (Object.keys(body).length === 0) {
 			delete options.body;
 		}
-		return await this.helpers.requestWithAuthentication.call(
-			this,
-			'venafiTlsProtectCloudApi',
-			options,
-		);
+		return this.helpers.requestWithAuthentication.call(this, 'venafiTlsProtectCloudApi', options);
 	} catch (error) {
 		throw new NodeApiError(this.getNode(), error as JsonObject);
 	}
@@ -76,7 +72,7 @@ export async function venafiApiRequestAllItems(
 		responseData = await venafiApiRequest.call(this, method, endpoint, body, query);
 		endpoint = get(responseData, '_links[0].Next');
 		returnData.push.apply(returnData, responseData[propertyName]);
-	} while (responseData._links && responseData._links[0].Next);
+	} while (responseData._links?.[0].Next);
 
 	return returnData;
 }
@@ -112,7 +108,7 @@ export async function encryptPassphrase(
 	let encryptedKeyPass = '';
 	let encryptedKeyStorePass = '';
 
-	const promise = () => {
+	const promise = async () => {
 		return new Promise((resolve, reject) => {
 			nacl_factory.instantiate((nacl: any) => {
 				try {
@@ -134,5 +130,5 @@ export async function encryptPassphrase(
 			});
 		});
 	};
-	return await promise();
+	return promise();
 }