refactor(core): Remove linting exceptions in nodes-base (#4794)

* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/nodes-base/nodes/Zulip/Zulip.node.ts

@@ -8,14 +8,13 @@ import {
 	INodeTypeDescription,
 	NodeOperationError,
 } from 'n8n-workflow';
-import { zulipApiRequest } from './GenericFunctions';
+import { validateJSON, zulipApiRequest } from './GenericFunctions';
 import { messageFields, messageOperations } from './MessageDescription';
 import { IMessage } from './MessageInterface';
 import { snakeCase } from 'change-case';
 import { streamFields, streamOperations } from './StreamDescription';
 import { userFields, userOperations } from './UserDescription';
 import { IPrincipal, IStream } from './StreamInterface';
-import { validateJSON } from './GenericFunctions';
 import { IUser } from './UserInterface';
 
 export class Zulip implements INodeType {
@@ -295,7 +294,6 @@ export class Zulip implements INodeType {
 						} else {
 							const additionalFields = this.getNodeParameter('additionalFields', i);
 
-							const subscriptions = this.getNodeParameter('subscriptions', i) as IDataObject;
 							body.subscriptions = JSON.stringify(subscriptions.properties);
 
 							if (additionalFields.inviteOnly) {
@@ -454,7 +452,7 @@ export class Zulip implements INodeType {
 						}
 						if (additionalFields.profileData) {
 							//@ts-ignore
-							body.profile_data = additionalFields.profileData.properties as [{}];
+							body.profile_data = additionalFields.profileData.properties as [IDataObject];
 						}
 
 						responseData = await zulipApiRequest.call(this, 'PATCH', `/users/${userId}`, body);