mirror of
https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git
synced 2025-12-17 18:12:04 +00:00
ci: Refactor cli tests to speed up CI (no-changelog) (#5718)
* ci: Refactor cli tests to speed up CI (no-changelog) * upgrade jest to address memory leaks
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™
committed by
GitHub
GitHub
parent
be172cb720
commit
6242cac53b
@@ -1,26 +1,31 @@
|
||||
import express from 'express';
|
||||
import type { Application } from 'express';
|
||||
import type { SuperAgentTest } from 'supertest';
|
||||
import { UserSettings } from 'n8n-core';
|
||||
|
||||
import * as Db from '@/Db';
|
||||
import config from '@/config';
|
||||
import { RESPONSE_ERROR_MESSAGES } from '@/constants';
|
||||
import * as UserManagementHelpers from '@/UserManagement/UserManagementHelper';
|
||||
import type { CredentialsEntity } from '@db/entities/CredentialsEntity';
|
||||
import type { Role } from '@db/entities/Role';
|
||||
import type { User } from '@db/entities/User';
|
||||
import { randomCredentialPayload, randomName, randomString } from './shared/random';
|
||||
import * as testDb from './shared/testDb';
|
||||
import type { SaveCredentialFunction } from './shared/types';
|
||||
import * as utils from './shared/utils';
|
||||
|
||||
import config from '@/config';
|
||||
import type { CredentialsEntity } from '@db/entities/CredentialsEntity';
|
||||
import type { AuthAgent } from './shared/types';
|
||||
|
||||
// mock that credentialsSharing is not enabled
|
||||
const mockIsCredentialsSharingEnabled = jest.spyOn(UserManagementHelpers, 'isSharingEnabled');
|
||||
mockIsCredentialsSharingEnabled.mockReturnValue(false);
|
||||
|
||||
let app: express.Application;
|
||||
let app: Application;
|
||||
let globalOwnerRole: Role;
|
||||
let globalMemberRole: Role;
|
||||
let owner: User;
|
||||
let member: User;
|
||||
let authOwnerAgent: SuperAgentTest;
|
||||
let authMemberAgent: SuperAgentTest;
|
||||
let saveCredential: SaveCredentialFunction;
|
||||
let authAgent: AuthAgent;
|
||||
|
||||
@@ -33,13 +38,18 @@ beforeAll(async () => {
|
||||
globalMemberRole = await testDb.getGlobalMemberRole();
|
||||
const credentialOwnerRole = await testDb.getCredentialOwnerRole();
|
||||
|
||||
owner = await testDb.createUser({ globalRole: globalOwnerRole });
|
||||
member = await testDb.createUser({ globalRole: globalMemberRole });
|
||||
|
||||
saveCredential = testDb.affixRoleToSaveCredential(credentialOwnerRole);
|
||||
|
||||
authAgent = utils.createAuthAgent(app);
|
||||
authOwnerAgent = authAgent(owner);
|
||||
authMemberAgent = authAgent(member);
|
||||
});
|
||||
|
||||
beforeEach(async () => {
|
||||
await testDb.truncate(['User', 'SharedCredentials', 'Credentials']);
|
||||
await testDb.truncate(['SharedCredentials', 'Credentials']);
|
||||
});
|
||||
|
||||
afterAll(async () => {
|
||||
@@ -49,526 +59,490 @@ afterAll(async () => {
|
||||
// ----------------------------------------
|
||||
// GET /credentials - fetch all credentials
|
||||
// ----------------------------------------
|
||||
describe('GET /credentials', () => {
|
||||
test('should return all creds for owner', async () => {
|
||||
const [{ id: savedOwnerCredentialId }, { id: savedMemberCredentialId }] = await Promise.all([
|
||||
saveCredential(randomCredentialPayload(), { user: owner }),
|
||||
saveCredential(randomCredentialPayload(), { user: member }),
|
||||
]);
|
||||
|
||||
test('GET /credentials should return all creds for owner', async () => {
|
||||
const [owner, member] = await Promise.all([
|
||||
testDb.createUser({ globalRole: globalOwnerRole }),
|
||||
testDb.createUser({ globalRole: globalMemberRole }),
|
||||
]);
|
||||
const response = await authOwnerAgent.get('/credentials');
|
||||
|
||||
const [{ id: savedOwnerCredentialId }, { id: savedMemberCredentialId }] = await Promise.all([
|
||||
saveCredential(randomCredentialPayload(), { user: owner }),
|
||||
saveCredential(randomCredentialPayload(), { user: member }),
|
||||
]);
|
||||
expect(response.statusCode).toBe(200);
|
||||
expect(response.body.data.length).toBe(2); // owner retrieved owner cred and member cred
|
||||
|
||||
const response = await authAgent(owner).get('/credentials');
|
||||
const savedCredentialsIds = [savedOwnerCredentialId, savedMemberCredentialId];
|
||||
response.body.data.forEach((credential: CredentialsEntity) => {
|
||||
validateMainCredentialData(credential);
|
||||
expect(credential.data).toBeUndefined();
|
||||
expect(savedCredentialsIds).toContain(credential.id);
|
||||
});
|
||||
});
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
expect(response.body.data.length).toBe(2); // owner retrieved owner cred and member cred
|
||||
test('should return only own creds for member', async () => {
|
||||
const [member1, member2] = await testDb.createManyUsers(2, {
|
||||
globalRole: globalMemberRole,
|
||||
});
|
||||
|
||||
const savedCredentialsIds = [savedOwnerCredentialId, savedMemberCredentialId];
|
||||
response.body.data.forEach((credential: CredentialsEntity) => {
|
||||
validateMainCredentialData(credential);
|
||||
expect(credential.data).toBeUndefined();
|
||||
expect(savedCredentialsIds).toContain(credential.id);
|
||||
const [savedCredential1] = await Promise.all([
|
||||
saveCredential(randomCredentialPayload(), { user: member1 }),
|
||||
saveCredential(randomCredentialPayload(), { user: member2 }),
|
||||
]);
|
||||
|
||||
const response = await authAgent(member1).get('/credentials');
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
expect(response.body.data.length).toBe(1); // member retrieved only own cred
|
||||
|
||||
const [member1Credential] = response.body.data;
|
||||
|
||||
validateMainCredentialData(member1Credential);
|
||||
expect(member1Credential.data).toBeUndefined();
|
||||
expect(member1Credential.id).toBe(savedCredential1.id);
|
||||
});
|
||||
});
|
||||
|
||||
test('GET /credentials should return only own creds for member', async () => {
|
||||
const [member1, member2] = await testDb.createManyUsers(2, {
|
||||
globalRole: globalMemberRole,
|
||||
describe('POST /credentials', () => {
|
||||
test('should create cred', async () => {
|
||||
const payload = randomCredentialPayload();
|
||||
|
||||
const response = await authOwnerAgent.post('/credentials').send(payload);
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
|
||||
const { id, name, type, nodesAccess, data: encryptedData } = response.body.data;
|
||||
|
||||
expect(name).toBe(payload.name);
|
||||
expect(type).toBe(payload.type);
|
||||
if (!payload.nodesAccess) {
|
||||
fail('Payload did not contain a nodesAccess array');
|
||||
}
|
||||
expect(nodesAccess[0].nodeType).toBe(payload.nodesAccess[0].nodeType);
|
||||
expect(encryptedData).not.toBe(payload.data);
|
||||
|
||||
const credential = await Db.collections.Credentials.findOneByOrFail({ id });
|
||||
|
||||
expect(credential.name).toBe(payload.name);
|
||||
expect(credential.type).toBe(payload.type);
|
||||
expect(credential.nodesAccess[0].nodeType).toBe(payload.nodesAccess![0].nodeType);
|
||||
expect(credential.data).not.toBe(payload.data);
|
||||
|
||||
const sharedCredential = await Db.collections.SharedCredentials.findOneOrFail({
|
||||
relations: ['user', 'credentials'],
|
||||
where: { credentialsId: credential.id },
|
||||
});
|
||||
|
||||
expect(sharedCredential.user.id).toBe(owner.id);
|
||||
expect(sharedCredential.credentials.name).toBe(payload.name);
|
||||
});
|
||||
|
||||
const [savedCredential1] = await Promise.all([
|
||||
saveCredential(randomCredentialPayload(), { user: member1 }),
|
||||
saveCredential(randomCredentialPayload(), { user: member2 }),
|
||||
]);
|
||||
|
||||
const response = await authAgent(member1).get('/credentials');
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
expect(response.body.data.length).toBe(1); // member retrieved only own cred
|
||||
|
||||
const [member1Credential] = response.body.data;
|
||||
|
||||
validateMainCredentialData(member1Credential);
|
||||
expect(member1Credential.data).toBeUndefined();
|
||||
expect(member1Credential.id).toBe(savedCredential1.id);
|
||||
});
|
||||
|
||||
test('POST /credentials should create cred', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const payload = randomCredentialPayload();
|
||||
|
||||
const response = await authAgent(ownerShell).post('/credentials').send(payload);
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
|
||||
const { id, name, type, nodesAccess, data: encryptedData } = response.body.data;
|
||||
|
||||
expect(name).toBe(payload.name);
|
||||
expect(type).toBe(payload.type);
|
||||
if (!payload.nodesAccess) {
|
||||
fail('Payload did not contain a nodesAccess array');
|
||||
}
|
||||
expect(nodesAccess[0].nodeType).toBe(payload.nodesAccess[0].nodeType);
|
||||
expect(encryptedData).not.toBe(payload.data);
|
||||
|
||||
const credential = await Db.collections.Credentials.findOneByOrFail({ id });
|
||||
|
||||
expect(credential.name).toBe(payload.name);
|
||||
expect(credential.type).toBe(payload.type);
|
||||
expect(credential.nodesAccess[0].nodeType).toBe(payload.nodesAccess![0].nodeType);
|
||||
expect(credential.data).not.toBe(payload.data);
|
||||
|
||||
const sharedCredential = await Db.collections.SharedCredentials.findOneOrFail({
|
||||
relations: ['user', 'credentials'],
|
||||
where: { credentialsId: credential.id },
|
||||
test('should fail with invalid inputs', async () => {
|
||||
await Promise.all(
|
||||
INVALID_PAYLOADS.map(async (invalidPayload) => {
|
||||
const response = await authOwnerAgent.post('/credentials').send(invalidPayload);
|
||||
expect(response.statusCode).toBe(400);
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
expect(sharedCredential.user.id).toBe(ownerShell.id);
|
||||
expect(sharedCredential.credentials.name).toBe(payload.name);
|
||||
});
|
||||
test('should fail with missing encryption key', async () => {
|
||||
const mock = jest.spyOn(UserSettings, 'getEncryptionKey');
|
||||
mock.mockRejectedValue(new Error(RESPONSE_ERROR_MESSAGES.NO_ENCRYPTION_KEY));
|
||||
|
||||
test('POST /credentials should fail with invalid inputs', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
const authOwnerAgent = authAgent(ownerShell);
|
||||
const response = await authOwnerAgent.post('/credentials').send(randomCredentialPayload());
|
||||
|
||||
await Promise.all(
|
||||
INVALID_PAYLOADS.map(async (invalidPayload) => {
|
||||
const response = await authOwnerAgent.post('/credentials').send(invalidPayload);
|
||||
expect(response.statusCode).toBe(400);
|
||||
}),
|
||||
);
|
||||
});
|
||||
expect(response.statusCode).toBe(500);
|
||||
|
||||
test('POST /credentials should fail with missing encryption key', async () => {
|
||||
const mock = jest.spyOn(UserSettings, 'getEncryptionKey');
|
||||
mock.mockRejectedValue(new Error(RESPONSE_ERROR_MESSAGES.NO_ENCRYPTION_KEY));
|
||||
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const response = await authAgent(ownerShell).post('/credentials').send(randomCredentialPayload());
|
||||
|
||||
expect(response.statusCode).toBe(500);
|
||||
|
||||
mock.mockRestore();
|
||||
});
|
||||
|
||||
test('POST /credentials should ignore ID in payload', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
const authOwnerAgent = authAgent(ownerShell);
|
||||
|
||||
const firstResponse = await authOwnerAgent
|
||||
.post('/credentials')
|
||||
.send({ id: '8', ...randomCredentialPayload() });
|
||||
|
||||
expect(firstResponse.body.data.id).not.toBe('8');
|
||||
|
||||
const secondResponse = await authOwnerAgent
|
||||
.post('/credentials')
|
||||
.send({ id: 8, ...randomCredentialPayload() });
|
||||
|
||||
expect(secondResponse.body.data.id).not.toBe(8);
|
||||
});
|
||||
|
||||
test('DELETE /credentials/:id should delete owned cred for owner', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: ownerShell });
|
||||
|
||||
const response = await authAgent(ownerShell).delete(`/credentials/${savedCredential.id}`);
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
expect(response.body).toEqual({ data: true });
|
||||
|
||||
const deletedCredential = await Db.collections.Credentials.findOneBy({ id: savedCredential.id });
|
||||
|
||||
expect(deletedCredential).toBeNull(); // deleted
|
||||
|
||||
const deletedSharedCredential = await Db.collections.SharedCredentials.findOneBy({});
|
||||
|
||||
expect(deletedSharedCredential).toBeNull(); // deleted
|
||||
});
|
||||
|
||||
test('DELETE /credentials/:id should delete non-owned cred for owner', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: member });
|
||||
|
||||
const response = await authAgent(ownerShell).delete(`/credentials/${savedCredential.id}`);
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
expect(response.body).toEqual({ data: true });
|
||||
|
||||
const deletedCredential = await Db.collections.Credentials.findOneBy({ id: savedCredential.id });
|
||||
|
||||
expect(deletedCredential).toBeNull(); // deleted
|
||||
|
||||
const deletedSharedCredential = await Db.collections.SharedCredentials.findOneBy({});
|
||||
|
||||
expect(deletedSharedCredential).toBeNull(); // deleted
|
||||
});
|
||||
|
||||
test('DELETE /credentials/:id should delete owned cred for member', async () => {
|
||||
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: member });
|
||||
|
||||
const response = await authAgent(member).delete(`/credentials/${savedCredential.id}`);
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
expect(response.body).toEqual({ data: true });
|
||||
|
||||
const deletedCredential = await Db.collections.Credentials.findOneBy({ id: savedCredential.id });
|
||||
|
||||
expect(deletedCredential).toBeNull(); // deleted
|
||||
|
||||
const deletedSharedCredential = await Db.collections.SharedCredentials.findOneBy({});
|
||||
|
||||
expect(deletedSharedCredential).toBeNull(); // deleted
|
||||
});
|
||||
|
||||
test('DELETE /credentials/:id should not delete non-owned cred for member', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: ownerShell });
|
||||
|
||||
const response = await authAgent(member).delete(`/credentials/${savedCredential.id}`);
|
||||
|
||||
expect(response.statusCode).toBe(404);
|
||||
|
||||
const shellCredential = await Db.collections.Credentials.findOneBy({ id: savedCredential.id });
|
||||
|
||||
expect(shellCredential).toBeDefined(); // not deleted
|
||||
|
||||
const deletedSharedCredential = await Db.collections.SharedCredentials.findOneBy({});
|
||||
|
||||
expect(deletedSharedCredential).toBeDefined(); // not deleted
|
||||
});
|
||||
|
||||
test('DELETE /credentials/:id should fail if cred not found', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const response = await authAgent(ownerShell).delete('/credentials/123');
|
||||
|
||||
expect(response.statusCode).toBe(404);
|
||||
});
|
||||
|
||||
test('PATCH /credentials/:id should update owned cred for owner', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: ownerShell });
|
||||
const patchPayload = randomCredentialPayload();
|
||||
|
||||
const response = await authAgent(ownerShell)
|
||||
.patch(`/credentials/${savedCredential.id}`)
|
||||
.send(patchPayload);
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
|
||||
const { id, name, type, nodesAccess, data: encryptedData } = response.body.data;
|
||||
|
||||
expect(name).toBe(patchPayload.name);
|
||||
expect(type).toBe(patchPayload.type);
|
||||
if (!patchPayload.nodesAccess) {
|
||||
fail('Payload did not contain a nodesAccess array');
|
||||
}
|
||||
expect(nodesAccess[0].nodeType).toBe(patchPayload.nodesAccess[0].nodeType);
|
||||
|
||||
expect(encryptedData).not.toBe(patchPayload.data);
|
||||
|
||||
const credential = await Db.collections.Credentials.findOneByOrFail({ id });
|
||||
|
||||
expect(credential.name).toBe(patchPayload.name);
|
||||
expect(credential.type).toBe(patchPayload.type);
|
||||
expect(credential.nodesAccess[0].nodeType).toBe(patchPayload.nodesAccess![0].nodeType);
|
||||
expect(credential.data).not.toBe(patchPayload.data);
|
||||
|
||||
const sharedCredential = await Db.collections.SharedCredentials.findOneOrFail({
|
||||
relations: ['credentials'],
|
||||
where: { credentialsId: credential.id },
|
||||
mock.mockRestore();
|
||||
});
|
||||
|
||||
expect(sharedCredential.credentials.name).toBe(patchPayload.name); // updated
|
||||
test('should ignore ID in payload', async () => {
|
||||
const firstResponse = await authOwnerAgent
|
||||
.post('/credentials')
|
||||
.send({ id: '8', ...randomCredentialPayload() });
|
||||
|
||||
expect(firstResponse.body.data.id).not.toBe('8');
|
||||
|
||||
const secondResponse = await authOwnerAgent
|
||||
.post('/credentials')
|
||||
.send({ id: 8, ...randomCredentialPayload() });
|
||||
|
||||
expect(secondResponse.body.data.id).not.toBe(8);
|
||||
});
|
||||
});
|
||||
|
||||
test('PATCH /credentials/:id should update non-owned cred for owner', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: member });
|
||||
const patchPayload = randomCredentialPayload();
|
||||
describe('DELETE /credentials/:id', () => {
|
||||
test('should delete owned cred for owner', async () => {
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: owner });
|
||||
|
||||
const response = await authAgent(ownerShell)
|
||||
.patch(`/credentials/${savedCredential.id}`)
|
||||
.send(patchPayload);
|
||||
const response = await authOwnerAgent.delete(`/credentials/${savedCredential.id}`);
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
expect(response.statusCode).toBe(200);
|
||||
expect(response.body).toEqual({ data: true });
|
||||
|
||||
const { id, name, type, nodesAccess, data: encryptedData } = response.body.data;
|
||||
const deletedCredential = await Db.collections.Credentials.findOneBy({
|
||||
id: savedCredential.id,
|
||||
});
|
||||
|
||||
expect(name).toBe(patchPayload.name);
|
||||
expect(type).toBe(patchPayload.type);
|
||||
expect(deletedCredential).toBeNull(); // deleted
|
||||
|
||||
if (!patchPayload.nodesAccess) {
|
||||
fail('Payload did not contain a nodesAccess array');
|
||||
}
|
||||
expect(nodesAccess[0].nodeType).toBe(patchPayload.nodesAccess[0].nodeType);
|
||||
const deletedSharedCredential = await Db.collections.SharedCredentials.findOneBy({});
|
||||
|
||||
expect(encryptedData).not.toBe(patchPayload.data);
|
||||
|
||||
const credential = await Db.collections.Credentials.findOneByOrFail({ id });
|
||||
|
||||
expect(credential.name).toBe(patchPayload.name);
|
||||
expect(credential.type).toBe(patchPayload.type);
|
||||
expect(credential.nodesAccess[0].nodeType).toBe(patchPayload.nodesAccess![0].nodeType);
|
||||
expect(credential.data).not.toBe(patchPayload.data);
|
||||
|
||||
const sharedCredential = await Db.collections.SharedCredentials.findOneOrFail({
|
||||
relations: ['credentials'],
|
||||
where: { credentialsId: credential.id },
|
||||
expect(deletedSharedCredential).toBeNull(); // deleted
|
||||
});
|
||||
|
||||
expect(sharedCredential.credentials.name).toBe(patchPayload.name); // updated
|
||||
});
|
||||
test('should delete non-owned cred for owner', async () => {
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: member });
|
||||
|
||||
test('PATCH /credentials/:id should update owned cred for member', async () => {
|
||||
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: member });
|
||||
const patchPayload = randomCredentialPayload();
|
||||
const response = await authOwnerAgent.delete(`/credentials/${savedCredential.id}`);
|
||||
|
||||
const response = await authAgent(member)
|
||||
.patch(`/credentials/${savedCredential.id}`)
|
||||
.send(patchPayload);
|
||||
expect(response.statusCode).toBe(200);
|
||||
expect(response.body).toEqual({ data: true });
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
const deletedCredential = await Db.collections.Credentials.findOneBy({
|
||||
id: savedCredential.id,
|
||||
});
|
||||
|
||||
const { id, name, type, nodesAccess, data: encryptedData } = response.body.data;
|
||||
expect(deletedCredential).toBeNull(); // deleted
|
||||
|
||||
expect(name).toBe(patchPayload.name);
|
||||
expect(type).toBe(patchPayload.type);
|
||||
const deletedSharedCredential = await Db.collections.SharedCredentials.findOneBy({});
|
||||
|
||||
if (!patchPayload.nodesAccess) {
|
||||
fail('Payload did not contain a nodesAccess array');
|
||||
}
|
||||
expect(nodesAccess[0].nodeType).toBe(patchPayload.nodesAccess[0].nodeType);
|
||||
|
||||
expect(encryptedData).not.toBe(patchPayload.data);
|
||||
|
||||
const credential = await Db.collections.Credentials.findOneByOrFail({ id });
|
||||
|
||||
expect(credential.name).toBe(patchPayload.name);
|
||||
expect(credential.type).toBe(patchPayload.type);
|
||||
expect(credential.nodesAccess[0].nodeType).toBe(patchPayload.nodesAccess![0].nodeType);
|
||||
expect(credential.data).not.toBe(patchPayload.data);
|
||||
|
||||
const sharedCredential = await Db.collections.SharedCredentials.findOneOrFail({
|
||||
relations: ['credentials'],
|
||||
where: { credentialsId: credential.id },
|
||||
expect(deletedSharedCredential).toBeNull(); // deleted
|
||||
});
|
||||
|
||||
expect(sharedCredential.credentials.name).toBe(patchPayload.name); // updated
|
||||
});
|
||||
test('should delete owned cred for member', async () => {
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: member });
|
||||
|
||||
test('PATCH /credentials/:id should not update non-owned cred for member', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: ownerShell });
|
||||
const patchPayload = randomCredentialPayload();
|
||||
const response = await authMemberAgent.delete(`/credentials/${savedCredential.id}`);
|
||||
|
||||
const response = await authAgent(member)
|
||||
.patch(`/credentials/${savedCredential.id}`)
|
||||
.send(patchPayload);
|
||||
expect(response.statusCode).toBe(200);
|
||||
expect(response.body).toEqual({ data: true });
|
||||
|
||||
expect(response.statusCode).toBe(404);
|
||||
const deletedCredential = await Db.collections.Credentials.findOneBy({
|
||||
id: savedCredential.id,
|
||||
});
|
||||
|
||||
const shellCredential = await Db.collections.Credentials.findOneByOrFail({
|
||||
id: savedCredential.id,
|
||||
expect(deletedCredential).toBeNull(); // deleted
|
||||
|
||||
const deletedSharedCredential = await Db.collections.SharedCredentials.findOneBy({});
|
||||
|
||||
expect(deletedSharedCredential).toBeNull(); // deleted
|
||||
});
|
||||
|
||||
expect(shellCredential.name).not.toBe(patchPayload.name); // not updated
|
||||
test('should not delete non-owned cred for member', async () => {
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: owner });
|
||||
|
||||
const response = await authMemberAgent.delete(`/credentials/${savedCredential.id}`);
|
||||
|
||||
expect(response.statusCode).toBe(404);
|
||||
|
||||
const shellCredential = await Db.collections.Credentials.findOneBy({ id: savedCredential.id });
|
||||
|
||||
expect(shellCredential).toBeDefined(); // not deleted
|
||||
|
||||
const deletedSharedCredential = await Db.collections.SharedCredentials.findOneBy({});
|
||||
|
||||
expect(deletedSharedCredential).toBeDefined(); // not deleted
|
||||
});
|
||||
|
||||
test('should fail if cred not found', async () => {
|
||||
const response = await authOwnerAgent.delete('/credentials/123');
|
||||
|
||||
expect(response.statusCode).toBe(404);
|
||||
});
|
||||
});
|
||||
|
||||
test('PATCH /credentials/:id should fail with invalid inputs', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
const authOwnerAgent = authAgent(ownerShell);
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: ownerShell });
|
||||
describe('PATCH /credentials/:id', () => {
|
||||
test('should update owned cred for owner', async () => {
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: owner });
|
||||
const patchPayload = randomCredentialPayload();
|
||||
|
||||
await Promise.all(
|
||||
INVALID_PAYLOADS.map(async (invalidPayload) => {
|
||||
const response = await authOwnerAgent
|
||||
.patch(`/credentials/${savedCredential.id}`)
|
||||
.send(invalidPayload);
|
||||
const response = await authOwnerAgent
|
||||
.patch(`/credentials/${savedCredential.id}`)
|
||||
.send(patchPayload);
|
||||
|
||||
if (response.statusCode === 500) {
|
||||
console.log(response.statusCode, response.body);
|
||||
expect(response.statusCode).toBe(200);
|
||||
|
||||
const { id, name, type, nodesAccess, data: encryptedData } = response.body.data;
|
||||
|
||||
expect(name).toBe(patchPayload.name);
|
||||
expect(type).toBe(patchPayload.type);
|
||||
if (!patchPayload.nodesAccess) {
|
||||
fail('Payload did not contain a nodesAccess array');
|
||||
}
|
||||
expect(nodesAccess[0].nodeType).toBe(patchPayload.nodesAccess[0].nodeType);
|
||||
|
||||
expect(encryptedData).not.toBe(patchPayload.data);
|
||||
|
||||
const credential = await Db.collections.Credentials.findOneByOrFail({ id });
|
||||
|
||||
expect(credential.name).toBe(patchPayload.name);
|
||||
expect(credential.type).toBe(patchPayload.type);
|
||||
expect(credential.nodesAccess[0].nodeType).toBe(patchPayload.nodesAccess![0].nodeType);
|
||||
expect(credential.data).not.toBe(patchPayload.data);
|
||||
|
||||
const sharedCredential = await Db.collections.SharedCredentials.findOneOrFail({
|
||||
relations: ['credentials'],
|
||||
where: { credentialsId: credential.id },
|
||||
});
|
||||
|
||||
expect(sharedCredential.credentials.name).toBe(patchPayload.name); // updated
|
||||
});
|
||||
|
||||
test('should update non-owned cred for owner', async () => {
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: member });
|
||||
const patchPayload = randomCredentialPayload();
|
||||
|
||||
const response = await authOwnerAgent
|
||||
.patch(`/credentials/${savedCredential.id}`)
|
||||
.send(patchPayload);
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
|
||||
const { id, name, type, nodesAccess, data: encryptedData } = response.body.data;
|
||||
|
||||
expect(name).toBe(patchPayload.name);
|
||||
expect(type).toBe(patchPayload.type);
|
||||
|
||||
if (!patchPayload.nodesAccess) {
|
||||
fail('Payload did not contain a nodesAccess array');
|
||||
}
|
||||
expect(nodesAccess[0].nodeType).toBe(patchPayload.nodesAccess[0].nodeType);
|
||||
|
||||
expect(encryptedData).not.toBe(patchPayload.data);
|
||||
|
||||
const credential = await Db.collections.Credentials.findOneByOrFail({ id });
|
||||
|
||||
expect(credential.name).toBe(patchPayload.name);
|
||||
expect(credential.type).toBe(patchPayload.type);
|
||||
expect(credential.nodesAccess[0].nodeType).toBe(patchPayload.nodesAccess![0].nodeType);
|
||||
expect(credential.data).not.toBe(patchPayload.data);
|
||||
|
||||
const sharedCredential = await Db.collections.SharedCredentials.findOneOrFail({
|
||||
relations: ['credentials'],
|
||||
where: { credentialsId: credential.id },
|
||||
});
|
||||
|
||||
expect(sharedCredential.credentials.name).toBe(patchPayload.name); // updated
|
||||
});
|
||||
|
||||
test('should update owned cred for member', async () => {
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: member });
|
||||
const patchPayload = randomCredentialPayload();
|
||||
|
||||
const response = await authMemberAgent
|
||||
.patch(`/credentials/${savedCredential.id}`)
|
||||
.send(patchPayload);
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
|
||||
const { id, name, type, nodesAccess, data: encryptedData } = response.body.data;
|
||||
|
||||
expect(name).toBe(patchPayload.name);
|
||||
expect(type).toBe(patchPayload.type);
|
||||
|
||||
if (!patchPayload.nodesAccess) {
|
||||
fail('Payload did not contain a nodesAccess array');
|
||||
}
|
||||
expect(nodesAccess[0].nodeType).toBe(patchPayload.nodesAccess[0].nodeType);
|
||||
|
||||
expect(encryptedData).not.toBe(patchPayload.data);
|
||||
|
||||
const credential = await Db.collections.Credentials.findOneByOrFail({ id });
|
||||
|
||||
expect(credential.name).toBe(patchPayload.name);
|
||||
expect(credential.type).toBe(patchPayload.type);
|
||||
expect(credential.nodesAccess[0].nodeType).toBe(patchPayload.nodesAccess![0].nodeType);
|
||||
expect(credential.data).not.toBe(patchPayload.data);
|
||||
|
||||
const sharedCredential = await Db.collections.SharedCredentials.findOneOrFail({
|
||||
relations: ['credentials'],
|
||||
where: { credentialsId: credential.id },
|
||||
});
|
||||
|
||||
expect(sharedCredential.credentials.name).toBe(patchPayload.name); // updated
|
||||
});
|
||||
|
||||
test('should not update non-owned cred for member', async () => {
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: owner });
|
||||
const patchPayload = randomCredentialPayload();
|
||||
|
||||
const response = await authMemberAgent
|
||||
.patch(`/credentials/${savedCredential.id}`)
|
||||
.send(patchPayload);
|
||||
|
||||
expect(response.statusCode).toBe(404);
|
||||
|
||||
const shellCredential = await Db.collections.Credentials.findOneByOrFail({
|
||||
id: savedCredential.id,
|
||||
});
|
||||
|
||||
expect(shellCredential.name).not.toBe(patchPayload.name); // not updated
|
||||
});
|
||||
|
||||
test('should fail with invalid inputs', async () => {
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: owner });
|
||||
|
||||
await Promise.all(
|
||||
INVALID_PAYLOADS.map(async (invalidPayload) => {
|
||||
const response = await authOwnerAgent
|
||||
.patch(`/credentials/${savedCredential.id}`)
|
||||
.send(invalidPayload);
|
||||
|
||||
if (response.statusCode === 500) {
|
||||
console.log(response.statusCode, response.body);
|
||||
}
|
||||
expect(response.statusCode).toBe(400);
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
test('should fail if cred not found', async () => {
|
||||
const response = await authOwnerAgent.patch('/credentials/123').send(randomCredentialPayload());
|
||||
|
||||
expect(response.statusCode).toBe(404);
|
||||
});
|
||||
|
||||
test('should fail with missing encryption key', async () => {
|
||||
const mock = jest.spyOn(UserSettings, 'getEncryptionKey');
|
||||
mock.mockRejectedValue(new Error(RESPONSE_ERROR_MESSAGES.NO_ENCRYPTION_KEY));
|
||||
|
||||
const response = await authOwnerAgent.post('/credentials').send(randomCredentialPayload());
|
||||
|
||||
expect(response.statusCode).toBe(500);
|
||||
|
||||
mock.mockRestore();
|
||||
});
|
||||
});
|
||||
|
||||
describe('GET /credentials/new', () => {
|
||||
test('should return default name for new credential or its increment', async () => {
|
||||
const name = config.getEnv('credentials.defaultName');
|
||||
let tempName = name;
|
||||
|
||||
for (let i = 0; i < 4; i++) {
|
||||
const response = await authOwnerAgent.get(`/credentials/new?name=${name}`);
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
if (i === 0) {
|
||||
expect(response.body.data.name).toBe(name);
|
||||
} else {
|
||||
tempName = name + ' ' + (i + 1);
|
||||
expect(response.body.data.name).toBe(tempName);
|
||||
}
|
||||
expect(response.statusCode).toBe(400);
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
test('PATCH /credentials/:id should fail if cred not found', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const response = await authAgent(ownerShell)
|
||||
.patch('/credentials/123')
|
||||
.send(randomCredentialPayload());
|
||||
|
||||
expect(response.statusCode).toBe(404);
|
||||
});
|
||||
|
||||
test('PATCH /credentials/:id should fail with missing encryption key', async () => {
|
||||
const mock = jest.spyOn(UserSettings, 'getEncryptionKey');
|
||||
mock.mockRejectedValue(new Error(RESPONSE_ERROR_MESSAGES.NO_ENCRYPTION_KEY));
|
||||
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const response = await authAgent(ownerShell).post('/credentials').send(randomCredentialPayload());
|
||||
|
||||
expect(response.statusCode).toBe(500);
|
||||
|
||||
mock.mockRestore();
|
||||
});
|
||||
|
||||
test('GET /credentials/new should return default name for new credential or its increment', async () => {
|
||||
const ownerShell = await testDb.createUser({ globalRole: globalOwnerRole });
|
||||
const authOwnerAgent = authAgent(ownerShell);
|
||||
const name = config.getEnv('credentials.defaultName');
|
||||
let tempName = name;
|
||||
|
||||
for (let i = 0; i < 4; i++) {
|
||||
const response = await authOwnerAgent.get(`/credentials/new?name=${name}`);
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
if (i === 0) {
|
||||
expect(response.body.data.name).toBe(name);
|
||||
} else {
|
||||
tempName = name + ' ' + (i + 1);
|
||||
expect(response.body.data.name).toBe(tempName);
|
||||
await saveCredential({ ...randomCredentialPayload(), name: tempName }, { user: owner });
|
||||
}
|
||||
await saveCredential({ ...randomCredentialPayload(), name: tempName }, { user: ownerShell });
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
test('GET /credentials/new should return name from query for new credential or its increment', async () => {
|
||||
const ownerShell = await testDb.createUser({ globalRole: globalOwnerRole });
|
||||
const authOwnerAgent = authAgent(ownerShell);
|
||||
const name = 'special credential name';
|
||||
let tempName = name;
|
||||
test('should return name from query for new credential or its increment', async () => {
|
||||
const name = 'special credential name';
|
||||
let tempName = name;
|
||||
|
||||
for (let i = 0; i < 4; i++) {
|
||||
const response = await authOwnerAgent.get(`/credentials/new?name=${name}`);
|
||||
for (let i = 0; i < 4; i++) {
|
||||
const response = await authOwnerAgent.get(`/credentials/new?name=${name}`);
|
||||
|
||||
expect(response.statusCode).toBe(200);
|
||||
if (i === 0) {
|
||||
expect(response.body.data.name).toBe(name);
|
||||
} else {
|
||||
tempName = name + ' ' + (i + 1);
|
||||
expect(response.body.data.name).toBe(tempName);
|
||||
expect(response.statusCode).toBe(200);
|
||||
if (i === 0) {
|
||||
expect(response.body.data.name).toBe(name);
|
||||
} else {
|
||||
tempName = name + ' ' + (i + 1);
|
||||
expect(response.body.data.name).toBe(tempName);
|
||||
}
|
||||
await saveCredential({ ...randomCredentialPayload(), name: tempName }, { user: owner });
|
||||
}
|
||||
await saveCredential({ ...randomCredentialPayload(), name: tempName }, { user: ownerShell });
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
test('GET /credentials/:id should retrieve owned cred for owner', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
const authOwnerAgent = authAgent(ownerShell);
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: ownerShell });
|
||||
describe('GET /credentials/:id', () => {
|
||||
test('should retrieve owned cred for owner', async () => {
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: owner });
|
||||
|
||||
const firstResponse = await authOwnerAgent.get(`/credentials/${savedCredential.id}`);
|
||||
const firstResponse = await authOwnerAgent.get(`/credentials/${savedCredential.id}`);
|
||||
|
||||
expect(firstResponse.statusCode).toBe(200);
|
||||
expect(firstResponse.statusCode).toBe(200);
|
||||
|
||||
validateMainCredentialData(firstResponse.body.data);
|
||||
expect(firstResponse.body.data.data).toBeUndefined();
|
||||
validateMainCredentialData(firstResponse.body.data);
|
||||
expect(firstResponse.body.data.data).toBeUndefined();
|
||||
|
||||
const secondResponse = await authOwnerAgent
|
||||
.get(`/credentials/${savedCredential.id}`)
|
||||
.query({ includeData: true });
|
||||
const secondResponse = await authOwnerAgent
|
||||
.get(`/credentials/${savedCredential.id}`)
|
||||
.query({ includeData: true });
|
||||
|
||||
validateMainCredentialData(secondResponse.body.data);
|
||||
expect(secondResponse.body.data.data).toBeDefined();
|
||||
});
|
||||
validateMainCredentialData(secondResponse.body.data);
|
||||
expect(secondResponse.body.data.data).toBeDefined();
|
||||
});
|
||||
|
||||
test('GET /credentials/:id should retrieve owned cred for member', async () => {
|
||||
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
||||
const authMemberAgent = authAgent(member);
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: member });
|
||||
test('should retrieve owned cred for member', async () => {
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: member });
|
||||
|
||||
const firstResponse = await authMemberAgent.get(`/credentials/${savedCredential.id}`);
|
||||
const firstResponse = await authMemberAgent.get(`/credentials/${savedCredential.id}`);
|
||||
|
||||
expect(firstResponse.statusCode).toBe(200);
|
||||
expect(firstResponse.statusCode).toBe(200);
|
||||
|
||||
validateMainCredentialData(firstResponse.body.data);
|
||||
expect(firstResponse.body.data.data).toBeUndefined();
|
||||
validateMainCredentialData(firstResponse.body.data);
|
||||
expect(firstResponse.body.data.data).toBeUndefined();
|
||||
|
||||
const secondResponse = await authMemberAgent
|
||||
.get(`/credentials/${savedCredential.id}`)
|
||||
.query({ includeData: true });
|
||||
const secondResponse = await authMemberAgent
|
||||
.get(`/credentials/${savedCredential.id}`)
|
||||
.query({ includeData: true });
|
||||
|
||||
expect(secondResponse.statusCode).toBe(200);
|
||||
expect(secondResponse.statusCode).toBe(200);
|
||||
|
||||
validateMainCredentialData(secondResponse.body.data);
|
||||
expect(secondResponse.body.data.data).toBeDefined();
|
||||
});
|
||||
validateMainCredentialData(secondResponse.body.data);
|
||||
expect(secondResponse.body.data.data).toBeDefined();
|
||||
});
|
||||
|
||||
test('GET /credentials/:id should retrieve non-owned cred for owner', async () => {
|
||||
const owner = await testDb.createUser({ globalRole: globalOwnerRole });
|
||||
const authOwnerAgent = authAgent(owner);
|
||||
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
||||
test('should retrieve non-owned cred for owner', async () => {
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: member });
|
||||
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: member });
|
||||
const response1 = await authOwnerAgent.get(`/credentials/${savedCredential.id}`);
|
||||
|
||||
const response1 = await authOwnerAgent.get(`/credentials/${savedCredential.id}`);
|
||||
expect(response1.statusCode).toBe(200);
|
||||
|
||||
expect(response1.statusCode).toBe(200);
|
||||
validateMainCredentialData(response1.body.data);
|
||||
expect(response1.body.data.data).toBeUndefined();
|
||||
|
||||
validateMainCredentialData(response1.body.data);
|
||||
expect(response1.body.data.data).toBeUndefined();
|
||||
const response2 = await authOwnerAgent
|
||||
.get(`/credentials/${savedCredential.id}`)
|
||||
.query({ includeData: true });
|
||||
|
||||
const response2 = await authOwnerAgent
|
||||
.get(`/credentials/${savedCredential.id}`)
|
||||
.query({ includeData: true });
|
||||
expect(response2.statusCode).toBe(200);
|
||||
|
||||
expect(response2.statusCode).toBe(200);
|
||||
validateMainCredentialData(response2.body.data);
|
||||
expect(response2.body.data.data).toBeDefined();
|
||||
});
|
||||
|
||||
validateMainCredentialData(response2.body.data);
|
||||
expect(response2.body.data.data).toBeDefined();
|
||||
});
|
||||
test('should not retrieve non-owned cred for member', async () => {
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: owner });
|
||||
|
||||
test('GET /credentials/:id should not retrieve non-owned cred for member', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: ownerShell });
|
||||
const response = await authMemberAgent.get(`/credentials/${savedCredential.id}`);
|
||||
|
||||
const response = await authAgent(member).get(`/credentials/${savedCredential.id}`);
|
||||
expect(response.statusCode).toBe(404);
|
||||
expect(response.body.data).toBeUndefined(); // owner's cred not returned
|
||||
});
|
||||
|
||||
expect(response.statusCode).toBe(404);
|
||||
expect(response.body.data).toBeUndefined(); // owner's cred not returned
|
||||
});
|
||||
test('should fail with missing encryption key', async () => {
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: owner });
|
||||
|
||||
test('GET /credentials/:id should fail with missing encryption key', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
const savedCredential = await saveCredential(randomCredentialPayload(), { user: ownerShell });
|
||||
const mock = jest.spyOn(UserSettings, 'getEncryptionKey');
|
||||
mock.mockRejectedValue(new Error(RESPONSE_ERROR_MESSAGES.NO_ENCRYPTION_KEY));
|
||||
|
||||
const mock = jest.spyOn(UserSettings, 'getEncryptionKey');
|
||||
mock.mockRejectedValue(new Error(RESPONSE_ERROR_MESSAGES.NO_ENCRYPTION_KEY));
|
||||
const response = await authOwnerAgent
|
||||
.get(`/credentials/${savedCredential.id}`)
|
||||
.query({ includeData: true });
|
||||
|
||||
const response = await authAgent(ownerShell)
|
||||
.get(`/credentials/${savedCredential.id}`)
|
||||
.query({ includeData: true });
|
||||
expect(response.statusCode).toBe(500);
|
||||
|
||||
expect(response.statusCode).toBe(500);
|
||||
mock.mockRestore();
|
||||
});
|
||||
|
||||
mock.mockRestore();
|
||||
});
|
||||
test('should return 404 if cred not found', async () => {
|
||||
const response = await authOwnerAgent.get('/credentials/789');
|
||||
expect(response.statusCode).toBe(404);
|
||||
|
||||
test('GET /credentials/:id should return 404 if cred not found', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
const response = await authAgent(ownerShell).get('/credentials/789');
|
||||
expect(response.statusCode).toBe(404);
|
||||
|
||||
const responseAbc = await authAgent(ownerShell).get('/credentials/abc');
|
||||
expect(responseAbc.statusCode).toBe(404);
|
||||
const responseAbc = await authOwnerAgent.get('/credentials/abc');
|
||||
expect(responseAbc.statusCode).toBe(404);
|
||||
});
|
||||
});
|
||||
|
||||
function validateMainCredentialData(credential: CredentialsEntity) {
|
||||
|
||||
Reference in New Issue
Block a user