mirror of
https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git
synced 2025-12-18 02:21:13 +00:00
ci: Refactor cli tests to speed up CI (no-changelog) (#5718)
* ci: Refactor cli tests to speed up CI (no-changelog) * upgrade jest to address memory leaks
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™
committed by
GitHub
GitHub
parent
be172cb720
commit
6242cac53b
@@ -1,10 +1,6 @@
|
||||
import path from 'path';
|
||||
|
||||
import express from 'express';
|
||||
import { mocked } from 'jest-mock';
|
||||
|
||||
import * as utils from './shared/utils';
|
||||
import * as testDb from './shared/testDb';
|
||||
import type { SuperAgentTest } from 'supertest';
|
||||
import {
|
||||
executeCommand,
|
||||
checkNpmPackageStatus,
|
||||
@@ -15,13 +11,13 @@ import {
|
||||
import { findInstalledPackage, isPackageInstalled } from '@/CommunityNodes/packageModel';
|
||||
import { LoadNodesAndCredentials } from '@/LoadNodesAndCredentials';
|
||||
import { InstalledPackages } from '@db/entities/InstalledPackages';
|
||||
|
||||
import type { Role } from '@db/entities/Role';
|
||||
import type { AuthAgent } from './shared/types';
|
||||
import type { User } from '@db/entities/User';
|
||||
import type { InstalledNodes } from '@db/entities/InstalledNodes';
|
||||
import { COMMUNITY_PACKAGE_VERSION } from './shared/constants';
|
||||
import { NodeTypes } from '@/NodeTypes';
|
||||
import { Push } from '@/push';
|
||||
import { COMMUNITY_PACKAGE_VERSION } from './shared/constants';
|
||||
import * as utils from './shared/utils';
|
||||
import * as testDb from './shared/testDb';
|
||||
|
||||
const mockLoadNodesAndCredentials = utils.mockInstance(LoadNodesAndCredentials);
|
||||
utils.mockInstance(NodeTypes);
|
||||
@@ -48,22 +44,21 @@ jest.mock('@/CommunityNodes/packageModel', () => {
|
||||
|
||||
const mockedEmptyPackage = mocked(utils.emptyPackage);
|
||||
|
||||
let app: express.Application;
|
||||
let globalOwnerRole: Role;
|
||||
let authAgent: AuthAgent;
|
||||
let ownerShell: User;
|
||||
let authOwnerShellAgent: SuperAgentTest;
|
||||
|
||||
beforeAll(async () => {
|
||||
app = await utils.initTestServer({ endpointGroups: ['nodes'] });
|
||||
const app = await utils.initTestServer({ endpointGroups: ['nodes'] });
|
||||
|
||||
globalOwnerRole = await testDb.getGlobalOwnerRole();
|
||||
|
||||
authAgent = utils.createAuthAgent(app);
|
||||
const globalOwnerRole = await testDb.getGlobalOwnerRole();
|
||||
ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
authOwnerShellAgent = utils.createAuthAgent(app)(ownerShell);
|
||||
|
||||
utils.initConfigFile();
|
||||
});
|
||||
|
||||
beforeEach(async () => {
|
||||
await testDb.truncate(['InstalledNodes', 'InstalledPackages', 'User']);
|
||||
await testDb.truncate(['InstalledNodes', 'InstalledPackages']);
|
||||
|
||||
mocked(executeCommand).mockReset();
|
||||
mocked(findInstalledPackage).mockReset();
|
||||
@@ -73,255 +68,216 @@ afterAll(async () => {
|
||||
await testDb.terminate();
|
||||
});
|
||||
|
||||
/**
|
||||
* GET /nodes
|
||||
*/
|
||||
describe('GET /nodes', () => {
|
||||
test('should respond 200 if no nodes are installed', async () => {
|
||||
const {
|
||||
statusCode,
|
||||
body: { data },
|
||||
} = await authOwnerShellAgent.get('/nodes');
|
||||
|
||||
test('GET /nodes should respond 200 if no nodes are installed', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
expect(statusCode).toBe(200);
|
||||
expect(data).toHaveLength(0);
|
||||
});
|
||||
|
||||
const {
|
||||
statusCode,
|
||||
body: { data },
|
||||
} = await authAgent(ownerShell).get('/nodes');
|
||||
test('should return list of one installed package and node', async () => {
|
||||
const { packageName } = await testDb.saveInstalledPackage(utils.installedPackagePayload());
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(packageName));
|
||||
|
||||
expect(statusCode).toBe(200);
|
||||
expect(data).toHaveLength(0);
|
||||
});
|
||||
const {
|
||||
statusCode,
|
||||
body: { data },
|
||||
} = await authOwnerShellAgent.get('/nodes');
|
||||
|
||||
test('GET /nodes should return list of one installed package and node', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
expect(statusCode).toBe(200);
|
||||
expect(data).toHaveLength(1);
|
||||
expect(data[0].installedNodes).toHaveLength(1);
|
||||
});
|
||||
|
||||
const { packageName } = await testDb.saveInstalledPackage(utils.installedPackagePayload());
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(packageName));
|
||||
test('should return list of multiple installed packages and nodes', async () => {
|
||||
const first = await testDb.saveInstalledPackage(utils.installedPackagePayload());
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(first.packageName));
|
||||
|
||||
const {
|
||||
statusCode,
|
||||
body: { data },
|
||||
} = await authAgent(ownerShell).get('/nodes');
|
||||
const second = await testDb.saveInstalledPackage(utils.installedPackagePayload());
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(second.packageName));
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(second.packageName));
|
||||
|
||||
expect(statusCode).toBe(200);
|
||||
expect(data).toHaveLength(1);
|
||||
expect(data[0].installedNodes).toHaveLength(1);
|
||||
});
|
||||
const {
|
||||
statusCode,
|
||||
body: { data },
|
||||
} = await authOwnerShellAgent.get('/nodes');
|
||||
|
||||
test('GET /nodes should return list of multiple installed packages and nodes', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
expect(statusCode).toBe(200);
|
||||
expect(data).toHaveLength(2);
|
||||
|
||||
const first = await testDb.saveInstalledPackage(utils.installedPackagePayload());
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(first.packageName));
|
||||
const allNodes = data.reduce(
|
||||
(acc: InstalledNodes[], cur: InstalledPackages) => acc.concat(cur.installedNodes),
|
||||
[],
|
||||
);
|
||||
|
||||
const second = await testDb.saveInstalledPackage(utils.installedPackagePayload());
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(second.packageName));
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(second.packageName));
|
||||
expect(allNodes).toHaveLength(3);
|
||||
});
|
||||
|
||||
const {
|
||||
statusCode,
|
||||
body: { data },
|
||||
} = await authAgent(ownerShell).get('/nodes');
|
||||
test('should not check for updates if no packages installed', async () => {
|
||||
await authOwnerShellAgent.get('/nodes');
|
||||
|
||||
expect(statusCode).toBe(200);
|
||||
expect(data).toHaveLength(2);
|
||||
expect(mocked(executeCommand)).toHaveBeenCalledTimes(0);
|
||||
});
|
||||
|
||||
const allNodes = data.reduce(
|
||||
(acc: InstalledNodes[], cur: InstalledPackages) => acc.concat(cur.installedNodes),
|
||||
[],
|
||||
);
|
||||
test('should check for updates if packages installed', async () => {
|
||||
const { packageName } = await testDb.saveInstalledPackage(utils.installedPackagePayload());
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(packageName));
|
||||
|
||||
expect(allNodes).toHaveLength(3);
|
||||
});
|
||||
await authOwnerShellAgent.get('/nodes');
|
||||
|
||||
test('GET /nodes should not check for updates if no packages installed', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
expect(mocked(executeCommand)).toHaveBeenCalledWith('npm outdated --json', {
|
||||
doNotHandleError: true,
|
||||
});
|
||||
});
|
||||
|
||||
await authAgent(ownerShell).get('/nodes');
|
||||
test('should report package updates if available', async () => {
|
||||
const { packageName } = await testDb.saveInstalledPackage(utils.installedPackagePayload());
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(packageName));
|
||||
|
||||
expect(mocked(executeCommand)).toHaveBeenCalledTimes(0);
|
||||
});
|
||||
mocked(executeCommand).mockImplementationOnce(() => {
|
||||
throw {
|
||||
code: 1,
|
||||
stdout: JSON.stringify({
|
||||
[packageName]: {
|
||||
current: COMMUNITY_PACKAGE_VERSION.CURRENT,
|
||||
wanted: COMMUNITY_PACKAGE_VERSION.CURRENT,
|
||||
latest: COMMUNITY_PACKAGE_VERSION.UPDATED,
|
||||
location: path.join('node_modules', packageName),
|
||||
},
|
||||
}),
|
||||
};
|
||||
});
|
||||
|
||||
test('GET /nodes should check for updates if packages installed', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
mocked(isNpmError).mockReturnValueOnce(true);
|
||||
|
||||
const { packageName } = await testDb.saveInstalledPackage(utils.installedPackagePayload());
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(packageName));
|
||||
const {
|
||||
body: { data },
|
||||
} = await authOwnerShellAgent.get('/nodes');
|
||||
|
||||
await authAgent(ownerShell).get('/nodes');
|
||||
|
||||
expect(mocked(executeCommand)).toHaveBeenCalledWith('npm outdated --json', {
|
||||
doNotHandleError: true,
|
||||
expect(data[0].installedVersion).toBe(COMMUNITY_PACKAGE_VERSION.CURRENT);
|
||||
expect(data[0].updateAvailable).toBe(COMMUNITY_PACKAGE_VERSION.UPDATED);
|
||||
});
|
||||
});
|
||||
|
||||
test('GET /nodes should report package updates if available', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
describe('POST /nodes', () => {
|
||||
test('should reject if package name is missing', async () => {
|
||||
const { statusCode } = await authOwnerShellAgent.post('/nodes');
|
||||
|
||||
const { packageName } = await testDb.saveInstalledPackage(utils.installedPackagePayload());
|
||||
await testDb.saveInstalledNode(utils.installedNodePayload(packageName));
|
||||
|
||||
mocked(executeCommand).mockImplementationOnce(() => {
|
||||
throw {
|
||||
code: 1,
|
||||
stdout: JSON.stringify({
|
||||
[packageName]: {
|
||||
current: COMMUNITY_PACKAGE_VERSION.CURRENT,
|
||||
wanted: COMMUNITY_PACKAGE_VERSION.CURRENT,
|
||||
latest: COMMUNITY_PACKAGE_VERSION.UPDATED,
|
||||
location: path.join('node_modules', packageName),
|
||||
},
|
||||
}),
|
||||
};
|
||||
expect(statusCode).toBe(400);
|
||||
});
|
||||
|
||||
mocked(isNpmError).mockReturnValueOnce(true);
|
||||
test('should reject if package is duplicate', async () => {
|
||||
mocked(findInstalledPackage).mockResolvedValueOnce(new InstalledPackages());
|
||||
mocked(isPackageInstalled).mockResolvedValueOnce(true);
|
||||
mocked(hasPackageLoaded).mockReturnValueOnce(true);
|
||||
|
||||
const {
|
||||
body: { data },
|
||||
} = await authAgent(ownerShell).get('/nodes');
|
||||
const {
|
||||
statusCode,
|
||||
body: { message },
|
||||
} = await authOwnerShellAgent.post('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
});
|
||||
|
||||
expect(data[0].installedVersion).toBe(COMMUNITY_PACKAGE_VERSION.CURRENT);
|
||||
expect(data[0].updateAvailable).toBe(COMMUNITY_PACKAGE_VERSION.UPDATED);
|
||||
});
|
||||
|
||||
/**
|
||||
* POST /nodes
|
||||
*/
|
||||
|
||||
test('POST /nodes should reject if package name is missing', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const { statusCode } = await authAgent(ownerShell).post('/nodes');
|
||||
|
||||
expect(statusCode).toBe(400);
|
||||
});
|
||||
|
||||
test('POST /nodes should reject if package is duplicate', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
mocked(findInstalledPackage).mockResolvedValueOnce(new InstalledPackages());
|
||||
mocked(isPackageInstalled).mockResolvedValueOnce(true);
|
||||
mocked(hasPackageLoaded).mockReturnValueOnce(true);
|
||||
|
||||
const {
|
||||
statusCode,
|
||||
body: { message },
|
||||
} = await authAgent(ownerShell).post('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
expect(statusCode).toBe(400);
|
||||
expect(message).toContain('already installed');
|
||||
});
|
||||
|
||||
expect(statusCode).toBe(400);
|
||||
expect(message).toContain('already installed');
|
||||
});
|
||||
test('should allow installing packages that could not be loaded', async () => {
|
||||
mocked(findInstalledPackage).mockResolvedValueOnce(new InstalledPackages());
|
||||
mocked(hasPackageLoaded).mockReturnValueOnce(false);
|
||||
mocked(checkNpmPackageStatus).mockResolvedValueOnce({ status: 'OK' });
|
||||
|
||||
test('POST /nodes should allow installing packages that could not be loaded', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
mockLoadNodesAndCredentials.loadNpmModule.mockImplementationOnce(mockedEmptyPackage);
|
||||
|
||||
mocked(findInstalledPackage).mockResolvedValueOnce(new InstalledPackages());
|
||||
mocked(hasPackageLoaded).mockReturnValueOnce(false);
|
||||
mocked(checkNpmPackageStatus).mockResolvedValueOnce({ status: 'OK' });
|
||||
const { statusCode } = await authOwnerShellAgent.post('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
});
|
||||
|
||||
mockLoadNodesAndCredentials.loadNpmModule.mockImplementationOnce(mockedEmptyPackage);
|
||||
|
||||
const { statusCode } = await authAgent(ownerShell).post('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
expect(statusCode).toBe(200);
|
||||
expect(mocked(removePackageFromMissingList)).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
expect(statusCode).toBe(200);
|
||||
expect(mocked(removePackageFromMissingList)).toHaveBeenCalled();
|
||||
test('should not install a banned package', async () => {
|
||||
mocked(checkNpmPackageStatus).mockResolvedValueOnce({ status: 'Banned' });
|
||||
|
||||
const {
|
||||
statusCode,
|
||||
body: { message },
|
||||
} = await authOwnerShellAgent.post('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
});
|
||||
|
||||
expect(statusCode).toBe(400);
|
||||
expect(message).toContain('banned');
|
||||
});
|
||||
});
|
||||
|
||||
test('POST /nodes should not install a banned package', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
mocked(checkNpmPackageStatus).mockResolvedValueOnce({ status: 'Banned' });
|
||||
describe('DELETE /nodes', () => {
|
||||
test('should not delete if package name is empty', async () => {
|
||||
const response = await authOwnerShellAgent.delete('/nodes');
|
||||
|
||||
const {
|
||||
statusCode,
|
||||
body: { message },
|
||||
} = await authAgent(ownerShell).post('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
expect(response.statusCode).toBe(400);
|
||||
});
|
||||
|
||||
expect(statusCode).toBe(400);
|
||||
expect(message).toContain('banned');
|
||||
});
|
||||
test('should reject if package is not installed', async () => {
|
||||
const {
|
||||
statusCode,
|
||||
body: { message },
|
||||
} = await authOwnerShellAgent.delete('/nodes').query({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
});
|
||||
|
||||
/**
|
||||
* DELETE /nodes
|
||||
*/
|
||||
|
||||
test('DELETE /nodes should not delete if package name is empty', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const response = await authAgent(ownerShell).delete('/nodes');
|
||||
|
||||
expect(response.statusCode).toBe(400);
|
||||
});
|
||||
|
||||
test('DELETE /nodes should reject if package is not installed', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const {
|
||||
statusCode,
|
||||
body: { message },
|
||||
} = await authAgent(ownerShell).delete('/nodes').query({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
expect(statusCode).toBe(400);
|
||||
expect(message).toContain('not installed');
|
||||
});
|
||||
|
||||
expect(statusCode).toBe(400);
|
||||
expect(message).toContain('not installed');
|
||||
test('should uninstall package', async () => {
|
||||
const removeSpy = mockLoadNodesAndCredentials.removeNpmModule.mockImplementationOnce(jest.fn());
|
||||
|
||||
mocked(findInstalledPackage).mockImplementationOnce(mockedEmptyPackage);
|
||||
|
||||
const { statusCode } = await authOwnerShellAgent.delete('/nodes').query({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
});
|
||||
|
||||
expect(statusCode).toBe(200);
|
||||
expect(removeSpy).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
});
|
||||
|
||||
test('DELETE /nodes should uninstall package', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
describe('PATCH /nodes', () => {
|
||||
test('should reject if package name is empty', async () => {
|
||||
const response = await authOwnerShellAgent.patch('/nodes');
|
||||
|
||||
const removeSpy = mockLoadNodesAndCredentials.removeNpmModule.mockImplementationOnce(jest.fn());
|
||||
|
||||
mocked(findInstalledPackage).mockImplementationOnce(mockedEmptyPackage);
|
||||
|
||||
const { statusCode } = await authAgent(ownerShell).delete('/nodes').query({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
expect(response.statusCode).toBe(400);
|
||||
});
|
||||
|
||||
expect(statusCode).toBe(200);
|
||||
expect(removeSpy).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
test('reject if package is not installed', async () => {
|
||||
const {
|
||||
statusCode,
|
||||
body: { message },
|
||||
} = await authOwnerShellAgent.patch('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
});
|
||||
|
||||
/**
|
||||
* PATCH /nodes
|
||||
*/
|
||||
|
||||
test('PATCH /nodes should reject if package name is empty', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const response = await authAgent(ownerShell).patch('/nodes');
|
||||
|
||||
expect(response.statusCode).toBe(400);
|
||||
});
|
||||
|
||||
test('PATCH /nodes reject if package is not installed', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
|
||||
const {
|
||||
statusCode,
|
||||
body: { message },
|
||||
} = await authAgent(ownerShell).patch('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
expect(statusCode).toBe(400);
|
||||
expect(message).toContain('not installed');
|
||||
});
|
||||
|
||||
expect(statusCode).toBe(400);
|
||||
expect(message).toContain('not installed');
|
||||
});
|
||||
test('should update a package', async () => {
|
||||
const updateSpy =
|
||||
mockLoadNodesAndCredentials.updateNpmModule.mockImplementationOnce(mockedEmptyPackage);
|
||||
|
||||
test('PATCH /nodes should update a package', async () => {
|
||||
const ownerShell = await testDb.createUserShell(globalOwnerRole);
|
||||
mocked(findInstalledPackage).mockImplementationOnce(mockedEmptyPackage);
|
||||
|
||||
const updateSpy =
|
||||
mockLoadNodesAndCredentials.updateNpmModule.mockImplementationOnce(mockedEmptyPackage);
|
||||
await authOwnerShellAgent.patch('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
});
|
||||
|
||||
mocked(findInstalledPackage).mockImplementationOnce(mockedEmptyPackage);
|
||||
|
||||
await authAgent(ownerShell).patch('/nodes').send({
|
||||
name: utils.installedPackagePayload().packageName,
|
||||
expect(updateSpy).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
expect(updateSpy).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user